From nobody Fri May 17 12:14:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) client-ip=209.85.221.50; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f50.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1632692346; cv=none; d=zohomail.com; s=zohoarc; b=XyAqVuFdS4VYdpqIxMcrUl5FFKJqwjbhrjack1SqPQk44D5fMH4uadWUpJM+3/tXZghr+Y3ccBRwvCEoWvvK8wGZ6hVZd8R4BV4sq0SdctmKZs37/SZKVT4xZl47De1+dDjzS3UwwK6ent3DRSu9ygwLVqe3kr8wWTHqsZmKuTA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1632692346; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=Zn/EeFiHzDUyaGhXtsd/E2eXxlWN4jO4U2XJ3ypuRU8=; b=lpBupywxQ1KFcuOTW6ASIRfIkjUnbPOWrQcLZVf/To0zvLYZHIWbMFw3lwZiC2REwsWKAm3nxTu3y0y2wW60ro910ZnCJ1CZZdyM9zTC2NpL6YSQxT7bi//HucxGjSZkqNl1KWhwW9fXkFjJN+jMskXRKcnbSmb8GiUihwWf3d0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mx.zohomail.com with SMTPS id 1632692346784294.2085677455316; Sun, 26 Sep 2021 14:39:06 -0700 (PDT) Received: by mail-wr1-f50.google.com with SMTP id x20so1537844wrg.10 for ; Sun, 26 Sep 2021 14:39:06 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id 4sm13854324wmv.42.2021.09.26.14.39.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Sep 2021 14:39:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Zn/EeFiHzDUyaGhXtsd/E2eXxlWN4jO4U2XJ3ypuRU8=; b=TusnAc1oGYHvPlvcSQLjOn/YShIM3N+QvWAZlUMwNDBu1uvHUYutfOjrPDO4kfj8sX b+9+ls89Fi0fRVdtyFsqDEK0fgaD3gOMV5P0CEpsQ1K//tjLEdXsUYStw9o3B+zyrDi1 0K0sOZlegd0Ge98hiFS3UxXweYTR14ZI+7lKO83GETPK579ITIPV2Hx+dNQPk3WvlOaX 7So0iMatCiCDWBrFq3ATQ3YPTSRbRqgBIFWWO0eB3hNDcMktRGezL05YpoJ8auklCPQp KigcmDpFCnwRbFMXrhGSMjsnVeUsGu3QFjO99BNJIU9g3TqZ5vcfpZ3dkx9VG3rQrR1H XlMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=Zn/EeFiHzDUyaGhXtsd/E2eXxlWN4jO4U2XJ3ypuRU8=; b=CYBlB6VxkxS6F3p9dR3SO1Qmds5b8Rm5hH3kf2Cq9EOyqpRE5IiwwBcZKrleNKDDYi ycW4WpaaSFNolwcBK3GIFQ3lMBN1bF5CDmUy2mfKVPqVd7t04DnYEZibL6uA3VmzuuqQ 3+xHBtZBxvqBaO7o0svAwSgg26HCS3YFrfh6BSTleDPV72c2QMxRxTlxTgbdPf9qOD8L lMW4EH7mGOg5uYImIlHRxlXhiz9Q+Dyhi224o5trx4plhQAjSX6LHH/uts2Y2Zv5AKel yivtb5xm2IQySWJ/v6//tozdasXwn/Uw1qF/XW7/ybVfqJ4O0HkxnshT3DvuJjJroRFa s7jA== X-Gm-Message-State: AOAM531WA7bjjjEX3ppMXEHqafSBxj+RhkhrmKFgkggRPwTy8rIwGkjs Sq1i/ToElNZua8a2K+MuU3s= X-Google-Smtp-Source: ABdhPJxiVb52ouDAu7b9pG6QN8xK6OND6x6i7sqCdqaARk4Tph92KlBMWliKcuKPocFbggL8vNiDqg== X-Received: by 2002:adf:a31a:: with SMTP id c26mr25367673wrb.307.1632692344935; Sun, 26 Sep 2021 14:39:04 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Alistair Francis , Palmer Dabbelt , Joelle van Dyne , Richard Henderson , qemu-riscv@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH] tcg/riscv: Fix potential bug in clobbered call register set Date: Sun, 26 Sep 2021 23:39:02 +0200 Message-Id: <20210926213902.1713506-1-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1632692348022100001 The tcg_target_call_clobber_regs variable is of type TCGRegSet, which is unsigned and might be 64-bit wide. By initializing it as unsigned type, only 32-bit are set. Currently the RISCV TCG backend only uses 32 registers, so this is not a problem. However if more register were to be implemented (such vectors) then it would become problematic. Since we are better safe than sorry, properly initialize the value as 64-bit. Fixes: 7a5549f2aea ("tcg/riscv: Add the target init code") Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- tcg/riscv/tcg-target.c.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/riscv/tcg-target.c.inc b/tcg/riscv/tcg-target.c.inc index dc8d8f1de23..5bd95633b0d 100644 --- a/tcg/riscv/tcg-target.c.inc +++ b/tcg/riscv/tcg-target.c.inc @@ -1734,7 +1734,7 @@ static void tcg_target_init(TCGContext *s) tcg_target_available_regs[TCG_TYPE_I64] =3D 0xffffffff; } =20 - tcg_target_call_clobber_regs =3D -1u; + tcg_target_call_clobber_regs =3D -1ull; tcg_regset_reset_reg(tcg_target_call_clobber_regs, TCG_REG_S0); tcg_regset_reset_reg(tcg_target_call_clobber_regs, TCG_REG_S1); tcg_regset_reset_reg(tcg_target_call_clobber_regs, TCG_REG_S2); --=20 2.31.1