From nobody Tue Feb 10 09:57:32 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) client-ip=209.85.221.45; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f45.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1632581672; cv=none; d=zohomail.com; s=zohoarc; b=TEkE/kAEyz9T2k4pVIaNheWL4oofB8Lf9zXycvd+uKkXc4EmRTdhx4gpLIwPeBf6N3WYrwb2DGk6zcr3sEdA7DwYO4g1+8nz4WkO823mdwuRpwWBsNWZq+EVs7UArYGZLBfr1klW30l/Sz2p/ahntl1Y59xPFUgLuJoWyTlx7ag= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1632581672; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=L6ntqmXS7ifceLSpB74XEWOrQdhQXzlIYsRxqC94HM4=; b=gn299QzkIVMW1rzon2A76AGdKx2ayYSoD/jEG6b7t01y4pm3d1nCiHzeQPDGBK+EAJaPFAdfyrqNcbj3nJWD22/IYFvQtmECMOAVQCVA19XwcL3z1WbqL6o/geCoNFSuyBRQTzyrOyR69oLikMqQg55UP/cT0ZQeYnOL92BR/6M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by mx.zohomail.com with SMTPS id 163258167286555.04830125737544; Sat, 25 Sep 2021 07:54:32 -0700 (PDT) Received: by mail-wr1-f45.google.com with SMTP id r23so11151960wra.6 for ; Sat, 25 Sep 2021 07:54:32 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id f9sm108882wmf.3.2021.09.25.07.54.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Sep 2021 07:54:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=L6ntqmXS7ifceLSpB74XEWOrQdhQXzlIYsRxqC94HM4=; b=XXmlP6cLFpZrFEwpSQpqLjkIeoXbqru4Jzhp3Pae/ZVwAcQVcE5kqnZ25vCtt3IK5C ujgZIx0F+BjhHfFArQMuZYhqrCwjLe6kxBt0m1BR1jqSzhko5KaxNOQH4y5l7qXjwrLB zNERBOP+Or7Lhuhj8dV+OBUbvGy7UMgnyHAfa08ltO4yuqQ41InTJzmnUASj5Q9BwORP loxtfZ5/NXAqQprsPM6JeboJVjWHvbaE+59lEmgcVR5CMXl56SntlcqiuqoPInaKLAhb rTWpeHqhT2Em7d7MW3WAdjZZzDwr2LB/8SMoD52fY4ULB4/wKfW7WokQvN8bUW0pxoZ2 XbCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=L6ntqmXS7ifceLSpB74XEWOrQdhQXzlIYsRxqC94HM4=; b=ihXjbOIqi/Ur6GMVHymn8lJ3AdZvdaxuoOEDDBKDrKUXmzBToz2DK1bA3WAWvd9mcB ZyBoSd0VkOxGSYIdSHWWGaFORG638X7DRpkXnN2aODiQ+tK1PllrnKX24p6MKKBSzNz8 KPWH+EmnWxN7IcL0Jrft9Hbcm+BTZF4+FzGad64njwB08HSp3p5eFUrJKY8F7RiS7AN3 3EX0/J5zZWTdpP67FogudOQHMJcKrUl4YiQSHzZ0Cyz55D3xXfw1yICcIHbM0Go/C4Rr pF6buwUvuTXua1YMbo6Q0ZyDzDmxOAgJiMvh+rg9R9a6ER491SIRiL0AwuqHdIxZUVpC 3KTQ== X-Gm-Message-State: AOAM530QVwUna06a9vO0ToEFaCQKoqX3VBYb6bEV8VMeDx7DeJ6A3Mlw g30FbpfCslLfEqaTrncmqC0= X-Google-Smtp-Source: ABdhPJxrqfAIyw96x1bvkCaCx6I8daOxiy5ZHNxF76Bp8IK2BEuJbPZ6vgedWh16WWOKz/ApMNYYtA== X-Received: by 2002:a1c:7413:: with SMTP id p19mr7418733wmc.98.1632581671055; Sat, 25 Sep 2021 07:54:31 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini Subject: [PATCH v7 40/40] accel/tcg: Simplify tcg_cpu_has_work() Date: Sat, 25 Sep 2021 16:51:18 +0200 Message-Id: <20210925145118.1361230-41-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210925145118.1361230-1-f4bug@amsat.org> References: <20210925145118.1361230-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1632581674179100001 All TCG targets implement the TCGCPUOps::has_work() handler. We can remove the non-NULL handler check in tcg_cpu_has_work(). Add an assertion in tcg_exec_realizefn() for future TCG targets. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- accel/tcg/cpu-exec.c | 6 ++++++ accel/tcg/tcg-accel-ops.c | 5 +---- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 5fd1ed34222..d577a65237c 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -993,6 +993,12 @@ void tcg_exec_realizefn(CPUState *cpu, Error **errp) CPUClass *cc =3D CPU_GET_CLASS(cpu); =20 if (!tcg_target_initialized) { + /* Mandatory non-NULL handlers */ + g_assert(cc->tcg_ops->initialize); +#ifndef CONFIG_USER_ONLY + g_assert(cc->tcg_ops->has_work); +#endif /* !CONFIG_USER_ONLY */ + cc->tcg_ops->initialize(); tcg_target_initialized =3D true; } diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c index 3c75ed2cccc..6cd32f04cb9 100644 --- a/accel/tcg/tcg-accel-ops.c +++ b/accel/tcg/tcg-accel-ops.c @@ -78,10 +78,7 @@ static bool tcg_cpu_has_work(CPUState *cpu) { CPUClass *cc =3D CPU_GET_CLASS(cpu); =20 - if (cc->tcg_ops->has_work) { - return cc->tcg_ops->has_work(cpu); - } - return false; + return cc->tcg_ops->has_work(cpu); } =20 /* mask must never be zero, except for A20 change call */ --=20 2.31.1