From nobody Tue Feb 10 05:16:59 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) client-ip=209.85.221.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1632581668; cv=none; d=zohomail.com; s=zohoarc; b=PIq7SPabasbjBqMUO7fHh8Wv2JareKoP6sGLGeV2u//F2jPOpd5jFHCvxthyhtl38mpHUsPwTB5gxqD+q99fuN2zXj/gIytdQY4se4zn7P6PClSIiXAWBr1IxCNjoqbcyBrQUOC4GZK2Pav6LFX1pSV5rbF+FAW6ibZ2TEJMnuo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1632581668; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=p+FhEVuxYvtBhbZfLgBuFMc/Z1Zw1Ec9d9CUDDVANlA=; b=BDJofxjf8JaCrqXSBqv54k7tPA28iyqzLrHU7pcHOnA/ztn+faETrEmw6pB8i+UecuBWooUuCroCNCEty9XAWg5CudgWhy+BQpSkCXVMHa2woMr2xygPBBuZJNUT9FPYZ7WDVJmjFS0+MmnHzV/RKBnJ32o4JEQpgtlPQLmD0fg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by mx.zohomail.com with SMTPS id 1632581668097328.80668311757904; Sat, 25 Sep 2021 07:54:28 -0700 (PDT) Received: by mail-wr1-f52.google.com with SMTP id r23so11151632wra.6 for ; Sat, 25 Sep 2021 07:54:27 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id j4sm11680888wrt.67.2021.09.25.07.54.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Sep 2021 07:54:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=p+FhEVuxYvtBhbZfLgBuFMc/Z1Zw1Ec9d9CUDDVANlA=; b=j2XKcvZjAzhbF0iXh1wHoimnzK7MTcasZiXgGUDBIw24aQkysZpZV2MgjkdvCQaqqB uvmyElm74VQUVie93oSPhaseqL1alTXdcYvvpm7YDSbt249dKlqfFL6WTX7EenuptBjZ 9WhNhhKr1XFI8+BTCXM9VmbMFhIOiMCHyeTfBHeLXleTUpUv3PQ/LGkXUaxAHujJbm3W xyZnPFTls1bGWelGTcb5BQIlHW/umcbs0QrgfrG4x+1TT6/Eoo8dQR9gHgFVhj+lNfRk C/i30R73O83Xy2w1GlS9ziojb4DslJe/IHVHFiFV9YaXZ9p48+4hiQN8wH3u9UFaW7AF MeNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=p+FhEVuxYvtBhbZfLgBuFMc/Z1Zw1Ec9d9CUDDVANlA=; b=vw+YJeJRPXWEybKe/vGgzVkENsrligUVVcvlvD5WmfK8MUmKvZpyW3ZfyptODrq+mC amM8RaIV0WMBiZ88DKWZQp2jtNZG+PWNlaV6q4HsJHSf6DdtR05jzcDmtyTBxzO2MPNs j/3ERASBeS33qvH4yX/3MKZGuwQa+cxTKGvwh9H4sowrWY6XsIq+MvpnQ+XeYLwZO5x6 9cFBCTK3/N1qRPRvbJoTI084IWCJ4axv64FvYRsyON0DkTHMiY/qsQoFmgkm+69anVP7 kx76lpMrg0WaYEgHL8dnKDRPrz02L/i6n63Tiz2TJueLutoEp1hvLFN3PQ+WowB18EOs 3tKQ== X-Gm-Message-State: AOAM532bcwOj8EOslZ/EPQAEamirecDMu2MKVgkqHTOeAG/WkRqc9keu 06k8ZzCrl2kkQKiB2Q6Stug= X-Google-Smtp-Source: ABdhPJw8KBnY91I/w/nFC+xmJ1P2SRFfjejZY8DVCqC6ojyqeRXr6WksgOhHl4teltZayCtSxnIkGg== X-Received: by 2002:a7b:c766:: with SMTP id x6mr7293341wmk.53.1632581666382; Sat, 25 Sep 2021 07:54:26 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , Eduardo Habkost , Marcel Apfelbaum Subject: [PATCH v7 39/40] accel/tcg: Remove CPUClass::has_work() Date: Sat, 25 Sep 2021 16:51:17 +0200 Message-Id: <20210925145118.1361230-40-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210925145118.1361230-1-f4bug@amsat.org> References: <20210925145118.1361230-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1632581669940100001 Now that all TCG targets converted their CPUClass::has_work() handler to a TCGCPUOps::has_work() one, we can remove has_work from CPUClass. Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/core/cpu.h | 2 -- accel/tcg/tcg-accel-ops.c | 3 --- 2 files changed, 5 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 114eb3b9b2c..c64709b898c 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -89,7 +89,6 @@ struct SysemuCPUOps; * instantiatable CPU type. * @parse_features: Callback to parse command line arguments. * @reset_dump_flags: #CPUDumpFlags to use for reset logging. - * @has_work: Callback for checking if there is work to do. Only used by T= CG. * @memory_rw_debug: Callback for GDB memory access. * @dump_state: Callback for dumping state. * @get_arch_id: Callback for getting architecture-dependent CPU ID. @@ -132,7 +131,6 @@ struct CPUClass { void (*parse_features)(const char *typename, char *str, Error **errp); =20 int reset_dump_flags; - bool (*has_work)(CPUState *cpu); int (*memory_rw_debug)(CPUState *cpu, vaddr addr, uint8_t *buf, int len, bool is_write); void (*dump_state)(CPUState *cpu, FILE *, int flags); diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c index cd44bb6d0d8..3c75ed2cccc 100644 --- a/accel/tcg/tcg-accel-ops.c +++ b/accel/tcg/tcg-accel-ops.c @@ -78,9 +78,6 @@ static bool tcg_cpu_has_work(CPUState *cpu) { CPUClass *cc =3D CPU_GET_CLASS(cpu); =20 - if (cc->has_work) { - return cc->has_work(cpu); - } if (cc->tcg_ops->has_work) { return cc->tcg_ops->has_work(cpu); } --=20 2.31.1