From nobody Tue Feb 10 06:27:16 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) client-ip=209.85.221.44; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f44.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1632581486; cv=none; d=zohomail.com; s=zohoarc; b=YVZXbweKAMHyAAOWSp7aFGr9+BmnWhPWQPpbN0dWPOK9mvPTwj8SIf+2KS8u/q0Tfzt7vpt5CsMSmxzoSgN6x2dyrZ5uOLwmnBEKc2Zewdm3o8eRZ2ZzCFexju46PYRC1vKg+BJB72ouODN4NpowpMFbVq4CokEbNLu0MaTPqXk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1632581486; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5Bzxb+cyFW2fTjguo4+D1GgUMJzgo2oIaa6x4dhI9M8=; b=nE2Ugw8Ti6aZF+yb6Xrdb+y3kP2YzQU7vIgXrBWnL2//UUUTOU7LjC/3Y8H/xMqcNPFkkh70ee+oEP3kbDRiVPOWYU7im9sjq05QvR5SboWTZpwT6Ubpiby38gxcaJiie4zd53H2DluwnIWaFQFAbTtS+tZtr24GHtIYAZvzfrY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by mx.zohomail.com with SMTPS id 1632581486100583.1784730083101; Sat, 25 Sep 2021 07:51:26 -0700 (PDT) Received: by mail-wr1-f44.google.com with SMTP id g16so36511764wrb.3 for ; Sat, 25 Sep 2021 07:51:25 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id j21sm11103624wrd.48.2021.09.25.07.51.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Sep 2021 07:51:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5Bzxb+cyFW2fTjguo4+D1GgUMJzgo2oIaa6x4dhI9M8=; b=OXTzlc0l5v/r8uLvsReuOKdN3lsOY9J7V5T3b1v/C2sV26LnTKMFGdwfhFT/8vxdHS 0Go9INDMsXeMhAECUBjGHlV+KmHKaTRG3whAnRlP340XS5kD21J6RsxmCHDxoJ0xpd0z 62r8N2JZyHVq7NJ9YGL4ikGLjBRehYLzA4fdxms+0JLckSlv7SzCyGazecRWFfb1ZQq8 tp/8FyPVL+MvsuUtRHqveeae4+hW3drsKgbfJkAq/StOvPKmhPMePCJG4khmwgPW2K+j NNCtNQQG/7l88ca2Z27fPncaDZUz8L+ltujFdzRfBiOn7FAXP/U9CPfg7ndWnEwQ2Cam LHNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=5Bzxb+cyFW2fTjguo4+D1GgUMJzgo2oIaa6x4dhI9M8=; b=T9CPYc24oy9q2/lWtJ7UskG7CSbh+4/Ar5n/XNDANmL38Pw2sOKbUFUNq3j2ULRsrM YOqrJWqBoeYb2/PXxabdfaOZExEixjQDpsGg+5H5Y3VGDOZSv6JviejTU5deYv5NoPII DXqK9f0d2ulzrIZAQKYWpgWOwwOjm5Ur7YMQBdeGGZrNj0d1lt7kEM6KwYh6VohXUkl3 8hegfLmNU4Q8uJKpx2FkzL/FpRQo2X2rcqLD8adI9biIUX+o9YVBD12z4mZCglvBYAkJ F/rrIxF9k4lA6TYCL0vEybOciTOgujpSOHcjinugM56OZDtARc5CxRh/UQl5cG33YA1C oVIw== X-Gm-Message-State: AOAM531KfuDNjmcxAtPSOY6Pf2oxd/2un+HnHfTs6VpdM3d7V5PG3Lg7 Y5G9tdUWvmzFVPIHB23X4nE= X-Google-Smtp-Source: ABdhPJzq85pYyiQEMby/nqs+kxyz8pcpHVsgN5LX6GqmttvViHhfZs4diirSV8lBDozrvbI7Ug+nYA== X-Received: by 2002:a5d:6d81:: with SMTP id l1mr17809354wrs.404.1632581484389; Sat, 25 Sep 2021 07:51:24 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini Subject: [PATCH v7 01/40] accel: Simplify qemu_init_vcpu() Date: Sat, 25 Sep 2021 16:50:39 +0200 Message-Id: <20210925145118.1361230-2-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210925145118.1361230-1-f4bug@amsat.org> References: <20210925145118.1361230-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1632581487398100001 cpus_register_accel() already checks for ops->create_vcpu_thread being non-NULL, so it is pointless to re-check for it in qemu_init_vcpu(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- softmmu/cpus.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/softmmu/cpus.c b/softmmu/cpus.c index 071085f840b..646326b24fd 100644 --- a/softmmu/cpus.c +++ b/softmmu/cpus.c @@ -604,7 +604,10 @@ void cpu_remove_sync(CPUState *cpu) void cpus_register_accel(const AccelOpsClass *ops) { assert(ops !=3D NULL); - assert(ops->create_vcpu_thread !=3D NULL); /* mandatory */ + + /* Mandatory non-NULL handlers */ + assert(ops->create_vcpu_thread !=3D NULL); + cpus_accel =3D ops; } =20 @@ -626,7 +629,7 @@ void qemu_init_vcpu(CPUState *cpu) } =20 /* accelerators all implement the AccelOpsClass */ - g_assert(cpus_accel !=3D NULL && cpus_accel->create_vcpu_thread !=3D N= ULL); + g_assert(cpus_accel !=3D NULL); cpus_accel->create_vcpu_thread(cpu); =20 while (!cpu->created) { --=20 2.31.1