From nobody Mon Feb 9 22:38:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) client-ip=209.85.221.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1632476369; cv=none; d=zohomail.com; s=zohoarc; b=ERCG0HWjFpRZiXKfA1mDLoTFB9zfTLY6LeajB1nGj6AeCCK/UUynlHmuZDPbO4HRghWKguErtkXZnQb/MrK7BzvFmwNJXYrMhsQwP/9jAelUW6pXV4TlvZznfJRl7H7eJrJ/oioU52KgIQNrESKG/n/2NDEX/AnnsVi8C7or2wA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1632476369; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vUe+1tkOVnIH977cfWQkm6Ao8Hfy7tcpnU7MaXPzIOo=; b=h/pb4Ghdl5PeX78Cz0IbhrPnflt0is/FFluWciK9OalhrOUA2oEoZaQ5KW66CMNOYytlBGSB5eQLbxzbT2uzhnA/JlWZR+md0XJDo8GrlyVpUuBYc0aiK2pIlIJx/sZWES4P03azvPGlFw0pQ1YEnG337ChZAV1nrymOUd80UP0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by mx.zohomail.com with SMTPS id 1632476369067644.9150406515381; Fri, 24 Sep 2021 02:39:29 -0700 (PDT) Received: by mail-wr1-f52.google.com with SMTP id w17so25389366wrv.10 for ; Fri, 24 Sep 2021 02:39:28 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id n19sm1326723wms.47.2021.09.24.02.39.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Sep 2021 02:39:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vUe+1tkOVnIH977cfWQkm6Ao8Hfy7tcpnU7MaXPzIOo=; b=NOXtP4tivCAS91rDMAhwcVwUZzXzzbkSv+QjKJ53FeSn9Xi9BrrohzeIoOe083Auhf Rovu2J9tDQUgFTnOnJA0A8JS1Fh/vbSmLlgh8Z6CRoWsxqQF4+8H1ulArWxRhjbzp2RO BQr3FSkNYMVbFsYi+maJfwF0AV6r609/wpE1pmr8/O12OrMonO2p+PPNi1i3/d0RKyfM 8CvbEpYFwGLhhiS/TXF9BgXuMB1W3XMYVD6QgCr6i5t55wCHcvQ59GkoVaTDg7NjiSAk txaVcnhdtpKICqfoPxSdrKU6Cy0xajhMTjXKVO4I3Zj1rA0oKTlfrfRkFZR+Gyw6el64 a/9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=vUe+1tkOVnIH977cfWQkm6Ao8Hfy7tcpnU7MaXPzIOo=; b=1yxB15PZ2VeEtcvaPZdUc9aP0cPUdDjhFEGYwQN8JnqtbW0DgMB18Nmqz1YaTe7j/b JiZnPwTlptxStGdL6XICD9NPTDdhMxscNkHSKyhUVMIBq2oJC/jzjGlQ7YdJJMDA2Lse M5imWs1BELwVYMFQSQ8JeVKZUo0AgcLBbrVl9GYUVcC/7ZBAwbXbwvKh39XHsysNE9jy qKslVYq10LYqgn7l8wrE5NRh2sufNpQxUNno3fcyKEwddjaYyJ/j1Go3u8v9Kxi1XEuy GavGnbjMpqiBGl0jCMloYaKdoxPoU4g0xHzpORTX/lDTEFCqoOAzeOzD8VNtLJ348z/C itNw== X-Gm-Message-State: AOAM5313utBoTN/h/7+CIpqgL4qwDrM655mYmox6Vxhpvd2Uy25/qlZ9 l+pprU4XI583rMWH3F4xKVY= X-Google-Smtp-Source: ABdhPJxAfed0bikX3dT1RihVvD06PW1q4E6qZ3w02UQIER2y5HHf+TNjB7gg0sCIGuc2E7m2Gcfnug== X-Received: by 2002:a5d:4538:: with SMTP id j24mr10277773wra.348.1632476367315; Fri, 24 Sep 2021 02:39:27 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , Sunil Muthuswamy Subject: [PATCH v6 08/40] accel/whpx: Implement AccelOpsClass::has_work() Date: Fri, 24 Sep 2021 11:38:15 +0200 Message-Id: <20210924093847.1014331-9-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210924093847.1014331-1-f4bug@amsat.org> References: <20210924093847.1014331-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1632476370578100001 Implement WHPX has_work() handler in AccelOpsClass and remove it from cpu_thread_is_idle() since cpu_has_work() is already called. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- softmmu/cpus.c | 4 +--- target/i386/whpx/whpx-accel-ops.c | 6 ++++++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/softmmu/cpus.c b/softmmu/cpus.c index c9f54a09989..5ffa02f9cef 100644 --- a/softmmu/cpus.c +++ b/softmmu/cpus.c @@ -41,7 +41,6 @@ #include "sysemu/replay.h" #include "sysemu/runstate.h" #include "sysemu/cpu-timers.h" -#include "sysemu/whpx.h" #include "hw/boards.h" #include "hw/hw.h" #include "trace.h" @@ -89,8 +88,7 @@ bool cpu_thread_is_idle(CPUState *cpu) if (cpu_is_stopped(cpu)) { return true; } - if (!cpu->halted || cpu_has_work(cpu) || - whpx_apic_in_platform()) { + if (!cpu->halted || cpu_has_work(cpu)) { return false; } return true; diff --git a/target/i386/whpx/whpx-accel-ops.c b/target/i386/whpx/whpx-acce= l-ops.c index 6bc47c53098..1f9c6d52c27 100644 --- a/target/i386/whpx/whpx-accel-ops.c +++ b/target/i386/whpx/whpx-accel-ops.c @@ -83,6 +83,11 @@ static void whpx_kick_vcpu_thread(CPUState *cpu) } } =20 +static bool whpx_cpu_has_work(CPUState *cpu) +{ + return whpx_apic_in_platform(); +} + static void whpx_accel_ops_class_init(ObjectClass *oc, void *data) { AccelOpsClass *ops =3D ACCEL_OPS_CLASS(oc); @@ -94,6 +99,7 @@ static void whpx_accel_ops_class_init(ObjectClass *oc, vo= id *data) ops->synchronize_post_init =3D whpx_cpu_synchronize_post_init; ops->synchronize_state =3D whpx_cpu_synchronize_state; ops->synchronize_pre_loadvm =3D whpx_cpu_synchronize_pre_loadvm; + ops->has_work =3D whpx_cpu_has_work; } =20 static const TypeInfo whpx_accel_ops_type =3D { --=20 2.31.1