From nobody Tue Feb 10 04:17:22 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) client-ip=209.85.221.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1632476521; cv=none; d=zohomail.com; s=zohoarc; b=kJjlOFLtIZ/0A4Ix8l4SbDcNXJiFw8ae3X5+sjKjXurkummUWVWLa2fl43debGbJbCdNtwusqERKE3JbvGwyV8XRlHE7Wh7WApIvliVNrk+VItsvTCmsEQLeru15DTMxiIg26zzykGL6W/IG5VFcCEZ0UGeSEDDymxYDIzuZqXM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1632476521; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lsD8NWGZdgfbGQhaRvFJOuKgMHvFJkt23n3sZARQWU8=; b=nOYpDxmq4m2V4g7DLoiq8TZTapNHPz1MjSdqxkvsD95EMC1HYEo9EbmOw+E5jDBqdKkVVpPGATvYfcSVb0eIZjvhxZTGwVtUfypbUwxulaCasX+vtau1ZD8ZgJ5417iiMQYfseHop9lznOlc6xvTZ6DC26q1jGLzcXBSSflHrfQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by mx.zohomail.com with SMTPS id 1632476521146261.82238485927655; Fri, 24 Sep 2021 02:42:01 -0700 (PDT) Received: by mail-wr1-f52.google.com with SMTP id t7so25390700wrw.13 for ; Fri, 24 Sep 2021 02:42:00 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id y7sm5082791wrs.95.2021.09.24.02.41.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Sep 2021 02:41:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lsD8NWGZdgfbGQhaRvFJOuKgMHvFJkt23n3sZARQWU8=; b=UwDdJkXdPu+UwIOLG7cF1DpN08NOVjUXh5QxZO3b8BlxRdAye0OJz2hLqKgxw0ZKDG PzPuRnVN0Hcwvs9ZnlPJBOVuyUiE5Wibc1gFbRerxlFnnfoCR6m5gcEaRGIRw6flshnx eKifOQnMKcSSPap9xcmf4wa0TYhT3HsYptzq8553VGvUn4ZHNZlKA4MnxYoP9K5hQV7R lLE/TCBgRrYvCvnP6+FbiCLac7cjuVYnGRwe7QyKDzOhYCfBflTL06U6GT3YPkIwozTj Kp3qDVZS0fvkxnYKCFUI2Ya3nOV56tP3mPcK8INiJEdk+MEH85+SQXa14dlfdHNGLro3 Fycg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=lsD8NWGZdgfbGQhaRvFJOuKgMHvFJkt23n3sZARQWU8=; b=Q64iuuFzTHdbfQGlfIpTNIl5zLg56oxIwhrF7IQtT49ah3ku/yV+dyOxqqXjFkfm/d w6hs9Zwa3Uql9kUYoVUhISGMvk56GdrVeBMG/Gq973vP+FZjBDK0bpqhcnLb+BPcDeXs pCB93OpwliMR1ETmJhr9nUxODFxBh47BtucrHhRDKsBRqbtu2g8CNrZoK+DGlTPTbZLC YlIIgeFIfjl/QlmDOeoxqLcf+kaJM3XPrbbUVahbzvrm9zMHz3kstiQSjY2/hwzj4l+3 54lnO6frBgaEF2972PLudPhZXq9CqbO6awIPBgJdn40VEE9vdMTCcu+hTMUiKjAK2268 tT4A== X-Gm-Message-State: AOAM530QszyOVgmnHXCwQizdWIt5CASkfyo9wRXvfskwJ5K89YECQHbM GPaIO8RiPtf+ZSTgJ2xyNJA= X-Google-Smtp-Source: ABdhPJwRCbd+wpqeirpoZIHuJdD3JA83d7V/aSnH6KC/kwAqhcT7iG/DayNhWUkLO3DFjrX2xrvT/A== X-Received: by 2002:adf:ecd2:: with SMTP id s18mr10164901wro.99.1632476519278; Fri, 24 Sep 2021 02:41:59 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini Subject: [PATCH v6 40/40] accel/tcg: Simplify tcg_cpu_has_work() Date: Fri, 24 Sep 2021 11:38:47 +0200 Message-Id: <20210924093847.1014331-41-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210924093847.1014331-1-f4bug@amsat.org> References: <20210924093847.1014331-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1632476522821100001 All TCG targets implement the TCGCPUOps::has_work() handler. We can remove the non-NULL handler check in tcg_cpu_has_work(). Add an assertion in tcg_exec_realizefn() for future TCG targets. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- accel/tcg/cpu-exec.c | 4 ++++ accel/tcg/tcg-accel-ops.c | 5 +---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 5fd1ed34222..18c20e5759b 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -993,6 +993,10 @@ void tcg_exec_realizefn(CPUState *cpu, Error **errp) CPUClass *cc =3D CPU_GET_CLASS(cpu); =20 if (!tcg_target_initialized) { + /* Mandatory non-NULL handlers */ + g_assert(cc->tcg_ops->initialize); + g_assert(cc->tcg_ops->has_work); + cc->tcg_ops->initialize(); tcg_target_initialized =3D true; } diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c index 3c75ed2cccc..6cd32f04cb9 100644 --- a/accel/tcg/tcg-accel-ops.c +++ b/accel/tcg/tcg-accel-ops.c @@ -78,10 +78,7 @@ static bool tcg_cpu_has_work(CPUState *cpu) { CPUClass *cc =3D CPU_GET_CLASS(cpu); =20 - if (cc->tcg_ops->has_work) { - return cc->tcg_ops->has_work(cpu); - } - return false; + return cc->tcg_ops->has_work(cpu); } =20 /* mask must never be zero, except for A20 change call */ --=20 2.31.1