From nobody Mon Feb 9 20:31:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) client-ip=209.85.221.45; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f45.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1632476516; cv=none; d=zohomail.com; s=zohoarc; b=EWgsC8DcfcABHfyrAHWRiyNtVHadfz43aAj4cTh1peop48NisqOzt33Y0ls94JHY7oAJsAl3pTK/zDTxbp9BjkUTFdjIbiN5UrgTGTH2tIs8FN2Tb9MayRgRf3iRvZk2m0XDAZjSxn1cobW22tod9791xvUiPLO0QgK1c8zf93E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1632476516; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=p+FhEVuxYvtBhbZfLgBuFMc/Z1Zw1Ec9d9CUDDVANlA=; b=dA6VrNH6b+sIdkRkxuZtyKxn1xfbiOqi5Od0ehzWmamcw8IU+K0lcMNMh57WUYprxQuIZAesF5zpx/1cjac38Vdaz/k4mxV75eGAoWDnmU3augle0lr72/4Zcdk+9gm4VHwhyos5WPEuG3t9UmVtc1zRPw/Co0FMUqm/akd/H0g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by mx.zohomail.com with SMTPS id 1632476516525349.2745997263238; Fri, 24 Sep 2021 02:41:56 -0700 (PDT) Received: by mail-wr1-f45.google.com with SMTP id d6so25391591wrc.11 for ; Fri, 24 Sep 2021 02:41:55 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id i67sm9220524wmi.41.2021.09.24.02.41.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Sep 2021 02:41:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=p+FhEVuxYvtBhbZfLgBuFMc/Z1Zw1Ec9d9CUDDVANlA=; b=nrI+Wi5nhIdxAJ3i1HND91Xx//nMUpPaDkD4GsfEPgEfTnS4R+MN/5em3jlcTu4ohY iqJqzOrQxR9VcbhxYjd06ihV9qy0EoGep35c0ayMsWLTAjyDS2K8prE1ZZvME9lFhdU4 /wI1iQ0zKnVU0Vv9Wy0y0WmHNjCeKNpdYlxaDad/vp6kyJKOmkccNlRWPB/toN50NvMm r8sxxJrh5Qdq61qpGTJZkk/V8/bNtdtHd0v8jJdivkrioOu1A6y2wfnttH8onFJ2dK7k Xc2kROnMVzDSHa/KQ+B36fFMDDE/7GlPu4SAiSHtGb8dRI9eliy6T1PCKkBO/sNNme39 t3Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=p+FhEVuxYvtBhbZfLgBuFMc/Z1Zw1Ec9d9CUDDVANlA=; b=xFLUsG71NCpT+aSzNKo+c59Vc7Fj6tZZg7YnMK/dOB0T+c/ZlsO9q0/Hu5DYmvJkih m3YHd1QlxZByua9fbQcy3zG55dJkdOQ8VMb+YcI/L1enI8YolJjq2zzzOwchIil2bymI KagP4bA7ux87u91J1r76DUxEJQMZO7Nm08s6Myz5KtEGIXc3Lflyj6KQYWcXgFS103M7 LaKjBTTulGfR9WqWclht7cbCKEa6C0XWF5i0IgmsBtIJ+Kfd0OPU9EwL3VJ1KR2G93dS 0/6Phkl8ncqR73G7mFzkO8+CgjpsFSDXXpEKYW3Xa5naxs5VVe2pQeUx/PamYhwGh0dr 8ftQ== X-Gm-Message-State: AOAM533mH/3OFfnREsehL9bkus95vw14Oq6C68STp05/IshWALH+eRGJ i4Wf/REcDjgVh08LuzEPMcw= X-Google-Smtp-Source: ABdhPJz9tKPYztfReNR/f4qcvNF3lXMz5l1eh+YRosHTqsiiXY9RK89YXOnvDDVKxyzsvjrI3kAVXw== X-Received: by 2002:a1c:23cb:: with SMTP id j194mr1049741wmj.1.1632476514649; Fri, 24 Sep 2021 02:41:54 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , Eduardo Habkost , Marcel Apfelbaum Subject: [PATCH v6 39/40] accel/tcg: Remove CPUClass::has_work() Date: Fri, 24 Sep 2021 11:38:46 +0200 Message-Id: <20210924093847.1014331-40-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210924093847.1014331-1-f4bug@amsat.org> References: <20210924093847.1014331-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1632476518549100003 Now that all TCG targets converted their CPUClass::has_work() handler to a TCGCPUOps::has_work() one, we can remove has_work from CPUClass. Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/core/cpu.h | 2 -- accel/tcg/tcg-accel-ops.c | 3 --- 2 files changed, 5 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 114eb3b9b2c..c64709b898c 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -89,7 +89,6 @@ struct SysemuCPUOps; * instantiatable CPU type. * @parse_features: Callback to parse command line arguments. * @reset_dump_flags: #CPUDumpFlags to use for reset logging. - * @has_work: Callback for checking if there is work to do. Only used by T= CG. * @memory_rw_debug: Callback for GDB memory access. * @dump_state: Callback for dumping state. * @get_arch_id: Callback for getting architecture-dependent CPU ID. @@ -132,7 +131,6 @@ struct CPUClass { void (*parse_features)(const char *typename, char *str, Error **errp); =20 int reset_dump_flags; - bool (*has_work)(CPUState *cpu); int (*memory_rw_debug)(CPUState *cpu, vaddr addr, uint8_t *buf, int len, bool is_write); void (*dump_state)(CPUState *cpu, FILE *, int flags); diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c index cd44bb6d0d8..3c75ed2cccc 100644 --- a/accel/tcg/tcg-accel-ops.c +++ b/accel/tcg/tcg-accel-ops.c @@ -78,9 +78,6 @@ static bool tcg_cpu_has_work(CPUState *cpu) { CPUClass *cc =3D CPU_GET_CLASS(cpu); =20 - if (cc->has_work) { - return cc->has_work(cpu); - } if (cc->tcg_ops->has_work) { return cc->tcg_ops->has_work(cpu); } --=20 2.31.1