From nobody Tue Feb 10 06:26:32 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.53 as permitted sender) client-ip=209.85.221.53; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f53.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1632174323; cv=none; d=zohomail.com; s=zohoarc; b=j28PYiHwGo+RzPRjpgIo4PQ0y7sVTP/uw7Idfp5T9QgzB5m8s71m+TIrz5mV2blYg3b+pt12JJ+MAoZDBeFYw5znUh7uYfOakBaR7cEowFZ+9PwFNe4cH/mLaEymLtRMQwZlTSN4aVHTR339UvRO1ELWoXaMSbDd5cGSvpbYa7M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1632174323; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=xA2Qs5A8kdrstJ0M2RueeVwtCE7JAIn7H4+fKLqTQLg=; b=RO91Z4HdCz+eGb6zIWQhA1a9Yw6sz+B0Qj2uPRrxYNknUBqbvFNX5k4SLUbJjd5LEbjMQQ5mfDQKdYAnKYRxMPInXs38UdMpvpGTnN3Ig/Qf5wLI+1Wc+fnuW9EdJW5PZzHdmxX87qavO1Kbo0W4FGWA6u8MUMKgrDhQxulCd/w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by mx.zohomail.com with SMTPS id 1632174323046366.98574462124236; Mon, 20 Sep 2021 14:45:23 -0700 (PDT) Received: by mail-wr1-f53.google.com with SMTP id t8so33588396wrq.4 for ; Mon, 20 Sep 2021 14:45:22 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id n26sm688230wmi.43.2021.09.20.14.45.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Sep 2021 14:45:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xA2Qs5A8kdrstJ0M2RueeVwtCE7JAIn7H4+fKLqTQLg=; b=HyiXFPUofu0hyaR03SRT7hHtaIsHV81Brl+6tFlqSo9BLYvyXCghkOES+TPlpFKtHS r8YhYE762T/3FHInykUzC5F2BS5JiYvjWHw8W2eOBf34gzAyTSeJB13EkIeDPbnGKHaQ lwSfEN+jOIFaXp0VWGcMjgUrw3N0R4NhHg7NPzfljsJ2S4sx0DExm8hjRkk0dqsBP+0e Z8zVzKOaSyUi4So9CbhuXbqFa+1a1M4yThOka8M93e/RgRJVZQ+27UbPmLmWXkL1bRCx QjEzyGvwNswbs20QBPB24JiZKsC7Bd0jVCyhjKY/O+KWcK9ymvBe9rrm1m6yMkrn4DOV oEgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=xA2Qs5A8kdrstJ0M2RueeVwtCE7JAIn7H4+fKLqTQLg=; b=4SbXU4oZh6Z3Y3l2tRgfDlZBnd+kWENvAY61Kp/eM6oL+chJukCokq4iMpHcNhxvZ6 PSScwDt1aJx+3u23DNKlxB44bLUaQZZqZODJLZE8230qHooAgLSduH6mddN1FnwEmzrh 9dA/0wb+VMLSN1x715IV6NtT/n4E7UYDtmmNmFq2l4ER0cNTcYKNw/uVXRdDJOMjaHJb cDO9zBeiYTHE1U72dZaXUHSIqKc8BtMHLiHv6DAi0BtRVFfuS06FP6m331yS68E3z9Ei t15wGDQGpatuyZaaDyOKAooINLUadI7nv7pirycDvz78L6XZMoPjSuka/vHGcY1bjTTs LTLA== X-Gm-Message-State: AOAM532knOauSKOv7kvXdSI56Lxj1rDRUYdaI+v0xgHhg9ieDBzLFP94 NxEzYsekRTki8sqOodbdteY= X-Google-Smtp-Source: ABdhPJzHooTMuOlKidkNAcJ0q7UpY6tbSCsVvn669AIkNs/X3LYaEn78O1Dhsp3cXryhPG+QPXWMLg== X-Received: by 2002:a5d:64e6:: with SMTP id g6mr15434822wri.151.1632174321282; Mon, 20 Sep 2021 14:45:21 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v5 07/31] accel/whpx: Implement AccelOpsClass::has_work() Date: Mon, 20 Sep 2021 23:44:23 +0200 Message-Id: <20210920214447.2998623-8-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210920214447.2998623-1-f4bug@amsat.org> References: <20210920214447.2998623-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1632174325057100001 Implement WHPX has_work() handler in AccelOpsClass and remove it from cpu_thread_is_idle() since cpu_has_work() is already called. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- softmmu/cpus.c | 4 +--- target/i386/whpx/whpx-accel-ops.c | 6 ++++++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/softmmu/cpus.c b/softmmu/cpus.c index b22804c4193..98b4049aba7 100644 --- a/softmmu/cpus.c +++ b/softmmu/cpus.c @@ -41,7 +41,6 @@ #include "sysemu/replay.h" #include "sysemu/runstate.h" #include "sysemu/cpu-timers.h" -#include "sysemu/whpx.h" #include "hw/boards.h" #include "hw/hw.h" #include "trace.h" @@ -89,8 +88,7 @@ bool cpu_thread_is_idle(CPUState *cpu) if (cpu_is_stopped(cpu)) { return true; } - if (!cpu->halted || cpu_has_work(cpu) || - whpx_apic_in_platform()) { + if (!cpu->halted || cpu_has_work(cpu)) { return false; } return true; diff --git a/target/i386/whpx/whpx-accel-ops.c b/target/i386/whpx/whpx-acce= l-ops.c index 6bc47c53098..1f9c6d52c27 100644 --- a/target/i386/whpx/whpx-accel-ops.c +++ b/target/i386/whpx/whpx-accel-ops.c @@ -83,6 +83,11 @@ static void whpx_kick_vcpu_thread(CPUState *cpu) } } =20 +static bool whpx_cpu_has_work(CPUState *cpu) +{ + return whpx_apic_in_platform(); +} + static void whpx_accel_ops_class_init(ObjectClass *oc, void *data) { AccelOpsClass *ops =3D ACCEL_OPS_CLASS(oc); @@ -94,6 +99,7 @@ static void whpx_accel_ops_class_init(ObjectClass *oc, vo= id *data) ops->synchronize_post_init =3D whpx_cpu_synchronize_post_init; ops->synchronize_state =3D whpx_cpu_synchronize_state; ops->synchronize_pre_loadvm =3D whpx_cpu_synchronize_pre_loadvm; + ops->has_work =3D whpx_cpu_has_work; } =20 static const TypeInfo whpx_accel_ops_type =3D { --=20 2.31.1