From nobody Mon Apr 29 17:04:14 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1632152317642688.4683092277795; Mon, 20 Sep 2021 08:38:37 -0700 (PDT) Received: from localhost ([::1]:43268 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSLNM-0006dP-Kj for importer@patchew.org; Mon, 20 Sep 2021 11:38:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49966) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSL4A-0000Xy-2I for qemu-devel@nongnu.org; Mon, 20 Sep 2021 11:18:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:47945) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSL44-0007dx-Vg for qemu-devel@nongnu.org; Mon, 20 Sep 2021 11:18:44 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-396-DzZFQWvaNmKzZ8mDkO8Pig-1; Mon, 20 Sep 2021 11:18:37 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6B8948042CE; Mon, 20 Sep 2021 15:18:36 +0000 (UTC) Received: from wrampazz.redhat.com (unknown [10.22.16.131]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9D1D051F19; Mon, 20 Sep 2021 15:18:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632151118; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ljJb8N6/03Un1DOfCAvJse+EgpLMnVNSUtDwK/2Z2y8=; b=Fl+cG5svuUMTPQJ9UklzkLXm/sbkk4w60HfV/v2G6osaODwM0KUkZ0ITxp9ruVnufQTUxV KSlt8cE/8scVoNfndrOvt4Kjpw1dDw2/kgI0k68YhDYIcBK+jZdA0FnzAZoieoiMvPwYm6 dxX3Shl+sKN+Gjpk3KJBj3MLcVO3pXM= X-MC-Unique: DzZFQWvaNmKzZ8mDkO8Pig-1 From: Willian Rampazzo To: qemu-devel@nongnu.org Subject: [PATCH v2] Acceptance Tests: add standard clean up at test tearDown() Date: Mon, 20 Sep 2021 12:18:32 -0300 Message-Id: <20210920151832.60803-1-willianr@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=willianr@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=willianr@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.475, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Wainer dos Santos Moschetta , Cleber Rosa Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1632152319316100003 Content-Type: text/plain; charset="utf-8" From: Cleber Rosa The avocado.Test class, used as the basis of the avocado_qemu.Test class, performs a clean of temporary directories up as part of its own tearDown() implementation. But the avocado_qemu.Test class is currently missing the same clean up, as it implemented its own tearDown() method without resorting to the upper class behavior. This brings avocado_qemu.Test behavior in sync with the standard avocado.Test behavior and prevents temporary directories from cluttering the test results directory (unless instructed to do so with Avocado's "--keep-tmp" option). Reported-by: Peter Maydell Signed-off-by: Cleber Rosa [willianr: respin to new Python super format] Signed-off-by: Willian Rampazzo Reviewed-by: Wainer dos Santos Moschetta --- v2 - adjust super call to conform with PEP3135 --- tests/acceptance/avocado_qemu/__init__.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/a= vocado_qemu/__init__.py index 2c4fef3e14..d9e1b32aa1 100644 --- a/tests/acceptance/avocado_qemu/__init__.py +++ b/tests/acceptance/avocado_qemu/__init__.py @@ -276,6 +276,7 @@ def tearDown(self): for vm in self._vms.values(): vm.shutdown() self._sd =3D None + super().tearDown() =20 def fetch_asset(self, name, asset_hash=3DNone, algorithm=3DNone, --=20 2.31.1