From nobody Tue Feb 10 02:27:50 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.47 as permitted sender) client-ip=209.85.221.47; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f47.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.47 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1632120061; cv=none; d=zohomail.com; s=zohoarc; b=e3TLSjP7iadz7fA16Ld90R5KVs1619qJ/4UfGsJY/hd02K0MxrJLfoZjwzBH3WWtYmiJEJFZDVPvONHRsiBtDQWig5hMSaaIrLDYC4XRmRwwxgqq4gXsDVS3yt1BOFyJHQvPogZ7RbVOyu+Y0eY+H/rbrskNQLrobWrse/PEZHM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1632120061; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=EcOr1QmO1S16fr4fOEvRxqFLTXjTaCedzwKUta20dVg=; b=I3AaL3oGDe//rTmEgjK7kGfvgNN78OoeZC2fH+IBxXgtsdPYL/ls4L7K+sq3a+sEmU6uvnf4kn7OKPCMpwnTS1WVTu+M818IOh4N1KpBY+oIwvuZMJLiSMFQga9mgEr6SJhEaeG2j5RicyyC8H7jLlLW145rkq0UiBiqxE8SM4c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.47 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by mx.zohomail.com with SMTPS id 1632120061573208.97605167044162; Sun, 19 Sep 2021 23:41:01 -0700 (PDT) Received: by mail-wr1-f47.google.com with SMTP id t18so26952535wrb.0 for ; Sun, 19 Sep 2021 23:41:01 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (14.red-83-35-25.dynamicip.rima-tde.net. [83.35.25.14]) by smtp.gmail.com with ESMTPSA id g205sm11057803wmg.18.2021.09.19.23.40.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Sep 2021 23:40:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EcOr1QmO1S16fr4fOEvRxqFLTXjTaCedzwKUta20dVg=; b=M645RUxHr+fjF2Oxsz/54Ni4G92bdFpLctuYWDoWcga4O5B76pSfRxpvYbCDSLhMlJ tTjJKAbAmWsCTUy58U+ONZwZoAt1/N82LgH7HDaz27mzxS3vWER63NLHakbdfPwjs3vn fWc0S5pHC7EjoUBiR/zgUw9D/VWpEl3/419xfMnNBFylWseSx/nlRM7j1Feq+9XzLsGJ F6R26pBOlrqpHHG8EBrK9XKoU/vhE2jiF2nD7xacBHMNGxRMe0J/nEW7JsD72c7QkCer FBHDMrTmzSqHRMXFocdvQPdxOo7MHVPs4/3vs8AxaVa8r1g/eE95FwPKbHvYg7rNGY1Q nyvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=EcOr1QmO1S16fr4fOEvRxqFLTXjTaCedzwKUta20dVg=; b=dTFIQNUMvtOiCSKCIUQzLasoCrKw8ClHeaotZVgigcfDhHl6yEWoWxSsQMiNesHQgw rCvsP6gjEdFxaG7RBZU+9GxtaW0YlPpiKgnkPFFeMeDCf9AZaiM7L91ZvhNNEn6pnGa5 9pR02olYlLFEKp6tWD5mxqnWQ7awjV1ns0uMP+KOlsy/I6vPtMicApKry3OyBFbBJjPH bakG+d7bHKtC0gtJatGtQnFDIzgM/oBWoPohJ4CVJ2Dk6RAGrK1czCoYXxFVNlB9rsM+ N2uLtpevzQQmiRybyhxUwLk+19QO59ivJLYlazsK4e9idrawJvgp8Cvjd8lB5wRU1Jpl JfYQ== X-Gm-Message-State: AOAM532e3cgCc+/PTJlt3uSi5QChivSp0AJ7Zv3ThJ1FOCQ++cu0mjF+ n57+Zt70GFV0CqhVtdVhOWLE1gX8FhY= X-Google-Smtp-Source: ABdhPJyD5RuJN634Qj2x9308noTh5esQTBBXGuRJCttvftLoiBuTZJJx1XXeaofD8AGOY4KgTugYQw== X-Received: by 2002:adf:d1c5:: with SMTP id b5mr9563327wrd.252.1632120059828; Sun, 19 Sep 2021 23:40:59 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Helge Deller , Sven Schnelle , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 2/3] hw/input/lasips2: Move LASIPS2State declaration to 'hw/input/lasips2.h' Date: Mon, 20 Sep 2021 08:40:47 +0200 Message-Id: <20210920064048.2729397-3-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210920064048.2729397-1-f4bug@amsat.org> References: <20210920064048.2729397-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1632120063116100001 We want to use the OBJECT_DECLARE_SIMPLE_TYPE() macro to QOM'ify this device in the next commit. To make its review simpler, as a first step move the LASIPS2State and LASIPS2Port declarations to 'hw/input/lasips2.h' Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Damien Hedde --- include/hw/input/lasips2.h | 18 ++++++++++++++++++ hw/input/lasips2.c | 18 ------------------ 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/include/hw/input/lasips2.h b/include/hw/input/lasips2.h index 0cd7b59064a..c88f1700162 100644 --- a/include/hw/input/lasips2.h +++ b/include/hw/input/lasips2.h @@ -11,6 +11,24 @@ =20 #define TYPE_LASIPS2 "lasips2" =20 +struct LASIPS2State; +typedef struct LASIPS2Port { + struct LASIPS2State *parent; + MemoryRegion reg; + void *dev; + uint8_t id; + uint8_t control; + uint8_t buf; + bool loopback_rbne; + bool irq; +} LASIPS2Port; + +typedef struct LASIPS2State { + LASIPS2Port kbd; + LASIPS2Port mouse; + qemu_irq irq; +} LASIPS2State; + void lasips2_init(MemoryRegion *address_space, hwaddr base, qemu_irq irq); =20 #endif /* HW_INPUT_LASIPS2_H */ diff --git a/hw/input/lasips2.c b/hw/input/lasips2.c index 68d741d3421..0f8362f17bc 100644 --- a/hw/input/lasips2.c +++ b/hw/input/lasips2.c @@ -33,24 +33,6 @@ #include "hw/irq.h" =20 =20 -struct LASIPS2State; -typedef struct LASIPS2Port { - struct LASIPS2State *parent; - MemoryRegion reg; - void *dev; - uint8_t id; - uint8_t control; - uint8_t buf; - bool loopback_rbne; - bool irq; -} LASIPS2Port; - -typedef struct LASIPS2State { - LASIPS2Port kbd; - LASIPS2Port mouse; - qemu_irq irq; -} LASIPS2State; - static const VMStateDescription vmstate_lasips2 =3D { .name =3D "lasips2", .version_id =3D 0, --=20 2.31.1