From nobody Wed May 1 00:02:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1631871199895117.60332852556644; Fri, 17 Sep 2021 02:33:19 -0700 (PDT) Received: from localhost ([::1]:56756 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRAFB-0005dn-LD for importer@patchew.org; Fri, 17 Sep 2021 05:33:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58020) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRADz-0004mn-3r for qemu-devel@nongnu.org; Fri, 17 Sep 2021 05:32:03 -0400 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]:40818) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mRADx-00067V-0y for qemu-devel@nongnu.org; Fri, 17 Sep 2021 05:32:02 -0400 Received: by mail-pl1-x630.google.com with SMTP id n18so5800733plp.7 for ; Fri, 17 Sep 2021 02:32:00 -0700 (PDT) Received: from localhost.localdomain (123-193-74-252.dynamic.kbronet.com.tw. [123.193.74.252]) by smtp.gmail.com with ESMTPSA id g19sm9863237pjl.25.2021.09.17.02.31.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Sep 2021 02:31:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=OtJ4RHt5xyh+KdfTASi/a6oXp5Pv3txrWHLBviMfN70=; b=C4a69nI86d72ac/BEUPGSvszAOzO7X1tkR/fW/Qt9uk5gKN5zKmEcnvvjXxlhNwm8A 9DYIJeNdAe//QPx+USufWU7rlGW9UuGydkvoVe02krHbmOhAeWeLtkkQgU1gOAl460/r 1ERXKUqNyD/gGpEpf7G25pKhEJEAX0AjyleKY1PFgFnY5wN5Qw/jR9W6GL2sY74Wfm77 6+fmgZxSIt6zBRu4co+V1HGDZ26w68aciSdjgv9Vo0OdSuNg0+6QoSuaElyHeRHm+hFr zs6uwN5HSwbdU8HqP4Ap7CX3619eESf1m1/yIHjBULrPuYZPfKd3kcp0GbYOBlddoBvc f0Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=OtJ4RHt5xyh+KdfTASi/a6oXp5Pv3txrWHLBviMfN70=; b=SVu/LGzwYgjiwYnRNkasqF0qCcESgxwxqXsY0PZ0CEjVmGJY4HSzrR07aKIXxM2lH4 VKWsRLkKc90DE7SjBpnJOK0A2En5joOuwa5rS0AA3kY4Z3lMOO9GYylJTkJJi88jZCZl mEh53VlrdZ906KYkzVDtTOdC1oJBPgg5pY3D7ou5rLt0yAr5TIX7Nz3M2UyUeh/iYFiV 2zHclB9zDYbZbVP+xvUzUsyIbGIpmoFf+m0blSIfL+PPa2R7Z+gvKDukjn6yypZKF84+ +HBLZw1NLGxu/QaIrryRYdMAfw+uZkDwFt0cReNbc1Y2Yhg4RrK7mxl0QU+C8sGlDM0w okCQ== X-Gm-Message-State: AOAM532s/fPPI8HpSIf7JCIQ3XFvdhhFDRoM3yeqFJ363rZanRKdUEJW Ur40EmXa2zzcVSRBkg0miU9aKrOoqLAt4g== X-Google-Smtp-Source: ABdhPJw8ghvqDVh3kzhqjXnBIf0SfyvqFc5eneaSNRLrF+hzMqThd9miohRIz9oVoe5LSRAafX9r4Q== X-Received: by 2002:a17:90b:8cb:: with SMTP id ds11mr11290413pjb.66.1631871119275; Fri, 17 Sep 2021 02:31:59 -0700 (PDT) From: frank.chang@sifive.com To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org Subject: [PATCH RESEND v2] target/riscv: Set mstatus_hs.[SD|FS] bits if Clean and V=1 in mark_fs_dirty() Date: Fri, 17 Sep 2021 17:31:52 +0800 Message-Id: <20210917093153.4067812-1-frank.chang@sifive.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::630; envelope-from=frank.chang@sifive.com; helo=mail-pl1-x630.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Frank Chang , Vincent Chen , Alistair Francis , Bin Meng , Palmer Dabbelt Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1631871201565100001 Content-Type: text/plain; charset="utf-8" From: Frank Chang When V=3D1, both vsstauts.FS and HS-level sstatus.FS are in effect. Modifying the floating-point state when V=3D1 causes both fields to be set to 3 (Dirty). However, it's possible that HS-level sstatus.FS is Clean and VS-level vsstatus.FS is Dirty at the time mark_fs_dirty() is called when V=3D1. We can't early return for this case because we still need to set sstatus.FS to Dirty according to spec. Signed-off-by: Frank Chang Reviewed-by: Vincent Chen Tested-by: Vincent Chen Reviewed-by: Richard Henderson --- target/riscv/cpu.h | 4 ++++ target/riscv/translate.c | 24 +++++++++++++++--------- 2 files changed, 19 insertions(+), 9 deletions(-) diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h index e735e53e26c..bef7c551646 100644 --- a/target/riscv/cpu.h +++ b/target/riscv/cpu.h @@ -394,6 +394,7 @@ FIELD(TB_FLAGS, SEW, 5, 3) FIELD(TB_FLAGS, VILL, 8, 1) /* Is a Hypervisor instruction load/store allowed? */ FIELD(TB_FLAGS, HLSX, 9, 1) +FIELD(TB_FLAGS, MSTATUS_HS_FS, 10, 2) =20 bool riscv_cpu_is_32bit(CPURISCVState *env); =20 @@ -450,6 +451,9 @@ static inline void cpu_get_tb_cpu_state(CPURISCVState *= env, target_ulong *pc, get_field(env->hstatus, HSTATUS_HU))) { flags =3D FIELD_DP32(flags, TB_FLAGS, HLSX, 1); } + + flags =3D FIELD_DP32(flags, TB_FLAGS, MSTATUS_HS_FS, + get_field(env->mstatus_hs, MSTATUS_FS)); } #endif =20 diff --git a/target/riscv/translate.c b/target/riscv/translate.c index 74b33fa3c90..2b48db6fd02 100644 --- a/target/riscv/translate.c +++ b/target/riscv/translate.c @@ -58,6 +58,7 @@ typedef struct DisasContext { target_ulong misa; uint32_t opcode; uint32_t mstatus_fs; + uint32_t mstatus_hs_fs; uint32_t mem_idx; /* Remember the rounding mode encoded in the previous fp instruction, which we have already installed into env->fp_status. Or -1 for @@ -280,26 +281,30 @@ static void gen_jal(DisasContext *ctx, int rd, target= _ulong imm) static void mark_fs_dirty(DisasContext *ctx) { TCGv tmp; - target_ulong sd; + target_ulong sd =3D is_32bit(ctx) ? MSTATUS32_SD : MSTATUS64_SD; + + if (ctx->virt_enabled && ctx->mstatus_hs_fs !=3D MSTATUS_FS) { + /* Remember the stage change for the rest of the TB. */ + ctx->mstatus_hs_fs =3D MSTATUS_FS; + + tmp =3D tcg_temp_new(); + tcg_gen_ld_tl(tmp, cpu_env, offsetof(CPURISCVState, mstatus_hs)); + tcg_gen_ori_tl(tmp, tmp, MSTATUS_FS | sd); + tcg_gen_st_tl(tmp, cpu_env, offsetof(CPURISCVState, mstatus_hs)); + tcg_temp_free(tmp); + } =20 if (ctx->mstatus_fs =3D=3D MSTATUS_FS) { return; } + /* Remember the state change for the rest of the TB. */ ctx->mstatus_fs =3D MSTATUS_FS; =20 tmp =3D tcg_temp_new(); - sd =3D is_32bit(ctx) ? MSTATUS32_SD : MSTATUS64_SD; - tcg_gen_ld_tl(tmp, cpu_env, offsetof(CPURISCVState, mstatus)); tcg_gen_ori_tl(tmp, tmp, MSTATUS_FS | sd); tcg_gen_st_tl(tmp, cpu_env, offsetof(CPURISCVState, mstatus)); - - if (ctx->virt_enabled) { - tcg_gen_ld_tl(tmp, cpu_env, offsetof(CPURISCVState, mstatus_hs)); - tcg_gen_ori_tl(tmp, tmp, MSTATUS_FS | sd); - tcg_gen_st_tl(tmp, cpu_env, offsetof(CPURISCVState, mstatus_hs)); - } tcg_temp_free(tmp); } #else @@ -533,6 +538,7 @@ static void riscv_tr_init_disas_context(DisasContextBas= e *dcbase, CPUState *cs) ctx->frm =3D -1; /* unknown rounding mode */ ctx->ext_ifencei =3D cpu->cfg.ext_ifencei; ctx->vlen =3D cpu->cfg.vlen; + ctx->mstatus_hs_fs =3D FIELD_EX32(tb_flags, TB_FLAGS, MSTATUS_HS_FS); ctx->hlsx =3D FIELD_EX32(tb_flags, TB_FLAGS, HLSX); ctx->vill =3D FIELD_EX32(tb_flags, TB_FLAGS, VILL); ctx->sew =3D FIELD_EX32(tb_flags, TB_FLAGS, SEW); --=20 2.25.1