From nobody Mon May 6 11:20:19 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1631625804; cv=none; d=zohomail.com; s=zohoarc; b=kjhYD3lthvXxn/bRgmu4G7WGqChMLkTtW8ijHNLoatDguBmB6TJqLZ22z1NGnoKn84EXtu9VPklWNAjC9/q+LIuD5fFcetuqlxVr5ya3pO5ZTVJgppuOHV4NPqG/r2qZzYFT1tHcnVYEx98/tOcXDYQc+jJ/mAWVRR8hR+IApSE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1631625804; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=K1qk8u5NQ6kttP48zH2LMhrRKstULXIxJnGZIO2W7oQ=; b=FSnbzZ3X/3cZJlE1qzXAc6QoQmVZYwbKoj17MIC4i+rzvWqj1ClRmyxppQ40BykignQoqeuqaY9pBc+m40G34vd8rV2eTPf4fH31QA50mQDULgF94XUnvVetrpw2VB3w+uG+/gTkS8OXN3aocdlo+1RPhfkO3O52BBVNEO5I7hQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1631625804606986.7561251161072; Tue, 14 Sep 2021 06:23:24 -0700 (PDT) Received: from localhost ([::1]:52416 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQ8PD-0005PL-KQ for importer@patchew.org; Tue, 14 Sep 2021 09:23:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37828) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQ84Q-0006M4-Qm for qemu-devel@nongnu.org; Tue, 14 Sep 2021 09:01:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:21695) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQ84L-0008NE-5D for qemu-devel@nongnu.org; Tue, 14 Sep 2021 09:01:50 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-191-brOMD1NGPo6EygjuQCtGKg-1; Tue, 14 Sep 2021 09:01:42 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1B2CB5075B; Tue, 14 Sep 2021 13:01:41 +0000 (UTC) Received: from localhost (unknown [10.39.208.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id B276E7A5CE; Tue, 14 Sep 2021 13:01:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631624505; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K1qk8u5NQ6kttP48zH2LMhrRKstULXIxJnGZIO2W7oQ=; b=A/WgUYg5iJwsw3+TjDoaXA7APlKMCZtEtZid6J1ejSDDVeeX6sxCOq100MYu35xhaT9tTv t+cBVfWe7q/fj0d4lwp9MyxVo+7SE3PbEFbKeDLbYHLHWePepD3gFsUcVQx/qzCnvSXt3R heZ1qBaWX9n2ET3OhkZelzsvJVSJYhg= X-MC-Unique: brOMD1NGPo6EygjuQCtGKg-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Subject: [PULL 1/5] docs: add supported host CPU architectures section Date: Tue, 14 Sep 2021 17:01:24 +0400 Message-Id: <20210914130128.298226-2-marcandre.lureau@redhat.com> In-Reply-To: <20210914130128.298226-1-marcandre.lureau@redhat.com> References: <20210914130128.298226-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=marcandre.lureau@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.398, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1631625806811100001 From: Marc-Andr=C3=A9 Lureau I was looking for such documentation, but couldn't find it. Add it to the build-platform.rst document. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Peter Maydell --- docs/about/build-platforms.rst | 33 +++++++++++++++++++++++++++++++++ docs/about/deprecated.rst | 2 ++ 2 files changed, 35 insertions(+) diff --git a/docs/about/build-platforms.rst b/docs/about/build-platforms.rst index 692323609e..bcb1549721 100644 --- a/docs/about/build-platforms.rst +++ b/docs/about/build-platforms.rst @@ -29,6 +29,39 @@ The `Repology`_ site is a useful resource to identify currently shipped versions of software in various operating systems, though it does not cover all distros listed below. =20 +Supported host architectures +---------------------------- + +Those hosts are officially supported, with various accelerators: + + .. list-table:: + :header-rows: 1 + + * - CPU Architecture + - Accelerators + * - Arm + - kvm (64 bit only), tcg, xen + * - MIPS + - kvm, tcg + * - PPC + - kvm, tcg + * - RISC-V + - tcg + * - s390x + - kvm, tcg + * - SPARC + - tcg + * - x86 + - hax, hvf (64 bit only), kvm, nvmm, tcg, whpx (64 bit only), xen + +Other host architectures are not supported. It is possible to build QEMU o= n an +unsupported host architecture using the configure ``--enable-tcg-interpret= er`` +option to enable the experimental TCI support, but note that this is very = slow +and is not recommended. + +Non-supported architectures may be removed in the future following the +:ref:`deprecation process`. + Linux OS, macOS, FreeBSD, NetBSD, OpenBSD ----------------------------------------- =20 diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 9ee355ec0b..3c2be84d80 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -1,3 +1,5 @@ +.. _Deprecated features: + Deprecated features =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 --=20 2.33.0.113.g6c40894d24 From nobody Mon May 6 11:20:19 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1631626104; cv=none; d=zohomail.com; s=zohoarc; b=id79oVM5uzPf4Rd4ebDsdRjKnyIdDYDn6p5XC3FIHhr3873wr6xegJry3TAMpwvyAqySbMUK15T+3caVLE6w7fGyQ1QrXvWgxL9AONfLAEBkGmlJzWtZb4mx1KytVuOyA+7acL9FT0wykYVre6U7jveMfWvR3xuS2CpMsAnKzzc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1631626104; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=GrfrZ7zyB4rI5Mf0gl0TECubGC8Ihyv+Lf2lTPWpxTQ=; b=XW39iO8RE6FUQzO6DBdU07z0WDERSk+r330EeOji/iDY73a+nFFE331niEq7xQPFjKW88WtzM74fKaP00Rzn7QyZ6jpYduW1TItl5U8MflT4+593Iu8sOAINDJdnMICJ9GU6GsPWdhPLCoWDmLdKlfa3F7TMVyRUcQqW9i++v2s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1631626104365373.75216762158857; Tue, 14 Sep 2021 06:28:24 -0700 (PDT) Received: from localhost ([::1]:41506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQ8U3-0000De-7J for importer@patchew.org; Tue, 14 Sep 2021 09:28:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37878) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQ84X-0006NP-CK for qemu-devel@nongnu.org; Tue, 14 Sep 2021 09:02:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:26117) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQ84Q-0008PE-K0 for qemu-devel@nongnu.org; Tue, 14 Sep 2021 09:02:01 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-490-QzZbRo3kNNOWDORHvejCsw-1; Tue, 14 Sep 2021 09:01:50 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 157939017E6; Tue, 14 Sep 2021 13:01:50 +0000 (UTC) Received: from localhost (unknown [10.39.208.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4D2055D9D3; Tue, 14 Sep 2021 13:01:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631624512; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GrfrZ7zyB4rI5Mf0gl0TECubGC8Ihyv+Lf2lTPWpxTQ=; b=evArVYQBGZMliNkDA36+lBCgPGo1h2t2MS61Zh5sMgInsAXgBXPGv0iGN83OATOSjagGb+ f7wprDLWg3ATOQlpRuooHvCQz3n0dkUR2XT33Dl7yKEGT2YpOTuaAp71Pmv3TWnqqjOuS5 1poAoP22mK/8jvYxNc7AoPyTHlpXH04= X-MC-Unique: QzZbRo3kNNOWDORHvejCsw-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Subject: [PULL 2/5] meson.build: fix comment typo Date: Tue, 14 Sep 2021 17:01:25 +0400 Message-Id: <20210914130128.298226-3-marcandre.lureau@redhat.com> In-Reply-To: <20210914130128.298226-1-marcandre.lureau@redhat.com> References: <20210914130128.298226-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=marcandre.lureau@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.398, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1631626106251100001 From: Marc-Andr=C3=A9 Lureau Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Peter Maydell --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 7d7d14a4bc..2711cbb789 100644 --- a/meson.build +++ b/meson.build @@ -78,7 +78,7 @@ endif =20 accelerator_targets =3D { 'CONFIG_KVM': kvm_targets } if cpu in ['x86', 'x86_64', 'arm', 'aarch64'] - # i368 emulator provides xenpv machine type for multiple architectures + # i386 emulator provides xenpv machine type for multiple architectures accelerator_targets +=3D { 'CONFIG_XEN': ['i386-softmmu', 'x86_64-softmmu'], } --=20 2.33.0.113.g6c40894d24 From nobody Mon May 6 11:20:19 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1631626304; cv=none; d=zohomail.com; s=zohoarc; b=ELuqiGLbcKocAYInh8hSH89hqAaOfgYx1UsdJKJeD7FU4WSTjFLMwlilV61mtKCX/8QldZ71mBNRcJ2noLGb4XxUPjfZqUWr7JwpGwXUxjyDDz5srFbc21wzqWsOTrOGtkHSOW1imWUXtmfiBJ9Xbee32ViuKC5u1eEWmyMQPlo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1631626304; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=FtJKgxBbwisRtrtoddv42qvS68FVp0Px0t8Kp44t3Cg=; b=NJ3/7MIMycvLF7tfiMUSvC4Dam6hRU0QTkDADsNkukG3QtVzUbAIgyHg5T/zfXakFvcvAOvG/3bgq3iw85dWCunBYkqq1i3ibYOFwNiCQm/yEkHDQ/1dWhPbeI7FRjqF3Udax7WgLJKtLiYZ/NeES551Jb+hfvIjdazhwS513gE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1631626304629189.4096007619671; Tue, 14 Sep 2021 06:31:44 -0700 (PDT) Received: from localhost ([::1]:49174 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQ8XH-0005gC-9q for importer@patchew.org; Tue, 14 Sep 2021 09:31:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37882) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQ84Y-0006NU-5i for qemu-devel@nongnu.org; Tue, 14 Sep 2021 09:02:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:39475) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQ84V-0008Rj-JU for qemu-devel@nongnu.org; Tue, 14 Sep 2021 09:02:01 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-399-dklwETsyNciO9d-mfXsvHA-1; Tue, 14 Sep 2021 09:01:56 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AD08561196; Tue, 14 Sep 2021 13:01:54 +0000 (UTC) Received: from localhost (unknown [10.39.208.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id D20455C3DF; Tue, 14 Sep 2021 13:01:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631624519; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FtJKgxBbwisRtrtoddv42qvS68FVp0Px0t8Kp44t3Cg=; b=Dgx2UX0SBYzDMawBKDr2I2vFMa7d4rtzHMpJoeMDSRRkbUGPujEZC0zidUiOslvdc8cuF9 E7ACWx2YIKfeSGeZv3qiK1JZ4CItGeAyxhSt5qEh1wTwyo5FK8gjnhAU0/gtUWR8KyO5Su h7zxE8v27QSwbudAMGtL0BWEILJAF9o= X-MC-Unique: dklwETsyNciO9d-mfXsvHA-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Subject: [PULL 3/5] chardev: Propagate error from logfile opening Date: Tue, 14 Sep 2021 17:01:26 +0400 Message-Id: <20210914130128.298226-4-marcandre.lureau@redhat.com> In-Reply-To: <20210914130128.298226-1-marcandre.lureau@redhat.com> References: <20210914130128.298226-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=marcandre.lureau@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.398, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Michal Privoznik Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1631626305343100001 From: Michal Privoznik If a chardev has a logfile the file is opened using qemu_open_old() which does the job, but since @errp is not propagated into qemu_open_internal() we lose much more accurate error and just report "Unable to open logfile $errno". When using plain files, it's probably okay as nothing complex is happening behind the curtains. But the problem becomes more prominent when passing an "/dev/fdset/XXX" path since much more needs to be done. The fix is to use qemu_create() which passes @errp further down. Signed-off-by: Michal Privoznik Reviewed-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: --- chardev/char.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/chardev/char.c b/chardev/char.c index 4595a8d430..0169d8dde4 100644 --- a/chardev/char.c +++ b/chardev/char.c @@ -241,18 +241,15 @@ static void qemu_char_open(Chardev *chr, ChardevBacke= nd *backend, ChardevCommon *common =3D backend ? backend->u.null.data : NULL; =20 if (common && common->has_logfile) { - int flags =3D O_WRONLY | O_CREAT; + int flags =3D O_WRONLY; if (common->has_logappend && common->logappend) { flags |=3D O_APPEND; } else { flags |=3D O_TRUNC; } - chr->logfd =3D qemu_open_old(common->logfile, flags, 0666); + chr->logfd =3D qemu_create(common->logfile, flags, 0666, errp); if (chr->logfd < 0) { - error_setg_errno(errp, errno, - "Unable to open logfile %s", - common->logfile); return; } } --=20 2.33.0.113.g6c40894d24 From nobody Mon May 6 11:20:19 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1631625832; cv=none; d=zohomail.com; s=zohoarc; b=byRYP+Ow4KSenNjHbx3ztXoJcZYFbd2rrCnc9jBRskLl++Dq5AB2CO34mjPOFPmAQyucxAoY+l94BZKKYtq/oiPKD1YwyltQTFEzskQiUgRjYOBPQNqYDGI+DWi2fElDjeifi7Nm4SCXx+18Xet7N3pfytFA9TsPsmJ9flkmNqA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1631625832; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=r/UeUmJ8q3xbSNMWStUjpua4QQTduG8k986Qcpw7xNo=; b=TAdYrBzgZPlOwjgUXi/WfsBgN7A6pKromuYF4Qe92MG8wHel9kYoqutVfBuK+ULwlMdXR/xUkVAW/1FBVmPznpnCwyItCJLMVex2B9BaNLk4pWCQ+Gmq+JsqW55e5wdUencvcyASri7VKbkKA8m4mv8N77busB+6bkjn1Kf9Si4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1631625832358749.6415616629084; Tue, 14 Sep 2021 06:23:52 -0700 (PDT) Received: from localhost ([::1]:54832 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQ8Pf-0006zd-C6 for importer@patchew.org; Tue, 14 Sep 2021 09:23:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37976) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQ84n-0006Tl-Eo for qemu-devel@nongnu.org; Tue, 14 Sep 2021 09:02:17 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:34500) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQ84l-00006s-NN for qemu-devel@nongnu.org; Tue, 14 Sep 2021 09:02:17 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-189-zMrmwxrJPc6l6xvrhRvS0Q-1; Tue, 14 Sep 2021 09:02:13 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2416A802CBC; Tue, 14 Sep 2021 13:02:12 +0000 (UTC) Received: from localhost (unknown [10.39.208.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id D5A986B55E; Tue, 14 Sep 2021 13:01:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631624535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r/UeUmJ8q3xbSNMWStUjpua4QQTduG8k986Qcpw7xNo=; b=O5k6nhu3zCpW/T2tcjPhT0F9UydRdndM4IM4DEfUxyvUGiPJCtH378fPD8+oSk3eBfgPlx /09YMnM3JSW6mqgjgQnly7c6/Ipy/opfbIQ9pyWWPYasVY9iHHQeZYvoawOhzh38GmteOD TlW2WzCZu3r6oJdLtUyub8eG1WpdhGA= X-MC-Unique: zMrmwxrJPc6l6xvrhRvS0Q-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Subject: [PULL 4/5] chardev: remove needless class method Date: Tue, 14 Sep 2021 17:01:27 +0400 Message-Id: <20210914130128.298226-5-marcandre.lureau@redhat.com> In-Reply-To: <20210914130128.298226-1-marcandre.lureau@redhat.com> References: <20210914130128.298226-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=marcandre.lureau@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.398, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1631625832572100001 From: Marc-Andr=C3=A9 Lureau "chr_option_parsed" is only implemented by the "mux" chardev, we can specialize the code there to avoid the needless generic class method. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel P. Berrang=C3=A9 --- include/chardev/char.h | 1 - chardev/char-mux.c | 6 ++---- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/include/chardev/char.h b/include/chardev/char.h index 7c0444f90d..589e7fe46d 100644 --- a/include/chardev/char.h +++ b/include/chardev/char.h @@ -273,7 +273,6 @@ struct ChardevClass { void (*chr_set_echo)(Chardev *chr, bool echo); void (*chr_set_fe_open)(Chardev *chr, int fe_open); void (*chr_be_event)(Chardev *s, QEMUChrEvent event); - void (*chr_options_parsed)(Chardev *chr); }; =20 Chardev *qemu_chardev_new(const char *id, const char *typename, diff --git a/chardev/char-mux.c b/chardev/char-mux.c index 5baf419010..ada0c6866f 100644 --- a/chardev/char-mux.c +++ b/chardev/char-mux.c @@ -386,10 +386,9 @@ void suspend_mux_open(void) static int chardev_options_parsed_cb(Object *child, void *opaque) { Chardev *chr =3D (Chardev *)child; - ChardevClass *class =3D CHARDEV_GET_CLASS(chr); =20 - if (!chr->be_open && class->chr_options_parsed) { - class->chr_options_parsed(chr); + if (!chr->be_open && CHARDEV_IS_MUX(chr)) { + open_muxes(chr); } =20 return 0; @@ -412,7 +411,6 @@ static void char_mux_class_init(ObjectClass *oc, void *= data) cc->chr_accept_input =3D mux_chr_accept_input; cc->chr_add_watch =3D mux_chr_add_watch; cc->chr_be_event =3D mux_chr_be_event; - cc->chr_options_parsed =3D open_muxes; cc->chr_update_read_handler =3D mux_chr_update_read_handlers; } =20 --=20 2.33.0.113.g6c40894d24 From nobody Mon May 6 11:20:19 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1631626433; cv=none; d=zohomail.com; s=zohoarc; b=fYzmq+kqiRtBi+trBk+ERbFwzv6Dg9j+whZhKecl9DkKQYXrwsIMADrozdmFJbPyy6PCcgGMgyawoJYPxSsn0J9Xq0w+Za17gw3Vql5vfycT9Q16WYmHqGQWfNEkQ0+1O2It4iEOD/VPa1D5Y+U+uE+HhMW9wj0WP68SgPtlXQw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1631626433; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+z9TupSNpWCsdn1hJ+/WP446zFtWwksDqkjq6KR1lhQ=; b=LdSN5Kf4hcjtRrQENGhX6xqZFYGHCgMQnE6JePGZ+S0S843oCQxQWhkQxWAH3P6ijTw7FJO3A7JCpCbuaQY/HMFeWQ4exVamqT0637E6cWxdhr+sIDBQPzKY95gS2Vhbl+HZha/DrHZDUs2qhFULWmW4jwf5mQ9kf4cZTVN87FY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1631626433768140.26750496847842; Tue, 14 Sep 2021 06:33:53 -0700 (PDT) Received: from localhost ([::1]:53790 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQ8ZM-0000Td-P3 for importer@patchew.org; Tue, 14 Sep 2021 09:33:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38096) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQ859-0006rt-3J for qemu-devel@nongnu.org; Tue, 14 Sep 2021 09:02:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:57846) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQ856-0000HZ-Uq for qemu-devel@nongnu.org; Tue, 14 Sep 2021 09:02:38 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-222-CKH8NtmIPMmhvFBFh0Hk6w-1; Tue, 14 Sep 2021 09:02:34 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D860B80415A; Tue, 14 Sep 2021 13:02:20 +0000 (UTC) Received: from localhost (unknown [10.39.208.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id A553819739; Tue, 14 Sep 2021 13:02:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631624556; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+z9TupSNpWCsdn1hJ+/WP446zFtWwksDqkjq6KR1lhQ=; b=HVUmqdY907xC0MMIjdDJ/slFzvW4eMeozxDAHkplbe02yMIRYg2UWFYb2aYKzfj6BQnRni gul8ljhWG66j07PGMZzkIMf7712Hnn6wy2O+4etmxYI2REVhiYNvYp/3pDxm6zdx5KCFo1 wkBOo5sEoqXZd5euXX4fA4Y3znU72zY= X-MC-Unique: CKH8NtmIPMmhvFBFh0Hk6w-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Subject: [PULL 5/5] chardev: add some comments about the class methods Date: Tue, 14 Sep 2021 17:01:28 +0400 Message-Id: <20210914130128.298226-6-marcandre.lureau@redhat.com> In-Reply-To: <20210914130128.298226-1-marcandre.lureau@redhat.com> References: <20210914130128.298226-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=marcandre.lureau@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.398, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1631626434935100001 From: Marc-Andr=C3=A9 Lureau Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Daniel P. Berrang=C3=A9 Message-Id: <20210804154848.557328-5-marcandre.lureau@redhat.com> --- include/chardev/char.h | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/include/chardev/char.h b/include/chardev/char.h index 589e7fe46d..a319b5fdff 100644 --- a/include/chardev/char.h +++ b/include/chardev/char.h @@ -254,24 +254,57 @@ struct ChardevClass { =20 bool internal; /* TODO: eventually use TYPE_USER_CREATABLE */ bool supports_yank; + + /* parse command line options and populate QAPI @backend */ void (*parse)(QemuOpts *opts, ChardevBackend *backend, Error **errp); =20 + /* called after construction, open/starts the backend */ void (*open)(Chardev *chr, ChardevBackend *backend, bool *be_opened, Error **errp); =20 + /* write buf to the backend */ int (*chr_write)(Chardev *s, const uint8_t *buf, int len); + + /* + * Read from the backend (blocking). A typical front-end will instead = rely + * on chr_can_read/chr_read being called when polling/looping. + */ int (*chr_sync_read)(Chardev *s, const uint8_t *buf, int len); + + /* create a watch on the backend */ GSource *(*chr_add_watch)(Chardev *s, GIOCondition cond); + + /* update the backend internal sources */ void (*chr_update_read_handler)(Chardev *s); + + /* send an ioctl to the backend */ int (*chr_ioctl)(Chardev *s, int cmd, void *arg); + + /* get ancillary-received fds during last read */ int (*get_msgfds)(Chardev *s, int* fds, int num); + + /* set ancillary fds to be sent with next write */ int (*set_msgfds)(Chardev *s, int *fds, int num); + + /* accept the given fd */ int (*chr_add_client)(Chardev *chr, int fd); + + /* wait for a connection */ int (*chr_wait_connected)(Chardev *chr, Error **errp); + + /* disconnect a connection */ void (*chr_disconnect)(Chardev *chr); + + /* called by frontend when it can read */ void (*chr_accept_input)(Chardev *chr); + + /* set terminal echo */ void (*chr_set_echo)(Chardev *chr, bool echo); + + /* notify the backend of frontend open state */ void (*chr_set_fe_open)(Chardev *chr, int fe_open); + + /* handle various events */ void (*chr_be_event)(Chardev *s, QEMUChrEvent event); }; =20 --=20 2.33.0.113.g6c40894d24