From nobody Sat Feb 7 06:55:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 163154024467664.37504729317197; Mon, 13 Sep 2021 06:37:24 -0700 (PDT) Received: from localhost ([::1]:57252 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPm9D-0000kj-Eh for importer@patchew.org; Mon, 13 Sep 2021 09:37:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51668) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPlFf-0000Vu-Vu for qemu-devel@nongnu.org; Mon, 13 Sep 2021 08:40:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:58908) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPlFe-0000r8-DM for qemu-devel@nongnu.org; Mon, 13 Sep 2021 08:39:59 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-572-lSI1SwCCOj6FUxJzuMSSEg-1; Mon, 13 Sep 2021 08:39:56 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A552319200C3 for ; Mon, 13 Sep 2021 12:39:55 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-14.ams2.redhat.com [10.36.112.14]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A21941037E99; Mon, 13 Sep 2021 12:39:43 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 48DE111380BC; Mon, 13 Sep 2021 14:39:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631536797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gdPR75eYbQXxD0iOTPV5eI2d97+ye2PZP2RByIGD8WM=; b=AN71KT70z4Q5Z3TP5JT3hcZKFUK6DQQQ6XdSYJc0C+oyBIFX8nTlpJK4akJD5LBAgSzDyc J10mC+5sT6i2FvRznieUpsO9k6wDu37TEA6Vor6OqA4RQ/kYXHWJxQgimvlONY6zjV6tBo CkavuSsvZ83XrXU3OicHUSEhZDa38ew= X-MC-Unique: lSI1SwCCOj6FUxJzuMSSEg-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PATCH 18/22] test-clone-visitor: Wean off __org.qemu_x-Union1 Date: Mon, 13 Sep 2021 14:39:28 +0200 Message-Id: <20210913123932.3306639-19-armbru@redhat.com> In-Reply-To: <20210913123932.3306639-1-armbru@redhat.com> References: <20210913123932.3306639-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.398, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jsnow@redhat.com, eblake@redhat.com, marcandre.lureau@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1631540246729100001 Content-Type: text/plain; charset="utf-8" test_clone_complex3() uses simple union __org.qemu_x-Union1 to cover arrays. Use UserDefOneList instead. Unions are still covered by test_clone_complex1(). Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- tests/unit/test-clone-visitor.c | 70 ++++++++++++++++++--------------- 1 file changed, 38 insertions(+), 32 deletions(-) diff --git a/tests/unit/test-clone-visitor.c b/tests/unit/test-clone-visito= r.c index 8357a90e60..4048018607 100644 --- a/tests/unit/test-clone-visitor.c +++ b/tests/unit/test-clone-visitor.c @@ -153,42 +153,48 @@ static void test_clone_complex2(void) =20 static void test_clone_complex3(void) { - __org_qemu_x_Struct2 *src, *dst; - __org_qemu_x_Union1List *tmp; + UserDefOneList *src, *dst, *tail; + UserDefOne *elt; =20 - src =3D g_new0(__org_qemu_x_Struct2, 1); - tmp =3D src->array =3D g_new0(__org_qemu_x_Union1List, 1); - tmp->value =3D g_new0(__org_qemu_x_Union1, 1); - tmp->value->type =3D ORG_QEMU_X_UNION1_KIND___ORG_QEMU_X_BRANCH; - tmp->value->u.__org_qemu_x_branch.data =3D g_strdup("one"); - tmp =3D tmp->next =3D g_new0(__org_qemu_x_Union1List, 1); - tmp->value =3D g_new0(__org_qemu_x_Union1, 1); - tmp->value->type =3D ORG_QEMU_X_UNION1_KIND___ORG_QEMU_X_BRANCH; - tmp->value->u.__org_qemu_x_branch.data =3D g_strdup("two"); - tmp =3D tmp->next =3D g_new0(__org_qemu_x_Union1List, 1); - tmp->value =3D g_new0(__org_qemu_x_Union1, 1); - tmp->value->type =3D ORG_QEMU_X_UNION1_KIND___ORG_QEMU_X_BRANCH; - tmp->value->u.__org_qemu_x_branch.data =3D g_strdup("three"); + src =3D NULL; + elt =3D g_new0(UserDefOne, 1); + elt->integer =3D 3; + elt->string =3D g_strdup("three"); + elt->has_enum1 =3D true; + elt->enum1 =3D ENUM_ONE_VALUE3; + QAPI_LIST_PREPEND(src, elt); + elt =3D g_new0(UserDefOne, 1); + elt->integer =3D 2; + elt->string =3D g_strdup("two"); + QAPI_LIST_PREPEND(src, elt); + elt =3D g_new0(UserDefOne, 1); + elt->integer =3D 1; + elt->string =3D g_strdup("one"); + QAPI_LIST_PREPEND(src, elt); + + dst =3D QAPI_CLONE(UserDefOneList, src); =20 - dst =3D QAPI_CLONE(__org_qemu_x_Struct2, src); g_assert(dst); - tmp =3D dst->array; - g_assert(tmp); - g_assert(tmp->value); - g_assert_cmpstr(tmp->value->u.__org_qemu_x_branch.data, =3D=3D, "one"); - tmp =3D tmp->next; - g_assert(tmp); - g_assert(tmp->value); - g_assert_cmpstr(tmp->value->u.__org_qemu_x_branch.data, =3D=3D, "two"); - tmp =3D tmp->next; - g_assert(tmp); - g_assert(tmp->value); - g_assert_cmpstr(tmp->value->u.__org_qemu_x_branch.data, =3D=3D, "three= "); - tmp =3D tmp->next; - g_assert(!tmp); + tail =3D dst; + elt =3D tail->value; + g_assert_cmpint(elt->integer, =3D=3D, 1); + g_assert_cmpstr(elt->string, =3D=3D, "one"); + g_assert(!elt->has_enum1); + tail =3D tail->next; + elt =3D tail->value; + g_assert_cmpint(elt->integer, =3D=3D, 2); + g_assert_cmpstr(elt->string, =3D=3D, "two"); + g_assert(!elt->has_enum1); + tail =3D tail->next; + elt =3D tail->value; + g_assert_cmpint(elt->integer, =3D=3D, 3); + g_assert_cmpstr(elt->string, =3D=3D, "three"); + g_assert(elt->has_enum1); + g_assert_cmpint(elt->enum1, =3D=3D, ENUM_ONE_VALUE3); + g_assert(!tail->next); =20 - qapi_free___org_qemu_x_Struct2(src); - qapi_free___org_qemu_x_Struct2(dst); + qapi_free_UserDefOneList(src); + qapi_free_UserDefOneList(dst); } =20 int main(int argc, char **argv) --=20 2.31.1