From nobody Tue Feb 10 03:55:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.48 as permitted sender) client-ip=209.85.221.48; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f48.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1631379398; cv=none; d=zohomail.com; s=zohoarc; b=EpQwu4jm/Z39J1tDD8203ZBUnGmf5QpIhyuYw5whZXth//9kBJuPg5s6DeMpnnoNXwYNjKGK6+b/aJoq0WOIhA5eTWfN5tssOtkWw6WPix8RehSuZ/k1Lj89rpxALCj0SSQqKBXI78fOpYfFqdBe+3gM/zokc4GGD7jLTZyrK6I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1631379398; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=nAFz6uvNO4/9EYWu5DXduJISoPxs8WbCdajWsYkTN9U=; b=dfEchcMLf7C5YVgh9iQnNbNbDXwWoxF10HJSozjsTnoQBi4/H7X+KMzttgDdNkgAhckVkqeBDfYw8l6c0iO4l+Z9h4cLQ6nYKswI4eSc+4U8xMioN+g45eE/hpEMplcHsRfZLDnTftHD+9+OD95wf0b0qYhjpmKHfGa1qSIUgC8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by mx.zohomail.com with SMTPS id 1631379398311330.2896540242032; Sat, 11 Sep 2021 09:56:38 -0700 (PDT) Received: by mail-wr1-f48.google.com with SMTP id b6so7464049wrh.10 for ; Sat, 11 Sep 2021 09:56:37 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (21.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.21]) by smtp.gmail.com with ESMTPSA id l3sm1977278wms.4.2021.09.11.09.56.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Sep 2021 09:56:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nAFz6uvNO4/9EYWu5DXduJISoPxs8WbCdajWsYkTN9U=; b=FC9yc79mpkX9Z48izAMhm2ukvfK95DoTM20mE2x/WD0DMdj4fD1Bl0eomnNdiZH9Xh FqRpxUjMC128ef0fNdt+RLiLouA7ll7RGzvqgF67Y5y8MOjRclQhcz3Gtt0J2KjLDp0Z IyEV3gBbH/ZMqrNTOz+0aoN3oBItEu6MuSIWYE5Bp41jmNtIJU58VaRLmfXK7s+FDjXk yJc9W0a+Lq1Clj9K47IYsgsqErCcxTXgsu5a4vhwAQjnToJS+2FD6iafng8V7aBlYGOR XF/Nmyei5ij0gpDoVRdlpgxsLWI3QaqAdovh6SPhckl25PnEujGC2Vsv/2cF1ytY/XX5 Z/og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=nAFz6uvNO4/9EYWu5DXduJISoPxs8WbCdajWsYkTN9U=; b=EkEJ/XklQIeq0YCIIPH9EqTIrBmohqZNnJyXGBMOe1FtDkZJHyL07B2SXp/TrwsLXd WIhLtMSkHxu7c/KXYQAPoHijzlcCcsLviCBvdyuHwhXuC3SIuiw3GD5jv/URTZ3FAoEs JXxXZ/cTeVSVLXuEHo8QEfBNFZMPmkXdJyq3p20K/4PvPBAl6bGnuELUbP8Se/GquGiH MkqliUqtgCZsEo1Hg+Fhi9GVr0R+G2YiclYmaYFgIecTis4GX1Etea2IRVjwlh8obVDZ LQGmyDm1Cq82N1D2NTlD3B7p9RAuhkuwPxUMrfsFaqzOPc0HuGsXqDfKGVXu32xw1E1y FZUw== X-Gm-Message-State: AOAM533Icb7u+Q1318KXZLT4KFCmYVHRXdjvCHOQsn6x9F3F+/nWr7vA yX9tYrPx0FhbubK6XsoJlBY= X-Google-Smtp-Source: ABdhPJwsvGd/4V668UVQkVkX2A7YUCQ8PYUz5Lq9qq+qk3q/kvyKZJb72zlYXRx0zOghI8/i00xqlQ== X-Received: by 2002:adf:b789:: with SMTP id s9mr3870061wre.315.1631379396644; Sat, 11 Sep 2021 09:56:36 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Warner Losh Subject: [PATCH v3 24/24] user: Remove cpu_get_pic_interrupt() stubs Date: Sat, 11 Sep 2021 18:54:34 +0200 Message-Id: <20210911165434.531552-25-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210911165434.531552-1-f4bug@amsat.org> References: <20210911165434.531552-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1631379400055100001 cpu_get_pic_interrupt() is now unreachable from user-mode, delete the unnecessary stubs. Reviewed-by: Warner Losh Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/i386/cpu.h | 2 +- bsd-user/i386/target_arch_cpu.c | 5 ----- bsd-user/x86_64/target_arch_cpu.c | 5 ----- linux-user/main.c | 7 ------- 4 files changed, 1 insertion(+), 18 deletions(-) diff --git a/target/i386/cpu.h b/target/i386/cpu.h index c241bc183d2..c7cc65e92d5 100644 --- a/target/i386/cpu.h +++ b/target/i386/cpu.h @@ -1832,9 +1832,9 @@ int x86_cpu_gdb_write_register(CPUState *cpu, uint8_t= *buf, int reg); void x86_cpu_list(void); int cpu_x86_support_mca_broadcast(CPUX86State *env); =20 +#ifndef CONFIG_USER_ONLY int cpu_get_pic_interrupt(CPUX86State *s); =20 -#ifndef CONFIG_USER_ONLY /* MSDOS compatibility mode FPU exception support */ void x86_register_ferr_irq(qemu_irq irq); void fpu_check_raise_ferr_irq(CPUX86State *s); diff --git a/bsd-user/i386/target_arch_cpu.c b/bsd-user/i386/target_arch_cp= u.c index 71998e5ba56..d349e452997 100644 --- a/bsd-user/i386/target_arch_cpu.c +++ b/bsd-user/i386/target_arch_cpu.c @@ -33,11 +33,6 @@ uint64_t cpu_get_tsc(CPUX86State *env) return cpu_get_host_ticks(); } =20 -int cpu_get_pic_interrupt(CPUX86State *env) -{ - return -1; -} - void bsd_i386_write_dt(void *ptr, unsigned long addr, unsigned long limit, int flags) { diff --git a/bsd-user/x86_64/target_arch_cpu.c b/bsd-user/x86_64/target_arc= h_cpu.c index db822e54c66..be7bd107200 100644 --- a/bsd-user/x86_64/target_arch_cpu.c +++ b/bsd-user/x86_64/target_arch_cpu.c @@ -33,11 +33,6 @@ uint64_t cpu_get_tsc(CPUX86State *env) return cpu_get_host_ticks(); } =20 -int cpu_get_pic_interrupt(CPUX86State *env) -{ - return -1; -} - void bsd_x86_64_write_dt(void *ptr, unsigned long addr, unsigned long limit, int flags) { diff --git a/linux-user/main.c b/linux-user/main.c index a6094563b6b..45bde4598d5 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -120,13 +120,6 @@ const char *qemu_uname_release; by remapping the process stack directly at the right place */ unsigned long guest_stack_size =3D 8 * 1024 * 1024UL; =20 -#if defined(TARGET_I386) -int cpu_get_pic_interrupt(CPUX86State *env) -{ - return -1; -} -#endif - /***********************************************************/ /* Helper routines for implementing atomic operations. */ =20 --=20 2.31.1