From nobody Tue Feb 10 02:43:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1631253490871801.521201503023; Thu, 9 Sep 2021 22:58:10 -0700 (PDT) Received: from localhost ([::1]:33924 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mOZY9-0001EH-Mo for importer@patchew.org; Fri, 10 Sep 2021 01:58:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45222) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mOZWc-0007L2-Kl for qemu-devel@nongnu.org; Fri, 10 Sep 2021 01:56:34 -0400 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]:33515) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mOZWb-0002EZ-2P for qemu-devel@nongnu.org; Fri, 10 Sep 2021 01:56:34 -0400 Received: by mail-pj1-x102d.google.com with SMTP id mi6-20020a17090b4b4600b00199280a31cbso620393pjb.0 for ; Thu, 09 Sep 2021 22:56:32 -0700 (PDT) Received: from localhost.localdomain (123-193-74-252.dynamic.kbronet.com.tw. [123.193.74.252]) by smtp.gmail.com with ESMTPSA id v17sm3739101pff.6.2021.09.09.22.56.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Sep 2021 22:56:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vlSo0PzjSFDdQC+eNe3BvcniCYCo3WbCGNs2dWZA46I=; b=ILz3Z3oHWz22T8O93YFbmMzfkZr3GXGU0hsbBreJ+rubc1nKdNU1RwuyfL52ZwMW5a KihXBpvh2VGWs493mz8Lno31BKO624kgEpbyrwxSJQXndOPzPZKY/DwTRfAd4rcRIwJ7 rfftFziXn5uH9mCptyCEeeFW1yPcHDdMqzsLuETcB1sQuHxaqK7kb5HyIocxdyDX5D5C r8r0lrzV6oQ+4Ro7i2562D+p3qES27jSWwpYpg2T+BFfodIlPR83YoQlDWJqgCPY/DyM Vshd+gPrJ0ipCZzXC6wiix0lbfXBd75MZylFAMfs37qDmUOsRXRXWAQcwje+DbGIm0Zw 4amA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vlSo0PzjSFDdQC+eNe3BvcniCYCo3WbCGNs2dWZA46I=; b=I6SQcvaOObCmvYo0v0/9xrWaEZgUimgbzt7gBd1tnNcWz3bQLiwDvoB8+Mf+FJ3psS lDUxxUF97M/FQKAKkTo0kcIcTUhvEFMnB0jV8Ad6NIk6BPhq+26A+wYIKasf5SIbaiSK BcYrWwwQLoCGDgfU9UUy6tBEynt7lWrWoVGDgs2qTxFc1BdBOJzAs79asatz3BxkBv8J K0DvIpTlJEDfI0yV6oiHrWbTPEaGzGis4CsYkaqVwYqQGp1STFtUUHLiFYwjz1aVcyBw wj+PKUBiyiS6+m7kuBn91jvqVQwKm6wuWgfPnHqfFuK+LH7+L5OCVw/2t01OxyDEY6Q6 HWmA== X-Gm-Message-State: AOAM531VaxMAZLkID6fnX3jrVSJe+cMLOfGfem2ZoKw7uQgSUKAWZ2Ny fO1Qii0J4mCzIlxvODbljk9orD17biLALK3X X-Google-Smtp-Source: ABdhPJxZt5i0OufSDSEvo1Dwm8WEgm49Zx9T2oHCGjmOUm9JkKLB+qqehsgt8Kl83wYkuCNjqD3+vw== X-Received: by 2002:a17:90b:4d85:: with SMTP id oj5mr1952511pjb.41.1631253391186; Thu, 09 Sep 2021 22:56:31 -0700 (PDT) From: frank.chang@sifive.com To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org Subject: [PATCH 1/4] hw/dma: sifive_pdma: reset Next* registers when Control.claim is set Date: Fri, 10 Sep 2021 13:56:13 +0800 Message-Id: <20210910055620.946625-2-frank.chang@sifive.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210910055620.946625-1-frank.chang@sifive.com> References: <20210910055620.946625-1-frank.chang@sifive.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::102d; envelope-from=frank.chang@sifive.com; helo=mail-pj1-x102d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Frank Chang , Palmer Dabbelt , Bin Meng , Alistair Francis , Max Hsu Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1631253492503100001 Content-Type: text/plain; charset="utf-8" From: Frank Chang Setting Control.claim clears all of the chanel's Next registers. This is effective only when Control.claim is set from 0 to 1. Signed-off-by: Frank Chang Tested-by: Max Hsu Reviewed-by: Bin Meng Tested-by: Bin Meng --- hw/dma/sifive_pdma.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/hw/dma/sifive_pdma.c b/hw/dma/sifive_pdma.c index 9b2ac2017d9..e723db9d700 100644 --- a/hw/dma/sifive_pdma.c +++ b/hw/dma/sifive_pdma.c @@ -54,6 +54,9 @@ #define DMA_EXEC_DST 0x110 #define DMA_EXEC_SRC 0x118 =20 +#define CONFIG_WRSZ_DEFAULT 6 +#define CONFIG_RDSZ_DEFAULT 6 + enum dma_chan_state { DMA_CHAN_STATE_IDLE, DMA_CHAN_STATE_STARTED, @@ -221,6 +224,7 @@ static void sifive_pdma_write(void *opaque, hwaddr offs= et, { SiFivePDMAState *s =3D opaque; int ch =3D SIFIVE_PDMA_CHAN_NO(offset); + bool claimed; =20 if (ch >=3D SIFIVE_PDMA_CHANS) { qemu_log_mask(LOG_GUEST_ERROR, "%s: Invalid channel no %d\n", @@ -231,6 +235,17 @@ static void sifive_pdma_write(void *opaque, hwaddr off= set, offset &=3D 0xfff; switch (offset) { case DMA_CONTROL: + claimed =3D !!s->chan[ch].control & CONTROL_CLAIM; + + if (!claimed && (value & CONTROL_CLAIM)) { + /* reset Next* registers */ + s->chan[ch].next_config =3D (CONFIG_RDSZ_DEFAULT << CONFIG_RDS= Z_SHIFT) | + (CONFIG_WRSZ_DEFAULT << CONFIG_WRSZ_= SHIFT); + s->chan[ch].next_bytes =3D 0; + s->chan[ch].next_dst =3D 0; + s->chan[ch].next_src =3D 0; + } + s->chan[ch].control =3D value; =20 if (value & CONTROL_RUN) { --=20 2.25.1