From nobody Mon Feb 9 12:26:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1630925007; cv=none; d=zohomail.com; s=zohoarc; b=Iuv/lDKn/hE6NQsC/kyxuMnfY/OFR8xDMZFGLL1pC/RWpTucNcbnN3sDnsc0eXyAzWJd7YHQ5XLw/1JCFest9SJaAxaU7VcUIctV5+jAi36Uk1aeyLTgGtMhhk638N23+c9RN9iEG4vZ43uvjOTw36XnG67AtMNiebnxGYY/3Vw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1630925007; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=flP71HjC8jGMU9xA5z+8rAkdDjbRG9SSiS1OKFek9Fk=; b=gYe34VL39zLnArno9ZKtmGpLsG5Yvg2yXscxjObZ0tKymX7EXWm31S+vaNQ+1OfYys42IjY9vaFSo8Q4dKrPJX2rdnP044CMH0nTubS8RnKe7Seec040LVKjXTskTt4HYQYjJKOgEut4p/CbEdxwMip7kl2GUMTKkp2HwS8HKLE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1630925007763462.8288265020392; Mon, 6 Sep 2021 03:43:27 -0700 (PDT) Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-422-LEvuEOzdO2SCoXr5v9a49w-1; Mon, 06 Sep 2021 06:43:25 -0400 Received: by mail-wr1-f72.google.com with SMTP id h6-20020a5d4fc6000000b00157503046afso1091538wrw.3 for ; Mon, 06 Sep 2021 03:43:25 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (21.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.21]) by smtp.gmail.com with ESMTPSA id f5sm6823938wmb.47.2021.09.06.03.43.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Sep 2021 03:43:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630925006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=flP71HjC8jGMU9xA5z+8rAkdDjbRG9SSiS1OKFek9Fk=; b=WkkQO/Nj0w5rgEvCXmyfVGrAZQdOwP6DeunO/pEGqJ3Uejv9Nw5q+emNqMGCSGy/N4Jfxz POhJG6Yvu1t0NPh7Acs5NTjrT1cTp8HLUE1NfgTikHdrQ3RxyxI8yQtO5AeDOmsItEbgJX j7ING6zzKjt/6ROG1NrIBVboyg18R/Y= X-MC-Unique: LEvuEOzdO2SCoXr5v9a49w-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=flP71HjC8jGMU9xA5z+8rAkdDjbRG9SSiS1OKFek9Fk=; b=T+kosBdmN1wZ5XMmMKXVqmXwnzrQyVe3l6Kmh+4TabNX6UZnAKtQ+0xJi91Iad09aw WjBBnsZz0LVZ9f/ChVmPIyf09YDN6jjvBIEsAm4j5UwMPZ2q/JHjRoKpoe4A3qg47/OR Cg78dcPYXjdqI4JPot0UzmQy4hTK7+Oo/bRnuJPBVNMsM2MPn5lJnwgsM9sLBr+Ihuel yfU034fkuerUtdMDC7HkzZCr+ux2/fKe85OEmJuxyUw6i9f51Q8mIoijWXlThrRWglgt db9BCmNl3FZ/7cdJ9seRb48wcGCJG1yHICvC4IISNdCOSqqz6uiwsZ7/FyCdbQq+4IbW cBeA== X-Gm-Message-State: AOAM530MmLb6BJw4c5xCnyUvcxAqdZLlA6RiQOepdwv6DAQp/s7MDfIp 7HII/PwijEToM64PBdznFTyqri2CZJ55gUkuMnIIz3k+L2B/hddYxBAQ2Wf66FcG6hlqL+oOggv meojZlT9D7+iE2Q== X-Received: by 2002:a5d:53cf:: with SMTP id a15mr11419737wrw.146.1630925004443; Mon, 06 Sep 2021 03:43:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzX5pSkcTBvskmSyos1Xq4rn17eyBB8Dh9wCf2wv3w9XI1PFnJLqFaV/gseZsgrjD8l68SidA== X-Received: by 2002:a5d:53cf:: with SMTP id a15mr11419720wrw.146.1630925004306; Mon, 06 Sep 2021 03:43:24 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jason Wang , Cornelia Huck , Stefano Garzarella , "Michael S. Tsirkin" , Paolo Bonzini , Stefan Hajnoczi , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 1/3] hw/virtio: Comment virtqueue_flush() must be called with RCU read lock Date: Mon, 6 Sep 2021 12:43:16 +0200 Message-Id: <20210906104318.1569967-2-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210906104318.1569967-1-philmd@redhat.com> References: <20210906104318.1569967-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1630925009946100001 Reported-by: Stefano Garzarella Suggested-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/virtio/virtio.h | 7 +++++++ hw/virtio/virtio.c | 1 + 2 files changed, 8 insertions(+) diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h index 8bab9cfb750..c1c5f6e53c8 100644 --- a/include/hw/virtio/virtio.h +++ b/include/hw/virtio/virtio.h @@ -186,6 +186,13 @@ void virtio_delete_queue(VirtQueue *vq); =20 void virtqueue_push(VirtQueue *vq, const VirtQueueElement *elem, unsigned int len); +/** + * virtqueue_flush: + * @vq: The #VirtQueue + * @count: Number of elements to flush + * + * Must be called within RCU critical section. + */ void virtqueue_flush(VirtQueue *vq, unsigned int count); void virtqueue_detach_element(VirtQueue *vq, const VirtQueueElement *elem, unsigned int len); diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 3a1f6c520cb..97f60017466 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -896,6 +896,7 @@ static void virtqueue_packed_flush(VirtQueue *vq, unsig= ned int count) } } =20 +/* Called within rcu_read_lock(). */ void virtqueue_flush(VirtQueue *vq, unsigned int count) { if (virtio_device_disabled(vq->vdev)) { --=20 2.31.1