From nobody Tue Feb 10 02:49:45 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1630690819; cv=none; d=zohomail.com; s=zohoarc; b=dTsuGGcJXg/BPzZ/U7gOPoL5UOkdLklbcAjNOCuVTg17a1S5Xwex5o7aW8OfT/4olnKNr+9Y5OpQ7+Ak8GcQMNgXz2hAnCNkfH23f6P9IxUMqhey8DwtmLmTWOEU562MNBTMUngZLeX2WVGsB4xXkT/JQgzGswnwlu67NLN5xHA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1630690819; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=K59TWFNfhgS3efbWdzQjx6xmDgV9ebFReZvuleU1Sck=; b=WdlwmAOt/kzB76G4GrpM91xWLz4eHLPYMYALV2Ab+oR9TgK4NGqGDn2xF8jXOm2btiJ2FmDNopv1YLRc5iAqvzI5K8dcWxaSuOl5FCsgnmCHxJeaOr0GkdZSWji4xzXRqbZs586yZyBxvMpLpN+SntJfW1JD8xvNTqSaDa8CqAg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1630690819235257.06798506512155; Fri, 3 Sep 2021 10:40:19 -0700 (PDT) Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-431-3UUHukFXPoeu4i93Ziq--w-1; Fri, 03 Sep 2021 13:40:16 -0400 Received: by mail-wm1-f72.google.com with SMTP id o20-20020a05600c379400b002e755735eedso56124wmr.0 for ; Fri, 03 Sep 2021 10:40:16 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (21.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.21]) by smtp.gmail.com with ESMTPSA id l15sm46863wms.38.2021.09.03.10.40.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 10:40:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630690818; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K59TWFNfhgS3efbWdzQjx6xmDgV9ebFReZvuleU1Sck=; b=IT49c8g6oFZKnh4hs79alpi7AWXbxkKYZfawnzMMrvPvkWagdrPut1o7N6/iQBLOfrOES5 GsRT0zF/zzwhyt3tE0ISdb17vjy/pbmOJSkxxw63Z/tK/aJZ2wuq91rt70G7bUJ+8Iz3Qw xyEkAaQucmuHrfLatH0JSphtrfccL/k= X-MC-Unique: 3UUHukFXPoeu4i93Ziq--w-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=K59TWFNfhgS3efbWdzQjx6xmDgV9ebFReZvuleU1Sck=; b=KPtUkdT/oVkR5pVsGZEofK1rRO56+iBx+zDehMlvTNS5/tL1WJa6heso9Kd7qnN9+v O2C0HNGeD5CZFX3c3cN0OYEx3e4l+XThpmCUjaN3OUnlNE8nFZqq5VSLrKd9RMIAof94 B6z+L29xutgegWLOQvBZqRkXsexUdjl2c+3+OtHzQvZ931zDCY4xxR67RsI2ScRkgsqL xQCd0X6ZdSJIQZVRa1qyPIfrIMj+oMyTPc2HDcRUZX63r7OA3UFHaoCyjzHGWjv6RH8v kyrlsPxU8ABCrzdgK56rhVsblduCzQDpPQGyCDNodvR8VpNyfH9t8c4aFs8vv0AB+mVR vFsw== X-Gm-Message-State: AOAM530PaZxvTUCV3niP0XjVwTmv/qNgB+ps/QNhKlbykpBX8dXBgqMu oAwtCLctVj/O/R0w1BT7Bp3EXPfIegSNtbLjUkwjspus7lLKF9rfAbNZ7atF7Wjx9eYd+4R6Ihg zM55hYipigEO1eg== X-Received: by 2002:a5d:618f:: with SMTP id j15mr279376wru.80.1630690815796; Fri, 03 Sep 2021 10:40:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQ8ltCxCGPrsfZc1qSqxdxCnJ5muEt8bAzrDH8cwMXP+ogfAkDYo822ywwAfB2z4cvfOIDew== X-Received: by 2002:a5d:618f:: with SMTP id j15mr279319wru.80.1630690815396; Fri, 03 Sep 2021 10:40:15 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Vladimir Sementsov-Ogievskiy , Laurent Vivier , Kevin Wolf , qemu-ppc@nongnu.org, "Michael S. Tsirkin" , Hanna Reitz , Richard Henderson , qemu-block@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Gerd Hoffmann , Eduardo Habkost , Fam Zheng , Jason Wang , qemu-arm@nongnu.org, Christian Schoenebeck , Markus Armbruster , Peter Maydell , John Snow , Alex Williamson , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Thomas Huth , "Daniel P . Berrange" , David Hildenbrand , Eric Blake , David Gibson , Marcel Apfelbaum Subject: [PATCH v2 01/30] hw/hyperv/vmbus: Remove unused vmbus_load/save_req() Date: Fri, 3 Sep 2021 19:39:39 +0200 Message-Id: <20210903174008.749126-2-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210903174008.749126-1-philmd@redhat.com> References: <20210903174008.749126-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1630690821557100001 vmbus_save_req() and vmbus_load_req() are not used. Remove them to avoid maintaining dead code. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/hyperv/vmbus.h | 3 -- hw/hyperv/vmbus.c | 59 --------------------------------------- 2 files changed, 62 deletions(-) diff --git a/include/hw/hyperv/vmbus.h b/include/hw/hyperv/vmbus.h index f98bea3888d..8ea660dd8e6 100644 --- a/include/hw/hyperv/vmbus.h +++ b/include/hw/hyperv/vmbus.h @@ -223,7 +223,4 @@ int vmbus_map_sgl(VMBusChanReq *req, DMADirection dir, = struct iovec *iov, void vmbus_unmap_sgl(VMBusChanReq *req, DMADirection dir, struct iovec *io= v, unsigned iov_cnt, size_t accessed); =20 -void vmbus_save_req(QEMUFile *f, VMBusChanReq *req); -void *vmbus_load_req(QEMUFile *f, VMBusDevice *dev, uint32_t size); - #endif diff --git a/hw/hyperv/vmbus.c b/hw/hyperv/vmbus.c index c9887d5a7bc..18d3c3b9240 100644 --- a/hw/hyperv/vmbus.c +++ b/hw/hyperv/vmbus.c @@ -1311,65 +1311,6 @@ static const VMStateDescription vmstate_vmbus_chan_r= eq =3D { } }; =20 -void vmbus_save_req(QEMUFile *f, VMBusChanReq *req) -{ - VMBusChanReqSave req_save; - - req_save.chan_idx =3D req->chan->subchan_idx; - req_save.pkt_type =3D req->pkt_type; - req_save.msglen =3D req->msglen; - req_save.msg =3D req->msg; - req_save.transaction_id =3D req->transaction_id; - req_save.need_comp =3D req->need_comp; - req_save.num =3D req->sgl.nsg; - req_save.sgl =3D g_memdup(req->sgl.sg, - req_save.num * sizeof(ScatterGatherEntry)); - - vmstate_save_state(f, &vmstate_vmbus_chan_req, &req_save, NULL); - - g_free(req_save.sgl); -} - -void *vmbus_load_req(QEMUFile *f, VMBusDevice *dev, uint32_t size) -{ - VMBusChanReqSave req_save; - VMBusChanReq *req =3D NULL; - VMBusChannel *chan =3D NULL; - uint32_t i; - - vmstate_load_state(f, &vmstate_vmbus_chan_req, &req_save, 0); - - if (req_save.chan_idx >=3D dev->num_channels) { - error_report("%s: %u(chan_idx) > %u(num_channels)", __func__, - req_save.chan_idx, dev->num_channels); - goto out; - } - chan =3D &dev->channels[req_save.chan_idx]; - - if (vmbus_channel_reserve(chan, 0, req_save.msglen)) { - goto out; - } - - req =3D vmbus_alloc_req(chan, size, req_save.pkt_type, req_save.msglen, - req_save.transaction_id, req_save.need_comp); - if (req_save.msglen) { - memcpy(req->msg, req_save.msg, req_save.msglen); - } - - for (i =3D 0; i < req_save.num; i++) { - qemu_sglist_add(&req->sgl, req_save.sgl[i].base, req_save.sgl[i].l= en); - } - -out: - if (req_save.msglen) { - g_free(req_save.msg); - } - if (req_save.num) { - g_free(req_save.sgl); - } - return req; -} - static void channel_event_cb(EventNotifier *e) { VMBusChannel *chan =3D container_of(e, VMBusChannel, notifier); --=20 2.31.1