From nobody Mon Feb 9 14:33:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1630667388; cv=none; d=zohomail.com; s=zohoarc; b=kEyELiJ+3Mzb9HNlUZQQADqE6ipecq6VfCJOAFrJxYqNTcQcnhQZ1bV5PvyD8+xe5bncuAGVE9Ybk29MW77nVXCgzhpjKQV/LOmbbMcdj5ydyOd7ulxzdv//zH0q4RbstKeMMPI5DdSwhtuKDJqmGEJdiXTgaMQJoYMGi0XPtRE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1630667388; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=i6HJ8MqhTy0s+GzLLhKT2UPzz5+277m7r3JgXnumMB8=; b=LQF48ZPnfqC8yZTWnS7LTrffPyrgyG3Z+htqxOOW9Ih8O2eBxXpMNCHExWuAYwtBQoGK1qQ3Iy8f8ruAtiP6aAUne1sd2qcfEYmxYbmdpps7YwPdxp1Mx5BKq1pc+9xFWYvgpupBj3zZhomM3yMkW1UtdOq6J3/oWF0HPhr8D/k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1630667388733871.8404411366822; Fri, 3 Sep 2021 04:09:48 -0700 (PDT) Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-320-iVPJYkxdNkiN8L239RxQwQ-1; Fri, 03 Sep 2021 07:09:46 -0400 Received: by mail-wr1-f72.google.com with SMTP id h14-20020a056000000e00b001575b00eb08so1448655wrx.13 for ; Fri, 03 Sep 2021 04:09:45 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id t14sm3887073wmi.12.2021.09.03.04.09.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 04:09:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630667387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i6HJ8MqhTy0s+GzLLhKT2UPzz5+277m7r3JgXnumMB8=; b=KHcU0t9jkyTCKWJS5kIuEewShI2TAyraHjByWWIgZQCM/WZtZaNqN9n5AHkdsZJh/TlNBM mXN3ENBf0mu7UIXhl0smDk7iRmgZMHK9enrbE6qn/2kQMYO2mYeV73Qkb+wAt1ymAhkHYI P/u3E3ti32yUBj7rivQ5GnQym7sB/OQ= X-MC-Unique: iVPJYkxdNkiN8L239RxQwQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=i6HJ8MqhTy0s+GzLLhKT2UPzz5+277m7r3JgXnumMB8=; b=cliZTRno0xVdATBVbzPfsHFNDnbiCXlFUQzwnlVpdrDsR5q6Q7tpZ6gMr4oqDr4w4K Gooks2WQEbmALVqr51nCwn61xFvt21RVxbHD8zj7v8G3t/5nw/Ssj6+oHFU7pkyl+5fP oJ3MJMD4CFHIyEBL1oA0PWhXo7fGm1Vr5MMx9eRLw5h6k6Er6NDsC/ub0zaXjp8MvLgF M325pKHN5DNzlTLLAOQsmJ6WouEgcZN8YldjJPwnfbJuIK6t/2jNgFeqJtXuwDCXzVZd SkaxSoixhDk00WYVbiM1b/alp0PiGv1njzQrHGmPLlsqjIxwmFXWm6ROHc3Qps50iupf 2T8g== X-Gm-Message-State: AOAM530DxUAOFyWaORLas3HDmQkMI83k6yrt7GzlkiX5llUO9/oOqTJO 1aza0/TQ64biGzAMWoIwvYNF6Ok/OxZEHpJykP9gnmgPvJoDeZ+6HoWac5aqx30ph/FJOa5niDC l6GQ7Jy70qYBycQ== X-Received: by 2002:adf:d1a8:: with SMTP id w8mr3454894wrc.306.1630667384537; Fri, 03 Sep 2021 04:09:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzTWWNvgUfXwGCxUu6tWBFBNL+R3tBdmQts4xFcP/prwWKpnKH5frCHZXk2WgxNT0N9oeyPWA== X-Received: by 2002:adf:d1a8:: with SMTP id w8mr3454844wrc.306.1630667384303; Fri, 03 Sep 2021 04:09:44 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Hanna Reitz , Igor Mammedov , Laurent Vivier , Alexandre Iooss , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Michael Roth , Zhang Chen , Shannon Zhao , Richard Henderson , Alex Williamson , Eduardo Habkost , Markus Armbruster , Eric Blake , Stefan Weil , John Snow , Mahmoud Mandour , Li Zhijian , Marcel Apfelbaum , qemu-block@nongnu.org, Helge Deller , "Michael S. Tsirkin" , David Gibson , Peter Xu , "Gonglei (Arei)" , Gerd Hoffmann , Fam Zheng , Jason Wang , Vladimir Sementsov-Ogievskiy , Christian Schoenebeck , Kevin Wolf , Yuval Shaia , Paolo Bonzini , Peter Maydell , qemu-arm@nongnu.org, Thomas Huth , Laurent Vivier , Greg Kurz , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-ppc@nongnu.org, David Hildenbrand Subject: [PATCH 28/28] checkpatch: Do not allow deprecated g_memdup() Date: Fri, 3 Sep 2021 13:07:02 +0200 Message-Id: <20210903110702.588291-29-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210903110702.588291-1-philmd@redhat.com> References: <20210903110702.588291-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1630667390173100001 g_memdup() is insecure and as been deprecated in GLib 2.68. QEMU provides the safely equivalent g_memdup2_qemu() wrapper. Do not allow more g_memdup() calls in the repository, provide a hint to use g_memdup2_qemu(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- scripts/checkpatch.pl | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index cb8eff233e0..4ce9d753492 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2850,6 +2850,11 @@ sub process { WARN("consider using g_path_get_$1() in preference to g_strdup($1())\n"= . $herecurr); } =20 +# enforce g_memdup2_qemu() over g_memdup() + if ($line =3D~ /\bg_memdup\s*\(/) { + ERROR("use g_memdup2_qemu() instead of unsafe g_memdup()\n" . $herecurr= ); + } + # recommend qemu_strto* over strto* for numeric conversions if ($line =3D~ /\b(strto[^kd].*?)\s*\(/) { ERROR("consider using qemu_$1 in preference to $1\n" . $herecurr); --=20 2.31.1