From nobody Mon Feb 9 12:26:39 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1630667314; cv=none; d=zohomail.com; s=zohoarc; b=gECJtieUDEBSA+DxBUTk/eu1Do8USf1vWreAP/N9JCH+XE6AYuMGKq0Nnxg3kTeotzBsNRmgQ/+6WQlWj8oBBV7xtCZ0JmyXG/QhQhhqzca3oOO/D+FkB2ErCCD6nVSdqI3XEhqmOaJ9XHPPrY/O8KwcFOT6pHT1sSQtEOKRlpU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1630667314; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=dJwik153XkNmqJfLX2OaJbitNFOzhpORupSCbSGdFBs=; b=Ypdv09knSiUWHUnWxfB9HXzi1kTbBzZ5O2RosZpgZR0VtJs8gt+VB3I443YWLqXePK6d3KBVBtlnzNshgeN8MXcdApR+9IUH5xQ0Ji4V+YLA1NIzdH2UuhTAdF6JZG6KhGfFrufs64kbBXmayeCiSG+EcpFpBsCidU9/qtWUTE0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1630667314458532.6273649696454; Fri, 3 Sep 2021 04:08:34 -0700 (PDT) Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-558-ziSFJ3DtPmOYF0-VW8b9kw-1; Fri, 03 Sep 2021 07:08:32 -0400 Received: by mail-wm1-f69.google.com with SMTP id r4-20020a1c4404000000b002e728beb9fbso2512287wma.9 for ; Fri, 03 Sep 2021 04:08:32 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id x21sm890930wmc.14.2021.09.03.04.08.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 04:08:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630667313; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dJwik153XkNmqJfLX2OaJbitNFOzhpORupSCbSGdFBs=; b=NGgzPgLHKoCi0bpqfquLrOdXhdDyru2xGS1O+5YAB1dmTXesfuTWHLalxw9gEXl/TC1NVu uWSgIHIyeQdThjncQzyQIzC/ge0SFbKYR03bvFrne9B9WsIwW65wYBYeqCN24WumrTqCz1 Jy8pVe/zs+O3/+9wpIw/dA0rmkaT6Lc= X-MC-Unique: ziSFJ3DtPmOYF0-VW8b9kw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dJwik153XkNmqJfLX2OaJbitNFOzhpORupSCbSGdFBs=; b=AUPkJ6W5ml0sVPfpVcr7F8oIe+OwxNHSLW+SZO1bZbuIvna9QzmdRPMsmBK9mCI5Nm IH+YiT7LPe6e3+fAEeXcTZ2qaAE1yf7pNBApqCDJuJ30Ze3kMsbZTLotvuTy5hOhAcK0 J9EbmaBMot7Hte+FjLqJspjN9rivNWYWJ730pelqj82n/aNKxFr+uc0jFZttaY8totId GjmKcDVMiza2VLdBcqKR/I0Dge8A4LJfidAvLEKCyjxjeUs7Q+KQzzsJCGPJv0XrH3Ay ghKU+DhWhW98ZzZYeYuscXbA6TqyTE8jsoYfTsAGcCX4MMdMf/pB74s1k/V1xJ9ATzXz v2hQ== X-Gm-Message-State: AOAM531k8IDw7Qw1EtygPROQkwnx/3gD8u/si6gXtDPi84XqE3N2nZc1 fH9x1h1xL2UhB7LGjBI6Zc+8ipXkk6aLC0fm5ev7oxBa99U6prWHEqmnLS/NVty6EOvfLP+K/Aj S5YBCHMw0v54TEA== X-Received: by 2002:a1c:3587:: with SMTP id c129mr7583822wma.57.1630667311141; Fri, 03 Sep 2021 04:08:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw5r0XeeX6oDBAmIiFbFCHjKsXYnfVoM/it+dWZcDkZmIgH65YEMVRXHS9DXEpfLuhGguK5bg== X-Received: by 2002:a1c:3587:: with SMTP id c129mr7583780wma.57.1630667310694; Fri, 03 Sep 2021 04:08:30 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Hanna Reitz , Igor Mammedov , Laurent Vivier , Alexandre Iooss , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Michael Roth , Zhang Chen , Shannon Zhao , Richard Henderson , Alex Williamson , Eduardo Habkost , Markus Armbruster , Eric Blake , Stefan Weil , John Snow , Mahmoud Mandour , Li Zhijian , Marcel Apfelbaum , qemu-block@nongnu.org, Helge Deller , "Michael S. Tsirkin" , David Gibson , Peter Xu , "Gonglei (Arei)" , Gerd Hoffmann , Fam Zheng , Jason Wang , Vladimir Sementsov-Ogievskiy , Christian Schoenebeck , Kevin Wolf , Yuval Shaia , Paolo Bonzini , Peter Maydell , qemu-arm@nongnu.org, Thomas Huth , Laurent Vivier , Greg Kurz , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-ppc@nongnu.org, David Hildenbrand Subject: [PATCH 15/28] hw/scsi/mptsas: Replace g_memdup() by g_memdup2_qemu() Date: Fri, 3 Sep 2021 13:06:49 +0200 Message-Id: <20210903110702.588291-16-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210903110702.588291-1-philmd@redhat.com> References: <20210903110702.588291-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1630667315935100001 Per https://discourse.gnome.org/t/port-your-module-from-g-memdup-to-g-memdu= p2-now/5538 The old API took the size of the memory to duplicate as a guint, whereas most memory functions take memory sizes as a gsize. This made it easy to accidentally pass a gsize to g_memdup(). For large values, that would lead to a silent truncation of the size from 64 to 32 bits, and result in a heap area being returned which is significantly smaller than what the caller expects. This can likely be exploited in various modules to cause a heap buffer overflow. Replace g_memdup() by the safer g_memdup2_qemu() wrapper. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/scsi/mptsas.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/scsi/mptsas.c b/hw/scsi/mptsas.c index db3219e7d20..d05735d3e11 100644 --- a/hw/scsi/mptsas.c +++ b/hw/scsi/mptsas.c @@ -449,7 +449,8 @@ static void mptsas_process_scsi_task_mgmt(MPTSASState *= s, MPIMsgSCSITaskMgmt *re } else { MPTSASCancelNotifier *notifier; =20 - reply_async =3D g_memdup(&reply, sizeof(MPIMsgSCSITaskMgmt= Reply)); + reply_async =3D g_memdup2_qemu(&reply, + sizeof(MPIMsgSCSITaskMgmtRepl= y)); reply_async->IOCLogInfo =3D INT_MAX; =20 count =3D 1; @@ -476,7 +477,7 @@ static void mptsas_process_scsi_task_mgmt(MPTSASState *= s, MPIMsgSCSITaskMgmt *re goto out; } =20 - reply_async =3D g_memdup(&reply, sizeof(MPIMsgSCSITaskMgmtReply)); + reply_async =3D g_memdup2_qemu(&reply, sizeof(MPIMsgSCSITaskMgmtRe= ply)); reply_async->IOCLogInfo =3D INT_MAX; =20 count =3D 0; --=20 2.31.1