From nobody Mon Feb 9 01:30:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1630587805; cv=none; d=zohomail.com; s=zohoarc; b=b4D4a7tpek+Vpj0/AFUWDW0xtVdyPFPU16yQQ7FRZahA7pQEdbtmWwfKoQ6t+4B5FwHUPI0YI6YPCNvqCZ8D7oTPSKJMlNeB1W/zZjFmSgS+DbmXvj7O5CrXA3PMFe++8o4Wr9ILTYLusntkP927yqJSSxJWa3XevFZH6cxyGRI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1630587805; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6rqA3K9F3FH10/7wD1F+o+9rwIXYOs1faRHBea7/k5M=; b=DuW5tuvfNOkDAvNkML7zVBmP71VAlIRjGom4K4avHSbf6EIy3L/ClscIQWpHv8Eyw7IBJGkKzM+qRqQPgxTPseQaXrdZtQwQ0Paq/2Uz6INKIa0ALpiMJWuYhmAvW1W//ueml1boJFTd4I6JnIYOy5AlTDxSnBlhIiqH+MWYo30= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1630587805654169.4220133212673; Thu, 2 Sep 2021 06:03:25 -0700 (PDT) Received: from localhost ([::1]:59776 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLmNI-0007i4-FL for importer@patchew.org; Thu, 02 Sep 2021 09:03:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37862) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLm9u-00058n-P9 for qemu-devel@nongnu.org; Thu, 02 Sep 2021 08:49:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:20018) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLm9s-00073h-BA for qemu-devel@nongnu.org; Thu, 02 Sep 2021 08:49:34 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-518-_xjFe40CO5yi5l7rmeo7FA-1; Thu, 02 Sep 2021 08:49:30 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4C82E1083E8F; Thu, 2 Sep 2021 12:49:29 +0000 (UTC) Received: from thuth.com (unknown [10.39.194.85]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8535610016F2; Thu, 2 Sep 2021 12:49:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630586971; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6rqA3K9F3FH10/7wD1F+o+9rwIXYOs1faRHBea7/k5M=; b=SW4byJSUlW2NRNu7xeyQxcza4rUdbLq5s7rwJTwLpWhcIHom9oSQxVsI2/23E5eV3e6Bms iacVL6r7Jbvrq4LZ4gqixz8snYjcfRZy6bzAqFQcMNKh/Q+eRCc7RyZ5PkM1HJ3IdG4SuT /Mvj9MBokormt0ZzdwEv6QoB6wXRfYY= X-MC-Unique: _xjFe40CO5yi5l7rmeo7FA-1 From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 08/13] meson.build: Don't use internal libfdt if the user requested the system libfdt Date: Thu, 2 Sep 2021 14:49:06 +0200 Message-Id: <20210902124911.822423-9-thuth@redhat.com> In-Reply-To: <20210902124911.822423-1-thuth@redhat.com> References: <20210902124911.822423-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.39, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1630587814903100001 If the users ran configure with --enable-libfdt=3Dsystem, they likely did that on purpose. We should not silently fall back to the internal libfdt if the system libfdt is not usable, but report the problem with a proper message instead. Message-Id: <20210827120901.150276-3-thuth@redhat.com> Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau Signed-off-by: Thomas Huth --- meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/meson.build b/meson.build index 6f7177428e..ecfdce921c 100644 --- a/meson.build +++ b/meson.build @@ -1912,6 +1912,8 @@ if have_system int main(void) { fdt_check_full(NULL, 0); return 0; }''', dependencies: fdt) fdt_opt =3D 'system' + elif fdt_opt =3D=3D 'system' + error('system libfdt requested, but it is too old (1.5.1 or newer r= equired)') elif have_internal fdt_opt =3D 'internal' else --=20 2.27.0