From nobody Thu May 2 17:56:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=bytedance.com ARC-Seal: i=1; a=rsa-sha256; t=1630330949; cv=none; d=zohomail.com; s=zohoarc; b=nqPXl22JPOmBbmBq1lpP7PDIYtN2As3SfAkkcChuIIShRr7MtQzkl9O6/GaNJDkauXtA1SOR4awmtdiFujcvB/lmeHNw9eb9NZBsqzyuTcg7lgWqeafuSexBIevEA4+ic+GS2Y31xL9S02Rx7CW92nxv1EABTWj4x3SiTZW7L8o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1630330949; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=Ct5RJc01HaK8EgOL3LHOcTfGuS/g9iYfsuhyr6npBYs=; b=XFeZNw14traUEsNHR1Zuvp+vPLGmtnTZx4zj4rc0Tuq3VqcLDRLzsFGyM4p+/laQoZVDQ8bn91rfY9O08qLrug0nqRkkRHKjxOMTE0MauTlGovYQ84wk1HiPWT1Ysz6G5rt1KLCrcavC2zRV5d4Cf2iFSCYSDL9E4CvmicEhG0M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1630330948927969.0829615565948; Mon, 30 Aug 2021 06:42:28 -0700 (PDT) Received: from localhost ([::1]:55356 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mKhYR-0005XP-T2 for importer@patchew.org; Mon, 30 Aug 2021 09:42:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48906) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKg5X-0001bu-FF for qemu-devel@nongnu.org; Mon, 30 Aug 2021 08:08:31 -0400 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]:33590) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mKg5T-0006DE-6r for qemu-devel@nongnu.org; Mon, 30 Aug 2021 08:08:29 -0400 Received: by mail-pg1-x532.google.com with SMTP id c17so13266663pgc.0 for ; Mon, 30 Aug 2021 05:08:25 -0700 (PDT) Received: from C02FR03AMD6V.bytedance.net ([139.177.225.229]) by smtp.gmail.com with ESMTPSA id x14sm14388649pfa.127.2021.08.30.05.08.21 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Aug 2021 05:08:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Ct5RJc01HaK8EgOL3LHOcTfGuS/g9iYfsuhyr6npBYs=; b=Wtkyh9Rw812I2hlaxBYvgIh9K14E59T+YJ2z/MteGE8v8hbmuS30gQRgnx85+n9Ukk /BiyHHh/weHiTnrPY4CM7gfZ0oV9raJ1wslmCxiQx88I5D0svuFBTykB+HqM13CIWMeh t20NyGwKLi0hM7V5yRViKF30jQFqPnkLqGnh0AKbDcfr3YIeNuS+LIi4tuJzO7Cw2hNu vT6oxaluxsTCH825YcpXPMjt3S0M0FWqCLiZtSOrkMAA41ALx/JtKUVDM5Q7hw/k0uAb oi3WBMtftfaNCpasr0dhvjd1JRAzYbPooEm4ZUy6u+B3hUGddjVt2mGeQ3tcksHN7sLd Y8jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Ct5RJc01HaK8EgOL3LHOcTfGuS/g9iYfsuhyr6npBYs=; b=PomKp8kKQEgwGPvLltQJ8R8MYWNYigeIfdn+T6iX1xv3bhyvDE4Ye/plKfb5A7tTb4 1QkZOnGEimgOnXqu3ak3PoBmin8p90sb/WN/aUip/r2dnT5cDw47qRW3GFsZz2VLjYmu qU570tBShBmvddzIHcPB7M+fphWgI6AtnLQa9WaZk7QCSBthYV5DS8rDImT9MaxamDtv Kz0LIIJvASndN/1I4Yer8ZyoTpDCPf7sfeIZmxpgIMtSJG98OPSRp/NqCfggnjFsQjhN EnCjUhfjwvZfw8axEWclDCf3Vb9OPSPKGnRa5pV8OUwHHk/0aIZYIm+lSbu3Y9f9NdDf g99g== X-Gm-Message-State: AOAM532yFFS3JXZmyirL6pvQC+l/IYI8UowcDHFutWb5dx0niu/p0+3Y juWZAmuGuZOSC03IGgsktv/JnndX4U9ZXA== X-Google-Smtp-Source: ABdhPJxYHyQqF0EDkMVDrTO3WG6Pc+y/GzXNlRnETwuG6jYvFPy4HNT8Yvr41sEtsXspByB/wGnSAA== X-Received: by 2002:a63:de01:: with SMTP id f1mr20959019pgg.377.1630325303559; Mon, 30 Aug 2021 05:08:23 -0700 (PDT) From: Yuwei Zhang To: qemu-devel@nongnu.org Subject: [PATCH] hw/virtio: fix crash on kill then start vhost backend Date: Mon, 30 Aug 2021 20:08:18 +0800 Message-Id: <20210830120818.40489-1-zhangyuwei.9149@bytedance.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::532; envelope-from=zhangyuwei.9149@bytedance.com; helo=mail-pg1-x532.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 30 Aug 2021 09:40:47 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhangyuwei.9149@bytedance.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @bytedance-com.20150623.gappssmtp.com) X-ZM-MESSAGEID: 1630330951394100001 Content-Type: text/plain; charset="utf-8" Add flatview update in vhost_user_cleanup() to avoid access unmapped memory which may cause a qemu crash. Signed-off-by: Yuwei Zhang --- hw/virtio/vhost-user.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index 2407836fac..b6e76985b7 100644 --- a/hw/virtio/vhost-user.c +++ b/hw/virtio/vhost-user.c @@ -2423,6 +2423,7 @@ void vhost_user_cleanup(VhostUserState *user) return; } =20 + memory_region_transaction_begin(); for (i =3D 0; i < VIRTIO_QUEUE_MAX; i++) { if (user->notifier[i].addr) { object_unparent(OBJECT(&user->notifier[i].mr)); @@ -2430,6 +2431,7 @@ void vhost_user_cleanup(VhostUserState *user) user->notifier[i].addr =3D NULL; } } + memory_region_transaction_commit(); user->chr =3D NULL; } =20 --=20 2.11.0