[PATCH] hw/virtio: fix crash on kill then start vhost backend

Yuwei Zhang posted 1 patch 2 years, 7 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210830120818.40489-1-zhangyuwei.9149@bytedance.com
Maintainers: "Michael S. Tsirkin" <mst@redhat.com>
hw/virtio/vhost-user.c | 2 ++
1 file changed, 2 insertions(+)
[PATCH] hw/virtio: fix crash on kill then start vhost backend
Posted by Yuwei Zhang 2 years, 7 months ago
Add flatview update in vhost_user_cleanup() to avoid access
unmapped memory which may cause a qemu crash.

Signed-off-by: Yuwei Zhang <zhangyuwei.9149@bytedance.com>
---
 hw/virtio/vhost-user.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
index 2407836fac..b6e76985b7 100644
--- a/hw/virtio/vhost-user.c
+++ b/hw/virtio/vhost-user.c
@@ -2423,6 +2423,7 @@ void vhost_user_cleanup(VhostUserState *user)
         return;
     }
 
+    memory_region_transaction_begin();
     for (i = 0; i < VIRTIO_QUEUE_MAX; i++) {
         if (user->notifier[i].addr) {
             object_unparent(OBJECT(&user->notifier[i].mr));
@@ -2430,6 +2431,7 @@ void vhost_user_cleanup(VhostUserState *user)
             user->notifier[i].addr = NULL;
         }
     }
+    memory_region_transaction_commit();
     user->chr = NULL;
 }
 
-- 
2.11.0