From nobody Thu May 2 09:21:02 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1630066297323423.6525080254653; Fri, 27 Aug 2021 05:11:37 -0700 (PDT) Received: from localhost ([::1]:54654 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJahr-0002YO-LJ for importer@patchew.org; Fri, 27 Aug 2021 08:11:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45322) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJafd-0007vz-8d for qemu-devel@nongnu.org; Fri, 27 Aug 2021 08:09:17 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:32925) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJafa-0004bB-Cq for qemu-devel@nongnu.org; Fri, 27 Aug 2021 08:09:16 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-360-3AccST65PYayhUysvWHvGQ-1; Fri, 27 Aug 2021 08:09:12 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F08611853026; Fri, 27 Aug 2021 12:09:10 +0000 (UTC) Received: from thuth.com (unknown [10.40.192.229]) by smtp.corp.redhat.com (Postfix) with ESMTP id 364135F724; Fri, 27 Aug 2021 12:09:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630066153; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PXN2XqI6Yrf3sKmT4TN2bu3GayaHLDeqAznihBOaJXs=; b=NyCg+JJ2BSc4Hdy7+fTDWNHZxt+Tnp3ieUm0BE/8jO6zCLBVGM0chzHd7iJ8voNi45LdCQ Bp91M1nhh5zLJ+DOwTl/biMPVgLQEEpuVYp2w3SHUaftVEvtdgUlvB04xgOXuvWXrdSYUM O1eoF/w+0WkAcOzbgabqKshgFhP8mjk= X-MC-Unique: 3AccST65PYayhUysvWHvGQ-1 From: Thomas Huth To: David Gibson , qemu-devel@nongnu.org Subject: [PATCH 1/3] meson.build: Fix the check for a usable libfdt Date: Fri, 27 Aug 2021 14:08:59 +0200 Message-Id: <20210827120901.150276-2-thuth@redhat.com> In-Reply-To: <20210827120901.150276-1-thuth@redhat.com> References: <20210827120901.150276-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.743, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org, qemu-ppc@nongnu.org, John Paul Adrian Glaubitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1630066299353100001 Content-Type: text/plain; charset="utf-8" The check for libfdt currently has a flaw: If there is a system libfdt, the meson.build code initialized the fdt variable with fdt =3D cc.find_library(= ...). However, if this libfdt is too old and there is no internal dtc module available, it continues with "fdt" pointing to the old and unusable version. The check later in the file that tries to detect whether libfdt is necessary then fails to trigger: if not fdt.found() and fdt_required.length() > 0 error('fdt not available but required by targets ' + ', '.join(fdt_requir= ed)) endif The build fails then during compilation instead, which is of course bad since this is quite confusing and already wasted quite some time of the use= r. Thus if libfdt is not usable, we should unset the "fdt" variable immediately again, so that the build already fails during the configuration phase. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/255 Signed-off-by: Thomas Huth If the system has Reviewed-by: Marc-Andr=C3=A9 Lureau --- meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/meson.build b/meson.build index 0b555197c3..ee156ff0a5 100644 --- a/meson.build +++ b/meson.build @@ -1916,6 +1916,7 @@ if have_system fdt_opt =3D 'internal' else fdt_opt =3D 'disabled' + fdt =3D not_found endif endif if fdt_opt =3D=3D 'internal' --=20 2.27.0 From nobody Thu May 2 09:21:02 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1630066299882524.7471674011773; Fri, 27 Aug 2021 05:11:39 -0700 (PDT) Received: from localhost ([::1]:54902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJahu-0002jZ-Tj for importer@patchew.org; Fri, 27 Aug 2021 08:11:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45400) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJafg-00082r-GV for qemu-devel@nongnu.org; Fri, 27 Aug 2021 08:09:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:24900) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJafe-0004eU-Vo for qemu-devel@nongnu.org; Fri, 27 Aug 2021 08:09:20 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-46-LlufIBm7MWi1NEmu0YqNWg-1; Fri, 27 Aug 2021 08:09:15 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 162481082925; Fri, 27 Aug 2021 12:09:14 +0000 (UTC) Received: from thuth.com (unknown [10.40.192.229]) by smtp.corp.redhat.com (Postfix) with ESMTP id C33B368D97; Fri, 27 Aug 2021 12:09:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630066158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RfZfF21nSXQrRkrJHOwZUW8yGVvBIA0k8gN9gMcChCw=; b=K3oNLRkf7cRMU+qeQK9ocmtlaifhMKk6WupWR9EcqoOQ7uFDBeUhPrLqAUOf4KS9z1b8MT 9VbA4zVQL1sySSpWntb2fKoNOSXEr36HK83iA3QYz5lZgEOUZFmygS4HHM+DHTJ/7c+ucg VLqi0TBFw+FOCFfLkcSIajKv+6yUrfc= X-MC-Unique: LlufIBm7MWi1NEmu0YqNWg-1 From: Thomas Huth To: David Gibson , qemu-devel@nongnu.org Subject: [PATCH 2/3] meson.build: Don't use internal libfdt if the user requested the system libfdt Date: Fri, 27 Aug 2021 14:09:00 +0200 Message-Id: <20210827120901.150276-3-thuth@redhat.com> In-Reply-To: <20210827120901.150276-1-thuth@redhat.com> References: <20210827120901.150276-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.743, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org, qemu-ppc@nongnu.org, John Paul Adrian Glaubitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1630066300832100003 Content-Type: text/plain; charset="utf-8" If the users ran configure with --enable-libfdt=3Dsystem, they likely did that on purpose. We should not silently fall back to the internal libfdt if the system libfdt is not usable, but report the problem with a proper message instead. Signed-off-by: Thomas Huth Reviewed-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/meson.build b/meson.build index ee156ff0a5..bc6a52b909 100644 --- a/meson.build +++ b/meson.build @@ -1912,6 +1912,8 @@ if have_system int main(void) { fdt_check_full(NULL, 0); return 0; }''', dependencies: fdt) fdt_opt =3D 'system' + elif fdt_opt =3D=3D 'system' + error('system libfdt requested, but it is too old (1.5.1 or newer r= equired)') elif have_internal fdt_opt =3D 'internal' else --=20 2.27.0 From nobody Thu May 2 09:21:02 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1630066439922936.4911017084369; Fri, 27 Aug 2021 05:13:59 -0700 (PDT) Received: from localhost ([::1]:59206 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJakA-0005qE-Tv for importer@patchew.org; Fri, 27 Aug 2021 08:13:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45458) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJafk-0008Gm-K9 for qemu-devel@nongnu.org; Fri, 27 Aug 2021 08:09:26 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:48740) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJafj-0004gv-3n for qemu-devel@nongnu.org; Fri, 27 Aug 2021 08:09:24 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-307-SkESUGPAOXGO2OCHYylVWQ-1; Fri, 27 Aug 2021 08:09:18 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8A0A31082927; Fri, 27 Aug 2021 12:09:17 +0000 (UTC) Received: from thuth.com (unknown [10.40.192.229]) by smtp.corp.redhat.com (Postfix) with ESMTP id D68895FC22; Fri, 27 Aug 2021 12:09:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630066162; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Va1kjsBc/tr5Ri5nGD7xsIm096GrN5gBEBaqydVcVC8=; b=LcohCf03oW4eTnnwqRzj+H3I7FLc90p1s7WGbxzvA0O9Dw9A6hyY8Vjh63tyuRmkYf/Vhl gUMU7v/g0gXwrA+S0ZLPySL4w0NiHjXc5emGQrNTKHIV6C8x7JJNsAWmjfYANTrxqxZXmy 6xTTFCPJndpOb6aJccx/g6vSa5dJN70= X-MC-Unique: SkESUGPAOXGO2OCHYylVWQ-1 From: Thomas Huth To: David Gibson , qemu-devel@nongnu.org Subject: [PATCH 3/3] dtc: Update to version 1.6.1 Date: Fri, 27 Aug 2021 14:09:01 +0200 Message-Id: <20210827120901.150276-4-thuth@redhat.com> In-Reply-To: <20210827120901.150276-1-thuth@redhat.com> References: <20210827120901.150276-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.743, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org, qemu-ppc@nongnu.org, John Paul Adrian Glaubitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1630066442042100001 Content-Type: text/plain; charset="utf-8" The dtc submodule is currently pointing to non-release commit. It's nicer if submodules point to release versions instead and since dtc 1.6.1 is available now, let's update to that version. Signed-off-by: Thomas Huth Acked-by: David Gibson Acked-by: Greg Kurz Reviewed-by: Marc-Andr=C3=A9 Lureau --- dtc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dtc b/dtc index 85e5d83984..b6910bec11 160000 --- a/dtc +++ b/dtc @@ -1 +1 @@ -Subproject commit 85e5d839847af54efab170f2b1331b2a6421e647 +Subproject commit b6910bec11614980a21e46fbccc35934b671bd81 --=20 2.27.0 From nobody Thu May 2 09:21:02 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1630077602212474.9476449652724; Fri, 27 Aug 2021 08:20:02 -0700 (PDT) Received: from localhost ([::1]:46494 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJdeD-0004AO-6u for importer@patchew.org; Fri, 27 Aug 2021 11:20:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJdcH-0001Yx-DJ for qemu-devel@nongnu.org; Fri, 27 Aug 2021 11:18:01 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:53084) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJdcC-0002IG-Om for qemu-devel@nongnu.org; Fri, 27 Aug 2021 11:18:00 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-491-P7c2GKnaNi2pKCHLf_tAhw-1; Fri, 27 Aug 2021 11:17:54 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AF6F4107ACF5; Fri, 27 Aug 2021 15:17:53 +0000 (UTC) Received: from thuth.com (unknown [10.40.192.229]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2EEE719C59; Fri, 27 Aug 2021 15:17:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630077475; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L8XgRF1kt+KDBalRdVP8rge/CVuXZFXS+KX+MTrZpn4=; b=PSbNn+B/oIxtLa6yiDiSJN1Vz+RpLT0sFTbGR7i5WdX5fKEK3TbGPp41eTErm+j+BdmhkH D759W3q1ofesgvtvt2t9uKGvKtQ4XKzaYUcctjvsNApMVOkgsod4jw6tBt1KV0GP1gFCk9 OdWNAS2coBgB5c/XUoM8Ay5QJMHa3SA= X-MC-Unique: P7c2GKnaNi2pKCHLf_tAhw-1 From: Thomas Huth To: David Gibson , qemu-devel@nongnu.org Subject: [PATCH 4/3] gitlab-ci: Don't try to use the system libfdt in the debian job Date: Fri, 27 Aug 2021 17:17:49 +0200 Message-Id: <20210827151749.179112-1-thuth@redhat.com> In-Reply-To: <20210827120901.150276-1-thuth@redhat.com> References: <20210827120901.150276-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.743, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org, qemu-ppc@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1630077602903100001 Content-Type: text/plain; charset="utf-8" libfdt in Debian is too old to be usable for QEMU. So far we were silently falling back to the internal dtc submodule, but since this is wrong, let's remove the --enable-fdt=3Dsystem switch here now. Signed-off-by: Thomas Huth Reviewed-by: Marc-Andr=C3=A9 Lureau --- Sorry, I just noticed this after sending out the first three patches alrea= dy .gitlab-ci.d/buildtest.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index 903ee65f32..f0eb5f6286 100644 --- a/.gitlab-ci.d/buildtest.yml +++ b/.gitlab-ci.d/buildtest.yml @@ -74,7 +74,6 @@ build-system-debian: job: amd64-debian-container variables: IMAGE: debian-amd64 - CONFIGURE_ARGS: --enable-fdt=3Dsystem TARGETS: arm-softmmu avr-softmmu i386-softmmu mipsel-softmmu riscv64-softmmu sh4eb-softmmu sparc-softmmu xtensaeb-softmmu MAKE_CHECK_ARGS: check-build --=20 2.27.0