From nobody Mon Feb 9 20:31:30 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1630049133780585.0477551033903; Fri, 27 Aug 2021 00:25:33 -0700 (PDT) Received: from localhost ([::1]:55924 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJWF2-0004PQ-An for importer@patchew.org; Fri, 27 Aug 2021 03:25:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52160) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJW03-0000wa-KU; Fri, 27 Aug 2021 03:10:03 -0400 Received: from bilbo.ozlabs.org ([203.11.71.1]:39481 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJW01-0007QW-2S; Fri, 27 Aug 2021 03:10:02 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 4GwrSZ2f6xz9sWc; Fri, 27 Aug 2021 17:09:50 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1630048190; bh=3HAnMry8QrGfAtdyPyBFYVzTe6YycbOf8WcqDPtwUDg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UGElfXuIZ6SCtEvFsWtLU3CaYpvIpZu3rOc/AeuahwCjggxuAoWnPObyys05cZbB/ oBjnq3PcxylFolv45xt7y4W1rZI6W7rcmgfCIsDO+HefQOsOWA5sWkiVhdFDrtgwSo CRkUvfWJZ/iGe1ldJk9lZLnz/YQMKT5VsokDcgxo= From: David Gibson To: peter.maydell@linaro.org, groug@kaod.org Subject: [PULL 09/18] ppc/pnv: powerpc_excp: Do not discard HDECR exception when entering power-saving mode Date: Fri, 27 Aug 2021 17:09:37 +1000 Message-Id: <20210827070946.219970-10-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210827070946.219970-1-david@gibson.dropbear.id.au> References: <20210827070946.219970-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=203.11.71.1; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Gibson , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1630049135618100001 From: C=C3=A9dric Le Goater The Hypervisor Decrementer exception should not be generated while the CPU is in power-saving mode (see cpu_ppc_hdecr_excp()). However, discarding the exception before entering the power-saving mode is wrong since we would loose a previously generated HDEC. Fixes: 4b236b621bf0 ("ppc: Initial HDEC support") Signed-off-by: C=C3=A9dric Le Goater Message-Id: <20210809134547.689560-4-clg@kaod.org> Signed-off-by: David Gibson --- target/ppc/excp_helper.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c index a79a0ed465..7b6ac16eef 100644 --- a/target/ppc/excp_helper.c +++ b/target/ppc/excp_helper.c @@ -1211,12 +1211,6 @@ void helper_pminsn(CPUPPCState *env, powerpc_pm_insn= _t insn) cs =3D env_cpu(env); cs->halted =3D 1; =20 - /* - * The architecture specifies that HDEC interrupts are discarded - * in PM states - */ - env->pending_interrupts &=3D ~(1 << PPC_INTERRUPT_HDECR); - /* Condition for waking up at 0x100 */ env->resume_as_sreset =3D (insn !=3D PPC_PM_STOP) || (env->spr[SPR_PSSCR] & PSSCR_EC); --=20 2.31.1