From nobody Sun Feb 8 19:43:39 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1629998832; cv=none; d=zohomail.com; s=zohoarc; b=i+6LPSbkJ1VxLzsiciBeZJH+P29W8L5J4mDRelsGKcZqn1TQBsiy+P5kDEDwzBQNSXGRTyrMtWHcY5mcLgEwVJH3XBHwMKuAo11Z4O3OPA0Z9T9oC97IE86afVOwOFOiu4rjDUjYl4xuH4bZ/JoOo81IzFMRwBH43RydkG4Qq/0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1629998832; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=KDBZg389G66cuuXg1cBtciC2SPgn2cHOhDyJJyO+H/o=; b=OAl3XVxHgyuuDtbo2SFs4E39UTLzP7cLLS4byU2WzfZmfpNcLqpofm8OIvnfukbQYTcg8oAzDULFHeH+lb2zYKWQEoGSC24eNSudnru/Yy1pJ5EoKDiazV/bd++J32Io6O6/H7UAMTvxIt4Pz3SSvgmjV29Hcc5foJJDdU8NBVQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1629998832793684.0620473724764; Thu, 26 Aug 2021 10:27:12 -0700 (PDT) Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-160-9rlGr-AOOZ2JUT7Hc377KQ-1; Thu, 26 Aug 2021 13:27:10 -0400 Received: by mail-wm1-f72.google.com with SMTP id r126-20020a1c4484000000b002e8858850abso1191308wma.0 for ; Thu, 26 Aug 2021 10:27:10 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id x21sm2244941wmi.15.2021.08.26.10.27.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Aug 2021 10:27:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629998831; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KDBZg389G66cuuXg1cBtciC2SPgn2cHOhDyJJyO+H/o=; b=HXujJFvSLBvj5Si2fBVEeMdYioOlr9F8YINtfdt8fbnroF0NNN6xue2SDaHVBM0/TJvQ5u lwyMoS2j1a+WORWaeAjrgdY5If4wDVX5QaIjnlF+BTtj1n3ZKLvOEtGSFsZBtsjKlxLsut j46hkwq500VYDkwvbYZE2pxVqSnf5Mg= X-MC-Unique: 9rlGr-AOOZ2JUT7Hc377KQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KDBZg389G66cuuXg1cBtciC2SPgn2cHOhDyJJyO+H/o=; b=ibl1OADK3Y8hYh/K7KWqT3kk4DNaAQQsqKLXrSTLAOGAD75XFIi96QUDg0XQw0htLD 4LSUlnrdO+/38kjHsawGI4Lsz7dlPS+TPmqvdEa42DFSbuI92yW5zfkOKi0429UhDFDj WHHfk9j7+lGL5oitgtQkTXE8xNiv3XYwcURXsHfPBUqLI+Eyz5zssyGrkes/Hp5L0xCZ 6nHu19BmSwCcMkshDguQwS2Rr9Kzvw7oPZBnhKsJWgR1ThQoFNVWgTaaKT+VdEmCnFqp gRGWlZqewX6XgIA7z8o/aXwmFFFMSSw1XVPI+OeafSI9nlRzNMsYDF8rmbWKybMuaUXm LzvQ== X-Gm-Message-State: AOAM532yiAjg2502Wun5ZQrt1VCGXr4dQi3gwIEb1QvlUuFX+PFlemmR QWYSVTQO/OgirCgphVWeHhoTS36E+Lil2uJ4bhCA0M0gx4cZMDd2rKjoVxdtYlmbkIy5vbE5a8x BS9pjGkRKBAC8nA== X-Received: by 2002:a7b:c92b:: with SMTP id h11mr4831139wml.62.1629998829429; Thu, 26 Aug 2021 10:27:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyR0d2R747B2ykwsUpswHtUeBjMLaGGar4KOKo5H4tP6yWonqaC+Xx2wx0tbFSZjG34mFrQ7Q== X-Received: by 2002:a7b:c92b:: with SMTP id h11mr4831127wml.62.1629998829257; Thu, 26 Aug 2021 10:27:09 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jason Wang , Stefan Hajnoczi , Paolo Bonzini , "Michael S. Tsirkin" , Cornelia Huck , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 2/3] hw/virtio: Remove NULL check in virtio_free_region_cache() Date: Thu, 26 Aug 2021 19:26:57 +0200 Message-Id: <20210826172658.2116840-3-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210826172658.2116840-1-philmd@redhat.com> References: <20210826172658.2116840-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1629998833855100001 virtio_free_region_cache() is called within call_rcu(), always with a non-NULL argument. Ensure new code keep it that way by replacing the NULL check by an assertion. Add a comment this function is called within call_rcu(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Stefan Hajnoczi Reviewed-by: Stefano Garzarella --- hw/virtio/virtio.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index a5214bca612..3a1f6c520cb 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -133,12 +133,10 @@ struct VirtQueue QLIST_ENTRY(VirtQueue) node; }; =20 +/* Called within call_rcu(). */ static void virtio_free_region_cache(VRingMemoryRegionCaches *caches) { - if (!caches) { - return; - } - + assert(caches !=3D NULL); address_space_cache_destroy(&caches->desc); address_space_cache_destroy(&caches->avail); address_space_cache_destroy(&caches->used); --=20 2.31.1