From nobody Sun Feb 8 15:42:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1629998828; cv=none; d=zohomail.com; s=zohoarc; b=WI7wDjv2eQeOoJag+fsNeIMxkJ2D4GINODI3elKzG8WpDvK6bTgVgUgpjp9/EyRzrf0cyR5NxZmHXhifibNZLrFEeU034K+aIbPfO93x1D7l5b5dL0Ye87XSB+6NCe3U90j98MO9Bpnv1D3GsoDt62JG5Efkgb+jmSVulvrdIC8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1629998828; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=6H+L02mu2VtYZ9Ci4vq9bPbkxedEevnpYIa7Jf3+z/I=; b=mmT83V7c7nSx98rZ4cMRPAsXAjG82atg+pWRDh9rK0Mz6H3bqHH0fFlyrbi4qUrrNjyIGsD9PjgEcG8BnnLs3Q3WURKA0jIuDGcSV0rpsUFnuqJyQpwab5H7jouwia/XSo6zf5C0hx0bR8ZmsFYinM4FD5oVzeygqBbtaAcm0VA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1629998828444711.9813609162545; Thu, 26 Aug 2021 10:27:08 -0700 (PDT) Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-529-cdQteZkTMbmm9Hdqr8yUGQ-1; Thu, 26 Aug 2021 13:27:06 -0400 Received: by mail-wm1-f71.google.com with SMTP id m22-20020a7bca56000000b002e7508f3faeso1180030wml.2 for ; Thu, 26 Aug 2021 10:27:05 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id o12sm3774338wro.51.2021.08.26.10.27.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Aug 2021 10:27:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629998827; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6H+L02mu2VtYZ9Ci4vq9bPbkxedEevnpYIa7Jf3+z/I=; b=iKXJ1XPrErwt0ac40In1fs3GgTd5BZFzrs0hWJVRMBeVRc+IW5w/Ozd2nV/tBtg/XaY7OS JmQ9ugppX5QfqP4gCUZo11ure1O4xoJnGBA6nIiyzpZ9vsDh81NBySyEOox491pAedJbpI Rl23tyL9YDeYkYlQFyOfVq2K0H5lQag= X-MC-Unique: cdQteZkTMbmm9Hdqr8yUGQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6H+L02mu2VtYZ9Ci4vq9bPbkxedEevnpYIa7Jf3+z/I=; b=pj2UfkOo/1Nk1T+iDuVO25EJhyriuwZXMmtM9ctMLJOHHQTGGg7evi0B1LsXom5MUu nQnDyL4U/OR3e1wdywK0cN1gxGMOUJT5cFb7W/xxgcuV03rdFkiuEKdrelTxemTFNuVg jlx4TZ7Exe7vcuw9iXvNBvtCp0/6mOHPvdSSLTm+mbHBx4rgtdr2GOm4NIDGY+U3LgTv 0fdqYAkPudoQcxBc3H8JpDLpixm7C0JTjzLQB1i16AUkUR9UWFe3zFD47ZL1YTyae8V6 jwbKZ8ifidBKgW6oTqvt4AnG/zuXT54F8HbhtiNsa1YcjcgyY9DlxTSJFSi6N9Uv4Zfz o79g== X-Gm-Message-State: AOAM532NWTmZCL7yaOaZ8HHSY2skB5g+ucwCxHl8PkLAkRuMnx+vGGka tUIil32OxG+NcDEBoBCWYEUyR5eBBnZxFHhboW+rUCo0toBvZd3LFkks3bZpxW/gxbQ5y5dWe1K tKGEWNLjGMgtI7w== X-Received: by 2002:a1c:2042:: with SMTP id g63mr15507761wmg.27.1629998825017; Thu, 26 Aug 2021 10:27:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyvQGEW9fnsUvH7lMnEtqbSRyVAYs06PBOgNAaQkgzx/G8LWn12Eva/kw5BO1E2Kyw/aObfaA== X-Received: by 2002:a1c:2042:: with SMTP id g63mr15507729wmg.27.1629998824766; Thu, 26 Aug 2021 10:27:04 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jason Wang , Stefan Hajnoczi , Paolo Bonzini , "Michael S. Tsirkin" , Cornelia Huck , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 1/3] hw/virtio: Document virtio_queue_packed_empty_rcu is called within RCU Date: Thu, 26 Aug 2021 19:26:56 +0200 Message-Id: <20210826172658.2116840-2-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210826172658.2116840-1-philmd@redhat.com> References: <20210826172658.2116840-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1629998829573100001 While virtio_queue_packed_empty_rcu() uses the '_rcu' suffix, it is not obvious it is called within rcu_read_lock(). All other functions from this file called with the RCU locked have a comment describing it. Document this one similarly for consistency. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Stefan Hajnoczi Reviewed-by: Stefano Garzarella --- hw/virtio/virtio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 874377f37a7..a5214bca612 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -634,6 +634,7 @@ static int virtio_queue_split_empty(VirtQueue *vq) return empty; } =20 +/* Called within rcu_read_lock(). */ static int virtio_queue_packed_empty_rcu(VirtQueue *vq) { struct VRingPackedDesc desc; --=20 2.31.1