From nobody Tue Feb 10 21:59:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.45 as permitted sender) client-ip=209.85.128.45; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f45.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1629896550; cv=none; d=zohomail.com; s=zohoarc; b=khYzEomADKJ/J6cBnTNKiHe71WhQkcaiYYarGziYrSvHMdjqxEblyctehodpodU5cU1+8xERhUUcMX3ItbMKkH00s7MGlkSIiyjQG68v0Nz7MedkZ6hUeoyLlvmpCcEcNVcIo2f+oQ7iX+xhdzJQl1F2kd9kR4W58sTpUm0gunk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1629896550; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=99fs6jcmMHJLrcJdKY3HRNZUMhTVbvVJpVEtsAH0Vus=; b=OdkD/kma7zT+QRvps1/t+Oyijl3oUzjj7fPEjI//cWlgpYdF7NgvaDsLnp7N1TCxaAAH95w63SjLnANgxZr2m5FW4WUuFXSe8c0ZyboMyNYy3ei59U3WU/MJZwairyauISuWUTjKdQ4btctpXmnVhdqSj6Y6bkDrtGhewXQo8Iw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by mx.zohomail.com with SMTPS id 162989655020832.14891633410912; Wed, 25 Aug 2021 06:02:30 -0700 (PDT) Received: by mail-wm1-f45.google.com with SMTP id c129-20020a1c35870000b02902e6b6135279so4580196wma.0 for ; Wed, 25 Aug 2021 06:02:29 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id d7sm21646640wrs.39.2021.08.25.06.02.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Aug 2021 06:02:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=99fs6jcmMHJLrcJdKY3HRNZUMhTVbvVJpVEtsAH0Vus=; b=Lffh9mCTl9Rwh1L6F7jozTo3Dq54OeElJCZsS1oX27ycd7WflYdYBnWCw4q4qVdJxo kDNq+SopZsFEq9mbW5MpUH0JeEI7yzBOwRarSMlinMZyLrwzlviJidAAuTdw8A4qFooc GAWT+evTubgo+6F+uBIqKjdK/eWxpYbtAhqR2L7i/tc0sJ4RU9eOXwcSNoRskpdr6P4S S6yT8m8mHR8nCPzrYMfMtF2Oj2jwDtUWD+teV4U6aliMrbvZb69wazoBsPLJBUJGZMlK 3I9AgYNvXsCJGjCdCvt6c6DGewq2ixBsxHJlz20cHDbg+vhlCLtg/X8xQEo0G/Q4+cOM e5ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=99fs6jcmMHJLrcJdKY3HRNZUMhTVbvVJpVEtsAH0Vus=; b=YXcL56MiJofyfOmPalvhglSSgqrpQM1+KlAxc+7MhzyGuTR/Z34gwzbAqLJ3sUbP1J MAQsLYQ8GFXsc13KhhvFlmWwdRS5oD+btxhdhAmPGxEgW+qHV/KuJnQ/kRpsZu6xYLYI H1QSG9lFP+kNYiBQ7/dXihifa/o39VWo7Doeb9S1r2N36dQ7xCzApPZx2OocS284s0ZQ MoQpjunoO3tz46/5ze0Pd7cU8CpEew9829nPe3G0TqT/Dl5SonPSCVdPYb7EYvQ3WOnk D17AYQlYSkjnQ87INCm0EY+vY0ZoWIz8Iwb9KO/04Mgg67z9ElF/iEKrHQmNvNbrw/DD /blg== X-Gm-Message-State: AOAM533/NhkreRAA4P/Mi44HZQTd1H50Kj6L+6Wkfg3jovK8VWgSs7HF g5qAMgU9ooEvcTtbNAUZMM8= X-Google-Smtp-Source: ABdhPJwsMpYeOU8IWSr+1zqW9d2ICi0bg3RrpfUEJ41txy0WITMyWqlu/Wezd+pP7pJZqI38LSLIRw== X-Received: by 2002:a05:600c:220f:: with SMTP id z15mr297262wml.74.1629896548319; Wed, 25 Aug 2021 06:02:28 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Aleksandar Rikalo , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Richard Henderson Subject: [PULL 03/28] target/mips: Decode vendor extensions before MIPS ISAs Date: Wed, 25 Aug 2021 15:01:46 +0200 Message-Id: <20210825130211.1542338-4-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210825130211.1542338-1-f4bug@amsat.org> References: <20210825130211.1542338-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1629896558404100001 In commit ffc672aa977 ("target/mips/tx79: Move MFHI1 / MFLO1 opcodes to decodetree") we misplaced the decoder call. Move it to the correct place. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20210801234202.3167676-3-f4bug@amsat.org> Reviewed-by: Richard Henderson --- target/mips/tcg/translate.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index 6b95cca052a..490add3fc15 100644 --- a/target/mips/tcg/translate.c +++ b/target/mips/tcg/translate.c @@ -16094,6 +16094,11 @@ static void decode_opc(CPUMIPSState *env, DisasCon= text *ctx) =20 /* Transition to the auto-generated decoder. */ =20 + /* Vendor specific extensions */ + if (cpu_supports_isa(env, INSN_R5900) && decode_ext_txx9(ctx, ctx->opc= ode)) { + return; + } + /* ISA extensions */ if (ase_msa_available(env) && decode_ase_msa(ctx, ctx->opcode)) { return; @@ -16103,9 +16108,6 @@ static void decode_opc(CPUMIPSState *env, DisasCont= ext *ctx) if (cpu_supports_isa(env, ISA_MIPS_R6) && decode_isa_rel6(ctx, ctx->op= code)) { return; } - if (cpu_supports_isa(env, INSN_R5900) && decode_ext_txx9(ctx, ctx->opc= ode)) { - return; - } =20 if (decode_opc_legacy(env, ctx)) { return; --=20 2.31.1