[PATCH v2 0/3] softmmu/vl: Deprecate old and crufty display ui options

Thomas Huth posted 3 patches 2 years, 7 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210825092023.81396-1-thuth@redhat.com
Maintainers: Paolo Bonzini <pbonzini@redhat.com>
docs/about/deprecated.rst | 20 ++++++++++++++++++++
qemu-options.hx           | 18 +++++++++++++-----
softmmu/vl.c              | 24 +++++++++++++++++++++---
3 files changed, 54 insertions(+), 8 deletions(-)
[PATCH v2 0/3] softmmu/vl: Deprecate old and crufty display ui options
Posted by Thomas Huth 2 years, 7 months ago
-display sdl uses a hand-crafted parser in vl.c, which is quite ugly
since the other parts of -display have been QAPIfied already. A straight
conversion to QAPI is not advisable since the "alt_grab" and "ctrl_grab"
parameters are not the best solution anyway. So this patch series
introduces a new "grab-mod" parameter as replacement instead and then
deprecates the old and crufty options.

While we're at it, the third patch also suggests to deprecated the
old -sdl and -curses top-level options.

v2:
 - Update version numbers to 6.2
 - Added Acked-bys from Peter Krempa

Thomas Huth (3):
  softmmu/vl: Add a "grab-mod" parameter to the -display sdl option
  softmmu/vl: Deprecate the old grab options
  softmmu/vl: Deprecate the -sdl and -curses option

 docs/about/deprecated.rst | 20 ++++++++++++++++++++
 qemu-options.hx           | 18 +++++++++++++-----
 softmmu/vl.c              | 24 +++++++++++++++++++++---
 3 files changed, 54 insertions(+), 8 deletions(-)

-- 
2.27.0


Re: [PATCH v2 0/3] softmmu/vl: Deprecate old and crufty display ui options
Posted by Gerd Hoffmann 2 years, 7 months ago
On Wed, Aug 25, 2021 at 11:20:20AM +0200, Thomas Huth wrote:
> -display sdl uses a hand-crafted parser in vl.c, which is quite ugly
> since the other parts of -display have been QAPIfied already. A straight
> conversion to QAPI is not advisable since the "alt_grab" and "ctrl_grab"
> parameters are not the best solution anyway. So this patch series
> introduces a new "grab-mod" parameter as replacement instead and then
> deprecates the old and crufty options.
> 
> While we're at it, the third patch also suggests to deprecated the
> old -sdl and -curses top-level options.

Looks all sane to me.

Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd