[PATCH v7 0/7] DEVICE_UNPLUG_GUEST_ERROR QAPI event

Daniel Henrique Barboza posted 7 patches 2 years, 7 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210825004835.472919-1-danielhb413@gmail.com
Maintainers: "Daniel P. Berrangé" <berrange@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Markus Armbruster <armbru@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, David Gibson <david@gibson.dropbear.id.au>, Eduardo Habkost <ehabkost@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Eric Blake <eblake@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Greg Kurz <groug@kaod.org>
There is a newer version of this series
docs/about/deprecated.rst | 10 ++++++++++
hw/acpi/memory_hotplug.c  | 11 ++++++++++-
hw/ppc/spapr.c            | 12 ++++++++++--
hw/ppc/spapr_drc.c        | 16 ++++++++++------
qapi/machine.json         |  7 ++++++-
qapi/qdev.json            | 32 +++++++++++++++++++++++++++++---
stubs/qdev.c              |  7 +++++++
7 files changed, 82 insertions(+), 13 deletions(-)
[PATCH v7 0/7] DEVICE_UNPLUG_GUEST_ERROR QAPI event
Posted by Daniel Henrique Barboza 2 years, 7 months ago
Hi,

In this version the event was renamed and the optional 'msg'
attribute was removed. It also contains smaller changes based
on Markus' comments in v6.

changes from v6:
- patches 1 and 2:
  * handle dev->id = NULL explicitly with empty string
- patch 3:
  * added Markus' reviewed-by
- patch 4:
  * reworded 'path' attribute desc as 'the device's QOM path'
  * added Markus's reviewed-by
- patch 5:
  * event was renamed to 'DEVICE_UNPLUG_GUEST_ERROR'
  * reworded 'path' attribute desc as 'the device's QOM path'
  * removed the optional member 'msg' of the event
- patches 6 and 7:
  * changes due to event rename and lack of 'msg' attribute
- v6 link: https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg04923.html


Daniel Henrique Barboza (7):
  memory_hotplug.c: handle dev->id = NULL in acpi_memory_hotplug_write()
  spapr.c: handle dev->id in spapr_memory_unplug_rollback()
  spapr_drc.c: do not error_report() when drc->dev->id == NULL
  qapi/qdev.json: fix DEVICE_DELETED parameters doc
  qapi/qdev.json: add DEVICE_UNPLUG_GUEST_ERROR QAPI event
  spapr: use DEVICE_UNPLUG_GUEST_ERROR to report unplug errors
  memory_hotplug.c: send DEVICE_UNPLUG_GUEST_ERROR in
    acpi_memory_hotplug_write()

 docs/about/deprecated.rst | 10 ++++++++++
 hw/acpi/memory_hotplug.c  | 11 ++++++++++-
 hw/ppc/spapr.c            | 12 ++++++++++--
 hw/ppc/spapr_drc.c        | 16 ++++++++++------
 qapi/machine.json         |  7 ++++++-
 qapi/qdev.json            | 32 +++++++++++++++++++++++++++++---
 stubs/qdev.c              |  7 +++++++
 7 files changed, 82 insertions(+), 13 deletions(-)

-- 
2.31.1


Re: [PATCH v7 0/7] DEVICE_UNPLUG_GUEST_ERROR QAPI event
Posted by Markus Armbruster 2 years, 6 months ago
Daniel Henrique Barboza <danielhb413@gmail.com> writes:

> Hi,
>
> In this version the event was renamed and the optional 'msg'
> attribute was removed. It also contains smaller changes based
> on Markus' comments in v6.

Looks neat now, thanks!

Series
Reviewed-by: Markus Armbruster <armbru@redhat.com>


Re: [PATCH v7 0/7] DEVICE_UNPLUG_GUEST_ERROR QAPI event
Posted by Markus Armbruster 2 years, 6 months ago
Not yet merged.  David, would you like to do the pull request?


Re: [PATCH v7 0/7] DEVICE_UNPLUG_GUEST_ERROR QAPI event
Posted by Markus Armbruster 2 years, 6 months ago
Markus Armbruster <armbru@redhat.com> writes:

> Not yet merged.  David, would you like to do the pull request?

Oops, there's v8.  Take that one of course.


Re: [PATCH v7 0/7] DEVICE_UNPLUG_GUEST_ERROR QAPI event
Posted by David Gibson 2 years, 6 months ago
On Wed, Sep 22, 2021 at 02:03:33PM +0200, Markus Armbruster wrote:
> Markus Armbruster <armbru@redhat.com> writes:
> 
> > Not yet merged.  David, would you like to do the pull request?
> 
> Oops, there's v8.  Take that one of course.

I have it in ppc-for-6.2, probably looking at a PR next week.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson