From nobody Mon Feb 9 17:24:59 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1629382872; cv=none; d=zohomail.com; s=zohoarc; b=kk3Nb6w0DqSfIXauDrAcB+En1+fRS1Fh4spUCWbu4FC3gcgX0Wj1Unng1mcqztlZL/ZUCZHBqwccV8J6ceiPTJh5ALERoLqvNtRxqbzUqignpL5j0ETVH/bGl1bkOTkDzVQdVD3/beRf9y4s8FT67A+7JLrSXfk+OldSq8XxLOs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1629382872; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=WwxcFzkUhr+SPEjC7KEdcFzv7DLvVmTT/gW/kFoiXv4=; b=Xpi9RNfM3MlFKTK1MxdDKEB+/Yx2QgqVfAiMVZfeEOGLYJ1TqA7AmugJNSlQbbbgS0YeyeIeOn+RA6QzLMzRuFelCSr5QJ/qfjM8OZc5C8CQvHhk0QeNiH5xZ8y5EEDV/Cnh7XOpUJXLR6KUNmNsXS0OTkAgFvNxmvuX6KLGVxU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 162938287198448.55521981470156; Thu, 19 Aug 2021 07:21:11 -0700 (PDT) Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-528-POr2aJVFP8SbN686BpgCNQ-1; Thu, 19 Aug 2021 10:21:06 -0400 Received: by mail-wm1-f70.google.com with SMTP id r11-20020a05600c35cb00b002e706077614so1315120wmq.5 for ; Thu, 19 Aug 2021 07:21:06 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id j16sm3054713wrr.78.2021.08.19.07.21.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Aug 2021 07:21:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629382868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WwxcFzkUhr+SPEjC7KEdcFzv7DLvVmTT/gW/kFoiXv4=; b=MvjTmNo62YtyxpBhoR2k9fBmedifYZ/vokz4MhVM+dSGD0PJ4p0q8e++vz7Nb2Dkq/yz4G sESFl7zkrusmitIiX0kh0eGvIvt80jW/L+Mff6ENoLAnxw4//DO4qzla8RPB7nfEk1WGOw SgMIIOnun/D+3xXbNxpfAOEsQoahHaY= X-MC-Unique: POr2aJVFP8SbN686BpgCNQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WwxcFzkUhr+SPEjC7KEdcFzv7DLvVmTT/gW/kFoiXv4=; b=QWeCtJ58Gwooxqg9omkg6K2JGYhFgoDYoqWiUehEnBlcLzhwfJ4diVfWPzRf/0pP3p UEZH1w3yyS+6NXb4KBAC1qYCvfg1R3JnJOYhzGOxKno3+yfpK3jXYnT1K95OESDeQGMz gL8L2thD/sBxtNhZIdln3PvPZnVhAEYP1fyk9sOxTiTYVrUVkx6qAhcIqt0c172G6ADq opJV7rmMFHMeH2Cis5l0wmYyA6fi2OIEdrZk0Q6hyrv6ilqNxMiphqjfJ7WFMJL7PnuB cTvB3NgA+VDfJnlrA25GZcxY/hSLH21Ke2qwmQYhI6lJaD3F0J/pzN8VVwBWIksqgMy5 0znQ== X-Gm-Message-State: AOAM530O/vGtceLMxte+XJ5lL7e30Cg7L0Ff7pVhwFwHnQ5dzYFD8t0U +84edpqiBr9FplquM1WDTx8UESW0aWG5KcDpAvTAv2W3Uu4+hA2fH/e7rmr+npJWo3KFejowMqg Fh7Grc2EoSqbRog== X-Received: by 2002:a1c:2090:: with SMTP id g138mr14014782wmg.98.1629382865447; Thu, 19 Aug 2021 07:21:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwjl4adP85e/ASWOoCVCYhPNY8xtrTPIrXPck7e9y+Cm5aHE4fKA3pr9YrjCEboKpsVNMjJnw== X-Received: by 2002:a1c:2090:: with SMTP id g138mr14014758wmg.98.1629382865260; Thu, 19 Aug 2021 07:21:05 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Peter Maydell , Paolo Bonzini , Peter Xu , Gerd Hoffmann , "Edgar E. Iglesias" , Alistair Francis , Jianxian Wen , Mark Cave-Ayland , qemu-arm@nongnu.org, David Hildenbrand , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 5/6] hw/usb: Replace alloc() + address_space_init() by address_space_create() Date: Thu, 19 Aug 2021 16:20:38 +0200 Message-Id: <20210819142039.2825366-6-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210819142039.2825366-1-philmd@redhat.com> References: <20210819142039.2825366-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1629382873687100001 Replace g_malloc0() + address_space_init() by address_space_create(). Release the resource in DeviceUnrealize(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/usb/hcd-xhci-sysbus.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/hw/usb/hcd-xhci-sysbus.c b/hw/usb/hcd-xhci-sysbus.c index a14e4381960..04ac485e8b3 100644 --- a/hw/usb/hcd-xhci-sysbus.c +++ b/hw/usb/hcd-xhci-sysbus.c @@ -43,16 +43,19 @@ static void xhci_sysbus_realize(DeviceState *dev, Error= **errp) s->irq =3D g_new0(qemu_irq, s->xhci.numintrs); qdev_init_gpio_out_named(dev, s->irq, SYSBUS_DEVICE_GPIO_IRQ, s->xhci.numintrs); - if (s->xhci.dma_mr) { - s->xhci.as =3D g_malloc0(sizeof(AddressSpace)); - address_space_init(s->xhci.as, s->xhci.dma_mr, NULL); - } else { - s->xhci.as =3D &address_space_memory; - } + s->xhci.as =3D address_space_create(s->xhci.dma_mr ?: get_system_memor= y(), + NULL); =20 sysbus_init_mmio(SYS_BUS_DEVICE(dev), &s->xhci.mem); } =20 +static void xhci_sysbus_unrealize(DeviceState *dev) +{ + XHCISysbusState *s =3D XHCI_SYSBUS(dev); + + address_space_destroy(s->xhci.as); +} + static void xhci_sysbus_instance_init(Object *obj) { XHCISysbusState *s =3D XHCI_SYSBUS(obj); @@ -103,6 +106,7 @@ static void xhci_sysbus_class_init(ObjectClass *klass, = void *data) =20 dc->reset =3D xhci_sysbus_reset; dc->realize =3D xhci_sysbus_realize; + dc->unrealize =3D xhci_sysbus_unrealize; dc->vmsd =3D &vmstate_xhci_sysbus; device_class_set_props(dc, xhci_sysbus_props); } --=20 2.31.1