From nobody Mon Feb 9 18:46:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1629122465; cv=none; d=zohomail.com; s=zohoarc; b=Mppjjbu+S0Vwyh+stqS3iRRAtyQoegPBuVr6ffC4Ih2cNU+a+V7HC2hLlaLbQ45xYeocrmDwbCTVpySUE4qAnqI1iuoJwNkx6pDDoDa0KSoFPsZChOL9+c3bGUK8kTPuzv4u7gwN1DOHT9JAnHdFvq+aBaK6hRV6i0SJ2P6V5i4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1629122465; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=G+5WdnIF0AlNWQxsS14WT6o6igP3aa3eGxkIM5Nj9A8=; b=EdyDEWs/IN3bHKPhs39fiMIChkOrDpGu2Yr+y/krZBynncP9kyJNlHDdhJA+muEo1xiPGP/qbTSKbxSyl1L3SptnoSuJWENu79Wh0lXzetbZDbr3eUPv3OmlRuS2ZQz5C+l7l7IlCG9L/vP0V15QRwM+puS0je0vpyKkKa6h9T0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1629122465537821.8318035022415; Mon, 16 Aug 2021 07:01:05 -0700 (PDT) Received: from localhost ([::1]:48836 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFdAl-0005r5-L5 for importer@patchew.org; Mon, 16 Aug 2021 10:01:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55026) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFd8a-0003By-Tr for qemu-devel@nongnu.org; Mon, 16 Aug 2021 09:58:48 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]:35634) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mFd8Z-000620-9y for qemu-devel@nongnu.org; Mon, 16 Aug 2021 09:58:48 -0400 Received: by mail-wr1-x42b.google.com with SMTP id q10so23826637wro.2 for ; Mon, 16 Aug 2021 06:58:46 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id y14sm11855631wrs.29.2021.08.16.06.58.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Aug 2021 06:58:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=G+5WdnIF0AlNWQxsS14WT6o6igP3aa3eGxkIM5Nj9A8=; b=Tdb0r/wbvlfqvUqBK0PBEoSenzXO6sJW7i8ZDQRMW3whbaAuc1trHIRsjCVzvRwiO+ 3E6sqyWPyV8UetGa51lLZ4fqhFZDOBjQCi8PmlLcQlgbG8hBv4N8JHncj6FxVo8PtTFW zaeJ1fQocSc4QVEF+dawpNEPX0miOiaLHWqW6pty0Bfsban+0FRkvWT1mftYcwzLExk7 rk/5ndVRZCP/l/ubHoUTSBkTFTss56edbWgNml1lSZu1kc2ufKm9XNJmcf15Y9aaWvmY NO4UbtYua333uvplrARxd5bs30xcOqGsPsKTZTrzpNSPi6lYYH/mqqmAFpYghTcaGya0 ulXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=G+5WdnIF0AlNWQxsS14WT6o6igP3aa3eGxkIM5Nj9A8=; b=ic3xvTcE9JEWXUlY/RjbEQNE6GNgsTPRNy6yd1SR+FNSPJLyq2tdkELa/o7SLhIQIA gw+wenggi9OPNm/LpVyUh2eHhQr2f+xd7Y8kNgpYPtManxtQlVYt/24G4TkBygghcs0X KY8z/MzIiAMY6ooVHjnl8tbhfS7VpnINMu8krbB4KeMVjY94e3q4SkRcQYGi09H0gN3t YD+K8pW7tppgt45X524xInV1YnUsxMRraLMLNwx/MAakDFlzZCAhX5hJP8spxRltijyJ igzoSTevkDiVGOHPQDcgX/SiP2XzfOlNtYmS+fIACV/mHQ8SrUiuszKjmHIu8Z4zCU87 poUg== X-Gm-Message-State: AOAM531K+bAnLOFgttU6eY8xVDRdP7CuCpekfaOHSUsJcdYLEku0TrQs gzzD8umFPizB/49LqkhQV928sA== X-Google-Smtp-Source: ABdhPJwYXOMeBcx8+tbRAdNNOSkeVNCxN8KDL173VTiTvz/Nm7+WSlxXy3xCKW0dQ7wKRPuoUm1qdQ== X-Received: by 2002:a5d:4447:: with SMTP id x7mr19872425wrr.198.1629122325300; Mon, 16 Aug 2021 06:58:45 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH 1/3] raspi: Use error_fatal for SoC realize errors, not error_abort Date: Mon, 16 Aug 2021 14:58:40 +0100 Message-Id: <20210816135842.25302-2-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210816135842.25302-1-peter.maydell@linaro.org> References: <20210816135842.25302-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Andrew Baumann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1629122490183100001 Content-Type: text/plain; charset="utf-8" The SoC realize can fail for legitimate reasons, because it propagates errors up from CPU realize, which in turn can be provoked by user error in setting commandline options. Use error_fatal so we report the error message to the user and exit, rather than asserting via error_abort. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/arm/raspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c index b30a17871f7..0ada91c05e9 100644 --- a/hw/arm/raspi.c +++ b/hw/arm/raspi.c @@ -281,7 +281,7 @@ static void raspi_machine_init(MachineState *machine) object_property_add_const_link(OBJECT(&s->soc), "ram", OBJECT(machine-= >ram)); object_property_set_int(OBJECT(&s->soc), "board-rev", board_rev, &error_abort); - qdev_realize(DEVICE(&s->soc), NULL, &error_abort); + qdev_realize(DEVICE(&s->soc), NULL, &error_fatal); =20 /* Create and plug in the SD cards */ di =3D drive_get_next(IF_SD); --=20 2.20.1