From nobody Tue Feb 10 05:27:24 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=google.com ARC-Seal: i=1; a=rsa-sha256; t=1628898452; cv=none; d=zohomail.com; s=zohoarc; b=D7zA3o1ycDXybKtJPv4rp51+Gt6UKAw04h1+BHDkAVdT2LSsBAtGKbgaf1IVHgYvnwB2Le29XxcZOHfUlsYNjo3bOGrunpwwBndAwULVqvq/BppNKSceqJiXIZyovssL4yqzlBxZrk+cYsmLvJiA9wdKAk+5kRSi8WsuzUBBdmA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1628898452; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=MRgx5EINM+OZ9RdClH3PKs9MpKhTo0wKW3xpUDNjLPU=; b=fDYp1Uwh7h5kCIpu2wSfyCI+PH/1bwR0NaDuO5l9CELVYz0jzX4O+3Cj2iYnESJ02P1WTM0CXSoplklKKCl7BUOGrfZbFMggg/3jVTZUEJQWa2lBPuX0YRuja72ff+gjPur/XacbXhB63P3Vl9jyRwOlRP1JosBRWXRLWssiOHY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1628898452094457.84192676463033; Fri, 13 Aug 2021 16:47:32 -0700 (PDT) Received: from localhost ([::1]:37182 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mEgte-0007Ot-Tq for importer@patchew.org; Fri, 13 Aug 2021 19:47:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54628) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <34QMXYQMKClQz502AA270.yA8C08G-z0H079A929G.AD2@flex--dje.bounces.google.com>) id 1mEgqr-0003PX-9c for qemu-devel@nongnu.org; Fri, 13 Aug 2021 19:44:37 -0400 Received: from mail-yb1-xb49.google.com ([2607:f8b0:4864:20::b49]:35481) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <34QMXYQMKClQz502AA270.yA8C08G-z0H079A929G.AD2@flex--dje.bounces.google.com>) id 1mEgqo-0003mN-Rx for qemu-devel@nongnu.org; Fri, 13 Aug 2021 19:44:37 -0400 Received: by mail-yb1-xb49.google.com with SMTP id f8-20020a2585480000b02905937897e3daso10632608ybn.2 for ; Fri, 13 Aug 2021 16:44:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=MRgx5EINM+OZ9RdClH3PKs9MpKhTo0wKW3xpUDNjLPU=; b=DFPhC92eWYhpyuFU6O2PdpRaQtHaA8XhRZMMr658CvTxMBLQsy9KrUwRITxVVjOz5k +RiMvb/aimWXsbpXbaV0NpNPB3d2TEcoy4mIUGq8BSrHwGW0bkcr7O4F1eCqwGXbeeQV qafBJmDkZX2UbFM1Fc0E/zzfZfs3KyYGZHcfBVg25XxZJLEGntd8RHc3AWKEQqJYxYbL AjQRUdVYGCaSbHwAuvLliQAq6j1/Zw532sxMUawsYwmi5zuotek5L4yr3A9o2wagu/5p vf28XUDbfMz0Hn8YhjJaytELWiaEA9U5W66WxdZfjb91EADJDXedy26EmyqhanqavM3I onDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=MRgx5EINM+OZ9RdClH3PKs9MpKhTo0wKW3xpUDNjLPU=; b=BUakln/vWwySp7qO+SMb1qKOwEbYcF1ZgcA8gEQ197PhRFZO7tOcJVMWRvC4qXloPs h9fCkGDGB7phQQIuPNhzS9gbU1+LUt+70alfL6wz2LEE4Vv0qD26fmMvaPyw4060aMWe QsGuf8ALVPCOgzqiZgv7U91pfXsMfjw6HUd1zBCeAUR3dvagHSxwHRDiJq/pDqlG5Tsz uWDkbBI26fT/kqu+K5LR1sZOwpxr7QgrDy8rhOkRYSTOIqQWD9ouNa5a7J8vIerFM8zY ZJpQuxUpmpvLu4EaNlMg91UTLjnqWVFDqgUMR3lx34yZO8b3pZ2R4KRcXDDJv0ykXxCN BCxw== X-Gm-Message-State: AOAM53188X27EBfDWyzHzCZCEaXUORfW87Mm47SLWOi/oc4P2vgN6ZtM Fa4WVoDRLIX4o/2s1P+9fFRGebI6jGwo3AZ4+oKTLeodClVXAYxrlaWZ7PJJfCVi3eqTKYcgfye j/0NYgkzjZfwc3pfbjTjyD/b05Frj7UuutLVsXThTEc22ot6pmfX3 X-Google-Smtp-Source: ABdhPJwBmY2bgWCeqiaRr3MnH0s9FlAtKfcIdjhfkEEBNXF/2Kg7sFCk38cQpuDwBulMdNXgwZvQXAw= X-Received: from ruffy.mtv.corp.google.com ([2620:0:1000:1412:94ae:6a1e:bc04:4f63]) (user=dje job=sendgmr) by 2002:a25:1ac2:: with SMTP id a185mr6838100yba.350.1628898273187; Fri, 13 Aug 2021 16:44:33 -0700 (PDT) Date: Fri, 13 Aug 2021 16:44:23 -0700 In-Reply-To: <20210813234424.2029019-1-dje@google.com> Message-Id: <20210813234424.2029019-3-dje@google.com> Mime-Version: 1.0 References: <20210813234424.2029019-1-dje@google.com> X-Mailer: git-send-email 2.33.0.rc1.237.g0d66db33f3-goog Subject: [PATCH v8 2/3] net/slirp.c: Refactor address parsing From: Doug Evans To: qemu-devel@nongnu.org Cc: Samuel Thibault , "=?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?=" , Jason Wang , "=?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?=" , Doug Evans Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::b49; envelope-from=34QMXYQMKClQz502AA270.yA8C08G-z0H079A929G.AD2@flex--dje.bounces.google.com; helo=mail-yb1-xb49.google.com X-Spam_score_int: -95 X-Spam_score: -9.6 X-Spam_bar: --------- X-Spam_report: (-9.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @google.com) X-ZM-MESSAGEID: 1628898453440100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ... in preparation for adding ipv6 host forwarding support. Tested: avocado run tests/acceptance/hostfwd.py Signed-off-by: Doug Evans --- Changes from v7: No changes. Changes from v6: Add support for --enable-slirp=3Dsystem Tested with system libslirp 4.4.0. Changes from v5: Use InetSocketAddress and getaddrinfo(). Use new libslirp calls: slirp_remove_hostxfwd, slirp_add_hostxfwd. include/qemu/sockets.h | 2 + net/slirp.c | 236 ++++++++++++++++++++++++++---------- tests/acceptance/hostfwd.py | 91 ++++++++++++++ util/qemu-sockets.c | 17 ++- 4 files changed, 278 insertions(+), 68 deletions(-) create mode 100644 tests/acceptance/hostfwd.py diff --git a/include/qemu/sockets.h b/include/qemu/sockets.h index 7b2d06ff6e..f0db9f0c0c 100644 --- a/include/qemu/sockets.h +++ b/include/qemu/sockets.h @@ -29,6 +29,8 @@ int socket_set_fast_reuse(int fd); #define SHUT_RDWR 2 #endif =20 +int sockaddr_getport(const struct sockaddr *addr); + int inet_ai_family_from_address(InetSocketAddress *addr, Error **errp); const char *inet_parse_host_port(InetSocketAddress *addr, diff --git a/net/slirp.c b/net/slirp.c index ad3a838e0b..2349eb2c23 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -641,14 +641,106 @@ static SlirpState *slirp_lookup(Monitor *mon, const = char *id) } } =20 +static const char *parse_protocol(const char *str, bool *is_udp, + Error **errp) +{ + char buf[10]; + const char *p =3D str; + + if (get_str_sep(buf, sizeof(buf), &p, ':') < 0) { + error_setg(errp, "missing protocol name separator"); + return NULL; + } + + if (!strcmp(buf, "tcp") || buf[0] =3D=3D '\0') { + *is_udp =3D false; + } else if (!strcmp(buf, "udp")) { + *is_udp =3D true; + } else { + error_setg(errp, "bad protocol name '%s'", buf); + return NULL; + } + + return p; +} + +static int parse_hostfwd_sockaddr(const char *str, int socktype, + struct sockaddr_storage *saddr, + Error **errp) +{ + struct addrinfo hints, *res =3D NULL, *e; + InetSocketAddress *addr =3D g_new(InetSocketAddress, 1); + int gai_rc; + int rc =3D -1; + + const char *optstr =3D inet_parse_host_port(addr, str, errp); + if (optstr =3D=3D NULL) { + goto fail_return; + } + + memset(&hints, 0, sizeof(hints)); + hints.ai_flags =3D AI_PASSIVE; /* ignored if host is not ""(->NULL) */ + hints.ai_flags |=3D AI_NUMERICHOST | AI_NUMERICSERV; + hints.ai_socktype =3D socktype; + hints.ai_family =3D PF_INET; + + /* + * Calling getaddrinfo for guest addresses is dubious, but addresses a= re + * restricted to numeric only. Convert "" to NULL for getaddrinfo's + * benefit. + */ + gai_rc =3D getaddrinfo(*addr->host ? addr->host : NULL, + *addr->port ? addr->port : NULL, &hints, &res); + if (gai_rc !=3D 0) { + error_setg(errp, "address resolution failed for '%s': %s", + str, gai_strerror(gai_rc)); + goto fail_return; + } + if (res->ai_next !=3D NULL) { + /* + * The caller only wants one address, and except for "any" for both + * ipv4 and ipv6 (which we've already precluded above), we shouldn= 't + * get more than one. To assist debugging print all we find. + */ + GString *s =3D g_string_new(NULL); + for (e =3D res; e !=3D NULL; e =3D e->ai_next) { + char host[NI_MAXHOST]; + char serv[NI_MAXSERV]; + int ret =3D getnameinfo((struct sockaddr *)e->ai_addr, e->ai_a= ddrlen, + host, sizeof(host), + serv, sizeof(serv), + NI_NUMERICHOST | NI_NUMERICSERV); + if (ret =3D=3D 0) { + g_string_append_printf(s, "\n %s:%s", host, serv); + } else { + g_string_append_printf(s, "\n unknown, got: %s", + gai_strerror(ret)); + } + } + error_setg(errp, "multiple addresses resolved for '%s':%s", + str, s->str); + g_string_free(s, TRUE); + goto fail_return; + } + + memcpy(saddr, res->ai_addr, res->ai_addrlen); + rc =3D 0; + + fail_return: + qapi_free_InetSocketAddress(addr); + if (res) { + freeaddrinfo(res); + } + return rc; +} + void hmp_hostfwd_remove(Monitor *mon, const QDict *qdict) { - struct in_addr host_addr =3D { .s_addr =3D INADDR_ANY }; - int host_port; - char buf[256]; + struct sockaddr_storage host_addr; const char *src_str, *p; SlirpState *s; - int is_udp =3D 0; + bool is_udp; + Error *error =3D NULL; int err; const char *arg1 =3D qdict_get_str(qdict, "arg1"); const char *arg2 =3D qdict_get_try_str(qdict, "arg2"); @@ -664,110 +756,130 @@ void hmp_hostfwd_remove(Monitor *mon, const QDict *= qdict) return; } =20 + g_assert(src_str !=3D NULL); p =3D src_str; - if (!p || get_str_sep(buf, sizeof(buf), &p, ':') < 0) { - goto fail_syntax; - } =20 - if (!strcmp(buf, "tcp") || buf[0] =3D=3D '\0') { - is_udp =3D 0; - } else if (!strcmp(buf, "udp")) { - is_udp =3D 1; - } else { + p =3D parse_protocol(p, &is_udp, &error); + if (p =3D=3D NULL) { goto fail_syntax; } =20 - if (get_str_sep(buf, sizeof(buf), &p, ':') < 0) { - goto fail_syntax; - } - if (buf[0] !=3D '\0' && !inet_aton(buf, &host_addr)) { + if (parse_hostfwd_sockaddr(p, is_udp ? SOCK_DGRAM : SOCK_STREAM, + &host_addr, &error) < 0) { goto fail_syntax; } =20 - if (qemu_strtoi(p, NULL, 10, &host_port)) { - goto fail_syntax; +#if SLIRP_CHECK_VERSION(4, 5, 0) + { + int flags =3D is_udp ? SLIRP_HOSTFWD_UDP : 0; + err =3D slirp_remove_hostxfwd(s->slirp, (struct sockaddr *) &host_= addr, + sizeof(host_addr), flags); } - - err =3D slirp_remove_hostfwd(s->slirp, is_udp, host_addr, host_port); +#else + if (host_addr.ss_family !=3D AF_INET) { + monitor_printf(mon, + "Could not remove host forwarding rule '%s':" + " only IPv4 supported", + src_str); + return; + } else { + struct sockaddr_in *host_in_addr =3D (struct sockaddr_in *) &host_= addr; + err =3D slirp_remove_hostfwd(s->slirp, is_udp, + host_in_addr->sin_addr, + ntohs(host_in_addr->sin_port)); + } +#endif =20 monitor_printf(mon, "host forwarding rule for %s %s\n", src_str, err ? "not found" : "removed"); return; =20 fail_syntax: - monitor_printf(mon, "invalid format\n"); + monitor_printf(mon, "Invalid format: %s\n", error_get_pretty(error)); + error_free(error); } =20 static int slirp_hostfwd(SlirpState *s, const char *redir_str, Error **err= p) { - struct in_addr host_addr =3D { .s_addr =3D INADDR_ANY }; - struct in_addr guest_addr =3D { .s_addr =3D 0 }; - int host_port, guest_port; + struct sockaddr_storage host_addr, guest_addr; const char *p; char buf[256]; - int is_udp; - char *end; - const char *fail_reason =3D "Unknown reason"; + bool is_udp; + Error *error =3D NULL; + int port; =20 + g_assert(redir_str !=3D NULL); p =3D redir_str; - if (!p || get_str_sep(buf, sizeof(buf), &p, ':') < 0) { - fail_reason =3D "No : separators"; - goto fail_syntax; - } - if (!strcmp(buf, "tcp") || buf[0] =3D=3D '\0') { - is_udp =3D 0; - } else if (!strcmp(buf, "udp")) { - is_udp =3D 1; - } else { - fail_reason =3D "Bad protocol name"; - goto fail_syntax; - } =20 - if (get_str_sep(buf, sizeof(buf), &p, ':') < 0) { - fail_reason =3D "Missing : separator"; - goto fail_syntax; - } - if (buf[0] !=3D '\0' && !inet_aton(buf, &host_addr)) { - fail_reason =3D "Bad host address"; + p =3D parse_protocol(p, &is_udp, &error); + if (p =3D=3D NULL) { goto fail_syntax; } =20 if (get_str_sep(buf, sizeof(buf), &p, '-') < 0) { - fail_reason =3D "Bad host port separator"; + error_setg(&error, "missing host-guest separator"); goto fail_syntax; } - host_port =3D strtol(buf, &end, 0); - if (*end !=3D '\0' || host_port < 0 || host_port > 65535) { - fail_reason =3D "Bad host port"; + + if (parse_hostfwd_sockaddr(buf, is_udp ? SOCK_DGRAM : SOCK_STREAM, + &host_addr, &error) < 0) { + error_prepend(&error, "For host address: "); goto fail_syntax; } =20 - if (get_str_sep(buf, sizeof(buf), &p, ':') < 0) { - fail_reason =3D "Missing guest address"; + if (parse_hostfwd_sockaddr(p, is_udp ? SOCK_DGRAM : SOCK_STREAM, + &guest_addr, &error) < 0) { + error_prepend(&error, "For guest address: "); goto fail_syntax; } - if (buf[0] !=3D '\0' && !inet_aton(buf, &guest_addr)) { - fail_reason =3D "Bad guest address"; + port =3D sockaddr_getport((struct sockaddr *) &guest_addr); + if (port =3D=3D 0) { + error_setg(&error, "For guest address: invalid port '0'"); goto fail_syntax; } =20 - guest_port =3D strtol(p, &end, 0); - if (*end !=3D '\0' || guest_port < 1 || guest_port > 65535) { - fail_reason =3D "Bad guest port"; - goto fail_syntax; +#if SLIRP_CHECK_VERSION(4, 5, 0) + { + int flags =3D is_udp ? SLIRP_HOSTFWD_UDP : 0; + if (slirp_add_hostxfwd(s->slirp, + (struct sockaddr *) &host_addr, + sizeof(host_addr), + (struct sockaddr *) &guest_addr, + sizeof(guest_addr), + flags) < 0) { + error_setg(errp, "Could not set up host forwarding rule '%s': = %s", + redir_str, strerror(errno)); + return -1; + } } - - if (slirp_add_hostfwd(s->slirp, is_udp, host_addr, host_port, guest_ad= dr, - guest_port) < 0) { - error_setg(errp, "Could not set up host forwarding rule '%s'", +#else + if (host_addr.ss_family !=3D AF_INET || guest_addr.ss_family !=3D AF_I= NET) { + error_setg(errp, + "Could not set up host forwarding rule '%s':" + " only IPv4 supported", redir_str); return -1; + } else { + struct sockaddr_in *host_in_addr =3D (struct sockaddr_in *) &host_= addr; + struct sockaddr_in *guest_in_addr =3D (struct sockaddr_in *) &gues= t_addr; + if (slirp_add_hostfwd(s->slirp, is_udp, + host_in_addr->sin_addr, + ntohs(host_in_addr->sin_port), + guest_in_addr->sin_addr, + ntohs(guest_in_addr->sin_port)) < 0) { + error_setg(errp, "Could not set up host forwarding rule '%s'", + redir_str); + return -1; + } } +#endif + return 0; =20 fail_syntax: error_setg(errp, "Invalid host forwarding rule '%s' (%s)", redir_str, - fail_reason); + error_get_pretty(error)); + error_free(error); return -1; } =20 diff --git a/tests/acceptance/hostfwd.py b/tests/acceptance/hostfwd.py new file mode 100644 index 0000000000..9b9db142c3 --- /dev/null +++ b/tests/acceptance/hostfwd.py @@ -0,0 +1,91 @@ +# Hostfwd command tests +# +# Copyright 2021 Google LLC +# +# This program is free software; you can redistribute it and/or modify it +# under the terms of the GNU General Public License as published by the +# Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, but WITH= OUT +# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or +# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License +# for more details. + + +from avocado_qemu import Test + + +class Hostfwd(Test): + """ + :avocado: tags=3Dhostfwd + """ + def hmc(self, cmd): + return self.vm.command('human-monitor-command', command_line=3Dcmd) + + def test_qmp_hostfwd_ipv4(self): + self.vm.add_args('-nodefaults', + '-netdev', 'user,id=3Dvnet', + '-device', 'virtio-net,netdev=3Dvnet') + self.vm.launch() + self.assertEquals(self.hmc('hostfwd_add vnet tcp::65022-:22'), '') + self.assertEquals(self.hmc('hostfwd_remove vnet tcp::65022'), + 'host forwarding rule for tcp::65022 removed\r\n= ') + self.assertEquals(self.hmc('hostfwd_add tcp::65022-:22'), '') + self.assertEquals(self.hmc('hostfwd_remove tcp::65022'), + 'host forwarding rule for tcp::65022 removed\r\n= ') + self.assertEquals(self.hmc('hostfwd_add udp::65042-:42'), '') + self.assertEquals(self.hmc('hostfwd_remove udp::65042'), + 'host forwarding rule for udp::65042 removed\r\n= ') + + def test_qmp_hostfwd_ipv4_functional_errors(self): + """Verify handling of various kinds of errors given valid addresse= s.""" + self.vm.add_args('-nodefaults', + '-netdev', 'user,id=3Dvnet', + '-device', 'virtio-net,netdev=3Dvnet') + self.vm.launch() + self.assertEquals(self.hmc('hostfwd_remove ::65022'), + 'host forwarding rule for ::65022 not found\r\n') + self.assertEquals(self.hmc('hostfwd_add udp::65042-:42'), '') + self.assertEquals(self.hmc('hostfwd_add udp::65042-:42'), + "Could not set up host forwarding rule" + \ + " 'udp::65042-:42': Address already in use\r\n") + self.assertEquals(self.hmc('hostfwd_remove ::65042'), + 'host forwarding rule for ::65042 not found\r\n') + self.assertEquals(self.hmc('hostfwd_remove udp::65042'), + 'host forwarding rule for udp::65042 removed\r\n= ') + self.assertEquals(self.hmc('hostfwd_remove udp::65042'), + 'host forwarding rule for udp::65042 not found\r= \n') + + def test_qmp_hostfwd_ipv4_parsing_errors(self): + """Verify handling of various kinds of parsing errors.""" + self.vm.add_args('-nodefaults', + '-netdev', 'user,id=3Dvnet', + '-device', 'virtio-net,netdev=3Dvnet') + self.vm.launch() + self.assertEquals(self.hmc('hostfwd_remove abc::42'), + "Invalid format: bad protocol name 'abc'\r\n") + self.assertEquals(self.hmc('hostfwd_add abc::65022-:22'), + "Invalid host forwarding rule 'abc::65022-:22'" = + \ + " (bad protocol name 'abc')\r\n") + self.assertEquals(self.hmc('hostfwd_add :foo'), + "Invalid host forwarding rule ':foo'" + \ + " (missing host-guest separator)\r\n") + self.assertEquals(self.hmc('hostfwd_add :a.b.c.d:66-:66'), + "Invalid host forwarding rule ':a.b.c.d:66-:66'"= + \ + " (For host address: address resolution failed f= or" \ + " 'a.b.c.d:66': Name or service not known)\r\n") + self.assertEquals(self.hmc('hostfwd_add ::66-a.b.c.d:66'), + "Invalid host forwarding rule '::66-a.b.c.d:66'"= + \ + " (For guest address: address resolution failed"= + \ + " for 'a.b.c.d:66': Name or service not known)\r= \n") + self.assertEquals(self.hmc('hostfwd_add ::-1-foo'), + "Invalid host forwarding rule '::-1-foo'" + \ + " (For host address: error parsing port in" + \ + " address ':')\r\n") + self.assertEquals(self.hmc('hostfwd_add ::66-foo'), + "Invalid host forwarding rule '::66-foo' (For" += \ + " guest address: error parsing address 'foo')\r\= n") + self.assertEquals(self.hmc('hostfwd_add ::66-:0'), + "Invalid host forwarding rule '::66-:0'" + \ + " (For guest address: invalid port '0')\r\n") diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index 085b057c18..37490654eb 100644 --- a/util/qemu-sockets.c +++ b/util/qemu-sockets.c @@ -46,23 +46,28 @@ #endif =20 =20 -static int inet_getport(struct addrinfo *e) +int sockaddr_getport(const struct sockaddr *addr) { - struct sockaddr_in *i4; - struct sockaddr_in6 *i6; + const struct sockaddr_in *i4; + const struct sockaddr_in6 *i6; =20 - switch (e->ai_family) { + switch (addr->sa_family) { case PF_INET6: - i6 =3D (void*)e->ai_addr; + i6 =3D (void *)addr; return ntohs(i6->sin6_port); case PF_INET: - i4 =3D (void*)e->ai_addr; + i4 =3D (void *)addr; return ntohs(i4->sin_port); default: return 0; } } =20 +static int inet_getport(struct addrinfo *e) +{ + return sockaddr_getport(e->ai_addr); +} + static void inet_setport(struct addrinfo *e, int port) { struct sockaddr_in *i4; --=20 2.33.0.rc1.237.g0d66db33f3-goog