From nobody Mon Feb 9 03:31:12 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1628867209260455.09891919267045; Fri, 13 Aug 2021 08:06:49 -0700 (PDT) Received: from localhost ([::1]:58888 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mEYli-0004Pg-4G for importer@patchew.org; Fri, 13 Aug 2021 11:06:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39968) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mEYkD-0001g2-0W for qemu-devel@nongnu.org; Fri, 13 Aug 2021 11:05:13 -0400 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:43630) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mEYkB-0003SE-Jl for qemu-devel@nongnu.org; Fri, 13 Aug 2021 11:05:12 -0400 Received: by mail-wr1-x429.google.com with SMTP id z9so13638996wrh.10 for ; Fri, 13 Aug 2021 08:05:11 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id h9sm1836361wrv.84.2021.08.13.08.05.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Aug 2021 08:05:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=R4SpbrLOmCpTHzbhSXpHi6M49IXENuQ3Igp0+lnrf3E=; b=EH4khaYk8cvhdmslHIw8sLAoapCDXBlwZ1leaMJmCORcn5dF8yVFxwQgXMJpt81zIT viTEJbl+sFlauVLnPl1iOWo0CrHLX5Ca1S6sTLR2Yx1qY5LcsEaG4x9ei4uHdxL8EVCa sl9psCncmbfbc1Oizt6kX+2qQvfwo4yapOZuTjkh1DIjDxAaPIBRjikfAD26kZCv5cWx m9KKvAar+6RahyANa5nVjwVqb6sh1LVEm7LgihYUeY/59/e0lMnCl/G43MFZ+tHF8vEI LgGsUBuut/QMtCL93ZBVGKXZtfHdcnscVuZiAtMiiufsvI3v6t7vyV0qJmXgjNCkrH2l qS6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=R4SpbrLOmCpTHzbhSXpHi6M49IXENuQ3Igp0+lnrf3E=; b=bu8eCAxWAqR+85gKSox2lkLdRoJGI8m5ETtj79g/auc9/OrxifTboOlYvdVoG6uLlC GM1pLB4zYqE+HUJDwmUtPBvbTneucIP5ij0ZxEPgT2lUi7WQIfLOIwW1WJODpGmu5FJL A4insasDiZFjrjPm5TOMVOjoCu+InZ4vzOiS7ikKHCtM58bgxzYeXmdLqhczY3ydm5NP 3wrsaxSfPkBMk4bi6zzu/Z9nfGlzeVQU9/+BKasR8xhCd31MweBKGHXF+dvSbLSL1J06 TI752IhkQMLYJyrBjgoBFXzmoJIfoWgQOnaBJI9pgabmgMs97o8OoePqS3+SPSIUcuUX Mfiw== X-Gm-Message-State: AOAM532TOtOJV8I+o5LaSpZv2oKEM0tY6qVql5u4oUGVp5MAWNn2PG5I Y4CHNAPKZoaQ9JYYjbrGsZVCFwwDz/IdPw== X-Google-Smtp-Source: ABdhPJyl5P0iO0CkbY0rpCofsmb7KXXQlJf75+LiibQfeGGm2/8FT7ozqH030tzCEYemOYmrOb4buQ== X-Received: by 2002:adf:8102:: with SMTP id 2mr3601607wrm.89.1628867109839; Fri, 13 Aug 2021 08:05:09 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PATCH for-6.2 1/4] net: Zero sockaddr_in in parse_host_port() Date: Fri, 13 Aug 2021 16:05:03 +0100 Message-Id: <20210813150506.7768-2-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210813150506.7768-1-peter.maydell@linaro.org> References: <20210813150506.7768-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jason Wang , Eric Blake , Corey Minyard Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1628867210140100001 Content-Type: text/plain; charset="utf-8" We don't currently zero-initialize the 'struct sockaddr_in' that parse_host_port() fills in, so any fields we don't explicitly initialize might be left as random garbage. POSIX states that implementations may define extensions in sockaddr_in, and that those extensions must not trigger if zero-initialized. So not zero initializing might result in inadvertently triggering an impdef extension. memset() the sockaddr_in before we start to fill it in. Fixes: Coverity CID 1005338 Signed-off-by: Peter Maydell Reviewed-by: Eric Blake --- net/net.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/net.c b/net/net.c index 76bbb7c31b4..52c99196c69 100644 --- a/net/net.c +++ b/net/net.c @@ -75,6 +75,8 @@ int parse_host_port(struct sockaddr_in *saddr, const char= *str, const char *addr, *p, *r; int port, ret =3D 0; =20 + memset(saddr, 0, sizeof(*saddr)); + substrings =3D g_strsplit(str, ":", 2); if (!substrings || !substrings[0] || !substrings[1]) { error_setg(errp, "host address '%s' doesn't contain ':' " --=20 2.20.1 From nobody Mon Feb 9 03:31:12 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1628867206812971.8812421665218; Fri, 13 Aug 2021 08:06:46 -0700 (PDT) Received: from localhost ([::1]:58842 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mEYlh-0004Nh-5e for importer@patchew.org; Fri, 13 Aug 2021 11:06:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39974) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mEYkD-0001gE-Qb for qemu-devel@nongnu.org; Fri, 13 Aug 2021 11:05:13 -0400 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:45664) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mEYkC-0003Sf-32 for qemu-devel@nongnu.org; Fri, 13 Aug 2021 11:05:13 -0400 Received: by mail-wr1-x432.google.com with SMTP id v4so6614182wro.12 for ; Fri, 13 Aug 2021 08:05:11 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id h9sm1836361wrv.84.2021.08.13.08.05.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Aug 2021 08:05:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BHlWsE4JPaRi6+IZ5sgTgLjKwD9Y471AteUNq+zIfJ4=; b=p1l4rhOGD8MQzvgCjecYzp8jkIEaLO/l1mnZ4vxVA/ayNb+GTu2xO4BIHAoMwZQTmH fcOUW9EfyXQo/WnoiiFAQ70UOJSbys1t7Lc4MROeo2MRwtR9666KT6S5VKC2I0uiPl4W BoCkwtmXRSqyLGo+cM0KItrHiJmw24yuYIqOQGsFKqzESoJCvVIzcnK3Ifq48i5JmZBn N6rssnXDyJajYszRcEs9EuX2Fm64dD+1m/ufLDxwmXngCeSMmAox+4c3WSnargsFI3X/ tHR/IIanlqth5D69imVUMFMAbjeynRDn0arZ6Yp55lMGSnW+DmIb3MTYh0aHUhPXcNH6 NOdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BHlWsE4JPaRi6+IZ5sgTgLjKwD9Y471AteUNq+zIfJ4=; b=shzmrcYNl/DNke/UDqxHjnKzFuwznjYll7o6PdG7c/G4rYgx9Tt5jgp4uXk3f2Ozr/ 96ctfLyulKF4/9589W8814so6ksc3A2yuLU8nhld3S0Ok8w6QweEeFnOtc6iTTlnb7jW Vi0h+OQhusL1WBXLEvkpNUYpuoLTzZRrNroG9zqv/pnVdYMv/amDrJHUwoKWGPciC7Tm 2kqCJPhn5ieolU3ooeVb7tNYlcTXfozyHzbHeZQum67PfN1KqMwJ45OFUy5RMYW/KGSJ 0gO7DFX8ttwvi2nHrNFTvHxFYmxGnobhdzb54hwCO5wr/U+7ONsf0U+ilQsSHfpBBf/E 9u/A== X-Gm-Message-State: AOAM532p6GB+Wf5qA6v42yXkk1yuM7TZe15oz7+fq8ekPZpJe4K36zvZ zXqumXHp0WhdPPbyAoKppgXI1hNXF0xTUw== X-Google-Smtp-Source: ABdhPJyGX0AC9IRkYhDL1uhsL3iS3J+AFgqjaxZ+stJPHjGrkkbZe34MCe7pBfBXQBLcRAv+lQqtow== X-Received: by 2002:adf:d227:: with SMTP id k7mr3723491wrh.392.1628867110776; Fri, 13 Aug 2021 08:05:10 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PATCH for-6.2 2/4] gdbstub: Zero-initialize sockaddr structs Date: Fri, 13 Aug 2021 16:05:04 +0100 Message-Id: <20210813150506.7768-3-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210813150506.7768-1-peter.maydell@linaro.org> References: <20210813150506.7768-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jason Wang , Eric Blake , Corey Minyard Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1628867207927100001 Content-Type: text/plain; charset="utf-8" Zero-initialize sockaddr_in and sockaddr_un structs that we're about to fill in and pass to bind() or connect(), to ensure we don't leave possible implementation-defined extension fields as uninitialized garbage. Signed-off-by: Peter Maydell Reviewed-by: Eric Blake --- gdbstub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 52bde5bdc97..5d8e6ae3cd9 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -3218,7 +3218,7 @@ static bool gdb_accept_socket(int gdb_fd) =20 static int gdbserver_open_socket(const char *path) { - struct sockaddr_un sockaddr; + struct sockaddr_un sockaddr =3D {}; int fd, ret; =20 fd =3D socket(AF_UNIX, SOCK_STREAM, 0); @@ -3247,7 +3247,7 @@ static int gdbserver_open_socket(const char *path) =20 static bool gdb_accept_tcp(int gdb_fd) { - struct sockaddr_in sockaddr; + struct sockaddr_in sockaddr =3D {}; socklen_t len; int fd; =20 --=20 2.20.1 From nobody Mon Feb 9 03:31:12 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1628867211085388.28806460127146; Fri, 13 Aug 2021 08:06:51 -0700 (PDT) Received: from localhost ([::1]:59302 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mEYll-0004fl-WB for importer@patchew.org; Fri, 13 Aug 2021 11:06:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39992) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mEYkH-0001nN-OA for qemu-devel@nongnu.org; Fri, 13 Aug 2021 11:05:17 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:34327) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mEYkF-0003W4-SZ for qemu-devel@nongnu.org; Fri, 13 Aug 2021 11:05:17 -0400 Received: by mail-wr1-x436.google.com with SMTP id h13so13769116wrp.1 for ; Fri, 13 Aug 2021 08:05:15 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id h9sm1836361wrv.84.2021.08.13.08.05.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Aug 2021 08:05:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=74MGSkRJe7t/wQrF2plR3Xcr6VgTbZNewkJwijPXN6M=; b=ZD92n6Q5cW4QfW2cJL07hSGeIfI5etoQUnS7myMjP0+tMiOwNAzlq1JlzOlBP+KTOA ODB2+1NGRUT2+48eR2X8YFzf9u/Y5kcTafWMh3nNTnf3puAb8QX4FnzybrRhPSgComp/ 8ncN37FH+E8xBrblQIL3hIE17XmUXJAUGGVSIpA0VkntX8RXoLjYgm39o11ysxMmqJXL rdWx3GHhnF45KkxI2nH8OYHmjBQ0I08Z3JSHB4BXdOSNph3rbSsLzfzEWOLJ3bXRvRSl BgI5GIF/uCSOumhFfvtwng2wk5iEZxrjDCcb567B+xyiF4ZXUPL9ftIDR1fXD53fn0j1 wsJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=74MGSkRJe7t/wQrF2plR3Xcr6VgTbZNewkJwijPXN6M=; b=Y7f+s3UyWGjWHQWTTZZ5ZEYfmaB8181WzMBdt87IIixgWZ/R2BveSjVilDGoFTiChN xuYaQ5v0S44VicS/9HI1awaKPx0LTYHqGEehGyvUSj2FHE0HkYVJ5JtCX6wElcnKRhC1 CO1d5FO/L0GvncY/kjjU1W2hReLhZ0ISr02mXJD3coYTlZdo+VqiSQ+C2OzneE3eWSwZ THcQ2RLXLs3YCFcheurHu7Q7GrcFylQaOQq5aIFmXp2Mqmv+oc1VQZ2T7994vAb2K318 iiLi9Fi1V3lpcbn6DatAdEgBoCAnuk/vv5cFNkYU8ybSlNZz/XJNzdv+zKi74/EKUWKR Ty9Q== X-Gm-Message-State: AOAM533aw4dvWBtXKMbmpG2ZnijHsuZzZmSbHZ8vAawTk6RfBUEheoWZ Uy+ivjUihqGEv2tE4w4qMLvq1svpke3u2w== X-Google-Smtp-Source: ABdhPJwpfkVlFShNLPCZHeasDgOTnVY07hnfT69NKn3YsZNt1nbIGWmmP1gr8bs4WLxR0LPMCScwyw== X-Received: by 2002:adf:c549:: with SMTP id s9mr3737139wrf.344.1628867111657; Fri, 13 Aug 2021 08:05:11 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PATCH for-6.2 3/4] tests/qtest/ipmi-bt-test: Zero-initialize sockaddr struct Date: Fri, 13 Aug 2021 16:05:05 +0100 Message-Id: <20210813150506.7768-4-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210813150506.7768-1-peter.maydell@linaro.org> References: <20210813150506.7768-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jason Wang , Eric Blake , Corey Minyard Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1628867212239100003 Content-Type: text/plain; charset="utf-8" Zero-initialize the sockaddr_in struct that we're about to fill in and pass to bind(), to ensure we don't leave possible implementation-defined extension fields as uninitialized garbage. Signed-off-by: Peter Maydell Acked-by: Thomas Huth Reviewed-by: Corey Minyard Reviewed-by: Eric Blake --- tests/qtest/ipmi-bt-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/ipmi-bt-test.c b/tests/qtest/ipmi-bt-test.c index 8492f02a9c3..19612e9405a 100644 --- a/tests/qtest/ipmi-bt-test.c +++ b/tests/qtest/ipmi-bt-test.c @@ -378,7 +378,7 @@ static void test_enable_irq(void) */ static void open_socket(void) { - struct sockaddr_in myaddr; + struct sockaddr_in myaddr =3D {}; socklen_t addrlen; =20 myaddr.sin_family =3D AF_INET; --=20 2.20.1 From nobody Mon Feb 9 03:31:12 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1628867326415357.9811947592642; Fri, 13 Aug 2021 08:08:46 -0700 (PDT) Received: from localhost ([::1]:36574 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mEYnd-0008Oi-Bs for importer@patchew.org; Fri, 13 Aug 2021 11:08:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40002) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mEYkI-0001qv-Rb for qemu-devel@nongnu.org; Fri, 13 Aug 2021 11:05:18 -0400 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:39435) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mEYkG-0003W6-By for qemu-devel@nongnu.org; Fri, 13 Aug 2021 11:05:18 -0400 Received: by mail-wr1-x432.google.com with SMTP id q6so2207970wrv.6 for ; Fri, 13 Aug 2021 08:05:15 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id h9sm1836361wrv.84.2021.08.13.08.05.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Aug 2021 08:05:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jhalmmK6++gWTwtUeGZefnNC1U+Cc5q6S1SHf1iSyOA=; b=pn4AgDNhnpOX7akdxp6+mX5yr3hIq2IwJKgPI/N31fpwF+3Q7mO2KOI6Eb3CTqraPg K4n9zWZ+1S1qv0DbacF66tHTvz6ILYue+iEkCHiaAq9OC+rqlIBJC3saa+kAaUnbdvkP ARhVuUtAY4wVvpk70AwY4CAtbW3M0JXH165upWhb1Lq2gHp3vNmrz9B3lo6bvKpcGh7F uobuDXFNPGOY4jCGBW6HRvxb5/HQxW9Gxv69yD7wx2ewWpOkdi8H12Na9TOZ3Twcx4yj MV9uivBa9otxkFcufO4AU9+oK8MSDjcW9Gysa6aTLklq0P24J+ruPgeQhT/M0uoIsx9f R48w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jhalmmK6++gWTwtUeGZefnNC1U+Cc5q6S1SHf1iSyOA=; b=H4t6pWghL0hO5DmYI5MuKzxjPP5iVpu1NaxlrmILH9W0lUWBfhR1u3pioYRhOUK653 bBjssNu8yvIAxEHIVI6oI+zB0kseYp6GHzqN6XDeXQv6uOszmDAqpdQRCKGr9Eivj9x2 wW6QCr0DQXTd32R2Aybfcr9i3L+4vFsBHALVh5YgEsrr5eKe76j0CZJjk6mKhKLd7DXs zwCmb5hAG3WCsuK5m4ETuvcHHrobmo4TlpPrReM45rXUbiWjTOnMRdjkVzyVm9ZihnII pEPM1GVQq9b4biHNXj8MZGcrjZlB4qw5vmI0aEP5PuFZxpAQnU6eCRArXrh5uKWUhmBb oAiQ== X-Gm-Message-State: AOAM530t5eHonC8Qggg5i8TSPvvq9i4KdpCywXoN5QVqoJwgnFnM84H+ AkOrmD6ik5xVeOo3+l65qgCR2RqUdlN+9w== X-Google-Smtp-Source: ABdhPJyDVX23f7B9WSlIcMpJxAo8NdqyJsxjxEs7BDESxn7Sev7aCW7ojmQJvq32rC81rKKnTqDhQg== X-Received: by 2002:adf:f68d:: with SMTP id v13mr3708616wrp.358.1628867114749; Fri, 13 Aug 2021 08:05:14 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PATCH for-6.2 4/4] tests/tcg/multiarch/linux-test: Zero-initialize sockaddr structs Date: Fri, 13 Aug 2021 16:05:06 +0100 Message-Id: <20210813150506.7768-5-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210813150506.7768-1-peter.maydell@linaro.org> References: <20210813150506.7768-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x432.google.com X-Spam_score_int: -1 X-Spam_score: -0.2 X-Spam_bar: / X-Spam_report: (-0.2 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jason Wang , Eric Blake , Corey Minyard Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1628867327610100005 Content-Type: text/plain; charset="utf-8" Zero-initialize sockaddr_in and sockaddr_un structs that we're about to fill in and pass to bind() or connect(), to ensure we don't leave possible implementation-defined extension fields as uninitialized garbage. Signed-off-by: Peter Maydell Reviewed-by: Eric Blake --- tests/tcg/multiarch/linux-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/tcg/multiarch/linux-test.c b/tests/tcg/multiarch/linux-t= est.c index c8c6aeddeb3..019d8175ca6 100644 --- a/tests/tcg/multiarch/linux-test.c +++ b/tests/tcg/multiarch/linux-test.c @@ -251,7 +251,7 @@ static void test_time(void) static int server_socket(void) { int val, fd; - struct sockaddr_in sockaddr; + struct sockaddr_in sockaddr =3D {}; =20 /* server socket */ fd =3D chk_error(socket(PF_INET, SOCK_STREAM, 0)); @@ -271,7 +271,7 @@ static int server_socket(void) static int client_socket(uint16_t port) { int fd; - struct sockaddr_in sockaddr; + struct sockaddr_in sockaddr =3D {}; =20 /* server socket */ fd =3D chk_error(socket(PF_INET, SOCK_STREAM, 0)); --=20 2.20.1