From nobody Mon Feb 9 23:58:11 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1628168388; cv=none; d=zohomail.com; s=zohoarc; b=TZUwGbzBoRKnsAZh6jqZdbNBaTJeBv8VoMlICWXtKkBFiw0utMHLe+4RDjLPxq74ebTh5AiUkBQx4CsJ+2Q+K3lO2/NXNyinFGWCTdbpJMgHmlaSLNFwo4Ah+k8xAtqzGhtGQxo/2KLjolRk5fxAIkTWeJv5gEQifHx9y+6OSPw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1628168388; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=y6QdzSnjdtvRLRdd79lFYLTkD/1lcOyCDNWgBB23tfY=; b=OaPCiB8N1HiCc+BK4i+tWA8Wh1OC0cK6ZzJCTKzyQGWJyfZFYgILcXJfQoWgsVQRJCXqf/jM6F8KCIH1aquzaIwmkcpdQoDohaOCU3XZXdBNiQgx6uu1y1RVTHI2nl+7aoDPT0msQXPifvUDNFegU5+kWlDjrdJ3jjCWRjOO/j0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16281683883621004.4547352052512; Thu, 5 Aug 2021 05:59:48 -0700 (PDT) Received: from localhost ([::1]:56006 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBcyR-0006Jz-Af for importer@patchew.org; Thu, 05 Aug 2021 08:59:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58858) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBctg-0005Lc-96 for qemu-devel@nongnu.org; Thu, 05 Aug 2021 08:54:52 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:51928) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBcte-000455-Ux for qemu-devel@nongnu.org; Thu, 05 Aug 2021 08:54:52 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-125-kV6RW-MUMf-_fAJhmXvdvQ-1; Thu, 05 Aug 2021 08:54:48 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B1FB18799F7; Thu, 5 Aug 2021 12:54:47 +0000 (UTC) Received: from localhost (unknown [10.39.208.3]) by smtp.corp.redhat.com (Postfix) with ESMTP id 394A610016F2; Thu, 5 Aug 2021 12:54:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628168090; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y6QdzSnjdtvRLRdd79lFYLTkD/1lcOyCDNWgBB23tfY=; b=LuKsJRzRT2kwne2LWxJImYcArFAAO3f6dsE+HKj6pdk93xSkgOMlMycHq8Duy/ZcavBGQU n7Ck8o43iEKLKXBNwQhjzMGGGflfQwIdMVCR3jMlzwv4Irh8XXedxTGgLDRqRSeUUEe8M3 YNOPo40NJc5RwXVyrRkqOCaz6wcCUq8= X-MC-Unique: kV6RW-MUMf-_fAJhmXvdvQ-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Subject: [PULL 8/8] chardev: report a simpler error about duplicated id Date: Thu, 5 Aug 2021 16:53:31 +0400 Message-Id: <20210805125331.826741-9-marcandre.lureau@redhat.com> In-Reply-To: <20210805125331.826741-1-marcandre.lureau@redhat.com> References: <20210805125331.826741-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=marcandre.lureau@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1628168389219100001 From: Marc-Andr=C3=A9 Lureau Report: "Chardev with id 'char2' already exists" Rather than: "Failed to add chardev 'char2': duplicate yank instance" Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Daniel P. Berrang=C3=A9 --- chardev/char.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/chardev/char.c b/chardev/char.c index f59a61774b..4595a8d430 100644 --- a/chardev/char.c +++ b/chardev/char.c @@ -1036,6 +1036,11 @@ ChardevReturn *qmp_chardev_add(const char *id, Chard= evBackend *backend, ChardevReturn *ret; g_autoptr(Chardev) chr =3D NULL; =20 + if (qemu_chr_find(id)) { + error_setg(errp, "Chardev with id '%s' already exists", id); + return NULL; + } + cc =3D char_get_class(ChardevBackendKind_str(backend->type), errp); if (!cc) { goto err; --=20 2.32.0.264.g75ae10bc75