From nobody Mon Feb 9 10:11:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=bu.edu); dmarc=fail(p=none dis=none) header.from=bu.edu ARC-Seal: i=2; a=rsa-sha256; t=1628085491; cv=pass; d=zohomail.com; s=zohoarc; b=eMWEixX4PuF4NHR/1dTbNWkoP4bH6S/4ONi8O3hAj7j36bKmXeFvrlV1H8o6ZgZNqDNzuBSYjiHcCQVbkI+fpvkAjLGvzNhW/FAR+I5LJ/KKNIlrX5zX4nQCr4uDmeisj/dJTotGscNov9hkWAKwXQFYbfS++/R0t7BviVBF4Rw= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1628085491; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=VNWPitBmuNnTVLBrPrV8lcwqk/hdXX0YNs/xd6oaT7U=; b=Y5zwHXExrAwk+4rxF1tmIHF2QlBbFfBxwlg4nKo6zD8SsMfFpOecxKHoHKdHLS8g6QcMzf+Mdx7TpYEVlQ2O9SfZoH0hgpeOf7x7ixhriTB6/YKuD+h0J19+QI0r/hiZfyC8aeCem7xF8CQ3/Rr4ff9u/xr/T/MU80pUgU392c0= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=bu.edu); dmarc=fail header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1628085491942114.18464440914613; Wed, 4 Aug 2021 06:58:11 -0700 (PDT) Received: from localhost ([::1]:48914 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBHPO-0002T1-9X for importer@patchew.org; Wed, 04 Aug 2021 09:58:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54012) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBHO3-0000hK-Ep for qemu-devel@nongnu.org; Wed, 04 Aug 2021 09:56:50 -0400 Received: from mail-dm6nam10on2133.outbound.protection.outlook.com ([40.107.93.133]:31613 helo=NAM10-DM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBHO0-0006zL-Od for qemu-devel@nongnu.org; Wed, 04 Aug 2021 09:56:47 -0400 Received: from SN6PR03MB3871.namprd03.prod.outlook.com (2603:10b6:805:6d::32) by SN6PR03MB3854.namprd03.prod.outlook.com (2603:10b6:805:6e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.20; Wed, 4 Aug 2021 13:56:39 +0000 Received: from SN6PR03MB3871.namprd03.prod.outlook.com ([fe80::24fc:a5d:be8d:eb3f]) by SN6PR03MB3871.namprd03.prod.outlook.com ([fe80::24fc:a5d:be8d:eb3f%3]) with mapi id 15.20.4373.027; Wed, 4 Aug 2021 13:56:39 +0000 Received: from stormtrooper.vrmnet (72.74.210.193) by MN2PR22CA0027.namprd22.prod.outlook.com (2603:10b6:208:238::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.16 via Frontend Transport; Wed, 4 Aug 2021 13:56:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ngsIBf018YmJI9wtu5ljshmDY+jElChDlrgYcOM9YQ8zAbZ+Ae35ChVCLi9Uv9iuIlyFnvJyPQK72rbcCILZ86g8ZMttrOzymo4LjoWexWWxnGeLYHi0nD54g/0sjKKRyRFPBwu+HMX0KaO2TZp2GhBbD8b8RpURTsev7hZAh05FFG767vixn5EH+9VfptpP8VVcZzDC3A4nWEfdYfgIKNM9eZpGT2xakQEzJfPI8zlQb+g4Io0pgJa9uYYqSYVYEJKqcvZbVu587sIR8XBxlm/vW/MGdktT2mp4G8f37Z2lYsBn0KqUDnoABynmtvsP70uBA25UhUK/yTUiF2h9dA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VNWPitBmuNnTVLBrPrV8lcwqk/hdXX0YNs/xd6oaT7U=; b=BLmnsCYnpLuqFmhthvaR52x00qFLA5n0ILfAAmvOFMm5yA16CfluNCdSxjqEDF+qR0KkDQrpabfdDZfEFNxToUQueVNDJ+GKJJwb1rT/UbWKQjz2L3HAHXMUl0uqzbEg5vnIZD2Cx/s1FRw123fVmAf+uBfMMfbZWMiLrgBf13oXGFkju2i3XoNKk36L8SJ3n24FEmX0d7EyFC7WsHG/c9qvux0cf9uEoh5SSLxa7/9eQCD/W0bqeslzoE/gjL07YNe4kMpzeguDbTRA+nzHnB9iDtb9K76dXsxkp77DXRADijRIPWXoXcIQ3kRY8f77XqYqoeYW1WAg8Yx/gLsGSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bu.edu; dmarc=pass action=none header.from=bu.edu; dkim=pass header.d=bu.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bushare.onmicrosoft.com; s=selector2-bushare-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VNWPitBmuNnTVLBrPrV8lcwqk/hdXX0YNs/xd6oaT7U=; b=sRtOQi/hOEZtYuqfw3tJADY4Fyz3XHNbXgTBusIZlq3XghGMsttE42GnDi7gHMnj7xUAV9RNyvxyi51iLTblj/Qk6HdSfXsq5pRScSfMB7wM8ukH27YO1HYcflH7nFXn40N+OMU8BsD7cU+kL5b29ISjNM880Va83p2E5JyC1TI= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=bu.edu; From: Alexander Bulekov To: qemu-devel@nongnu.org Subject: [PATCH 1/2] fuzz: use ITIMER_REAL for timeouts Date: Wed, 4 Aug 2021 09:56:20 -0400 Message-Id: <20210804135621.31455-2-alxndr@bu.edu> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210804135621.31455-1-alxndr@bu.edu> References: <20210804135621.31455-1-alxndr@bu.edu> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN2PR22CA0027.namprd22.prod.outlook.com (2603:10b6:208:238::32) To SN6PR03MB3871.namprd03.prod.outlook.com (2603:10b6:805:6d::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e2c41874-684b-4bb6-4af8-08d9574fae4e X-MS-TrafficTypeDiagnostic: SN6PR03MB3854: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:949; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JT7pAR1PVdgvIAaQSIRGkfVdfgBoPT3aMqmLrdVwOiA4e7sxM4vz4KG/FbvnjnwI+SrEJyEVKIi3mQs8eME9c1HxqJbaePuzWe3l0TZW9rhDqZ2dus/NMWyS44DPbXxP7AIYr/RGw5HFB/ZB+yWZMMQTMWdTqDZJ12+aYGSzG1g1Pbaa3JyPQgf6/qCJR6LSQbgYfn5IfrCiCYUUP/3U5+HoIEeLa3bcr5jSnU50cwNQz2Xvvkuf4BFyaqOnl+t9FN2ZPN3ovwu6IcWUJvV46/E+NU47mcNY1CkIb53Miwl/5CxsKMV6bz0dI8HEYdtyNb4UMTor2pzWg5/Jg+3XwMwxKd6/PJtpvV10f/bV/mSB30ks/PXhoxinDiQ1uJMrZsh231/PieMMYb7Wu0H8J4/s7NE56thL5Ka7eEE1FcJ2+iL2LpHzDwKvg87ki5TMAz3JWWMw06kb2tzznx4L+HWKz45WBz8v5oCgpbLxzF0ZxZVrKuoYRol6eq6haJ9PJufp/WIaP19mg5LP2WZ3AIvv3lrN0lwwAf6FiCY552YQSbsmzRbaJugjKRtbVD4BB5zEn3kU/YQr779K/kKM8eb4GoFxh1QpgAGukNcpLIksxGY39tmZW5R28+P8+cMbRwZZOyGA8Ijba9afDektMQbKiO2oihKuw3USiVV9VckJyLDTzu8Pvu9ERslvyL65KC40yOPL267gjQst206l0w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR03MB3871.namprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(38100700002)(38350700002)(508600001)(6506007)(6512007)(54906003)(8936002)(66556008)(786003)(66946007)(5660300002)(66476007)(26005)(316002)(75432002)(36756003)(956004)(8676002)(83380400001)(52116002)(4326008)(2616005)(1076003)(6916009)(186003)(6666004)(86362001)(2906002)(6486002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TXvph+PvR3Q/Jria+iytU7gMtXaqwlmKz14Xtngu7EX/82Mca4R8F7L2YM9m?= =?us-ascii?Q?gt7yLiQfgka0sbyzNYnb6Uh6tmwgwE9/qxkb5Jr/Yt7cep1HzC1PDztdRZvx?= =?us-ascii?Q?1ZoGRKZwLWeMCXZGFI0DVjtk1MCFMYw2PqEHV7LN9OjlXYGSLLTwgQmicKQE?= =?us-ascii?Q?QL61nJZ9emvv8DvVRuoPaJQBi+Rb2wdZov0NtHmm+aq7Jc+2FbZC1ewFpC8m?= =?us-ascii?Q?5xcwRIhVPH/vGRpHGxW0KCqHmGQhLGkSb27usKlHUsi9MmMtX8VrE7oLKXt3?= =?us-ascii?Q?l8rHsUCbXhh/89MI0+/FXhUljBmyr3vXE/VAk68a5orOAMtDC2V/3RX0+JfO?= =?us-ascii?Q?PjTb/bSBLx8GU5Kv0ddHQUsjJhokMbvbH1d5BwXN40aE4kXFg9GS8HDVAi+p?= =?us-ascii?Q?Q3Cta+g/OCaBt8dWw4EsugaMOBfbNCqp3q62lgGoG01+YnY5OGgoe+8OogJz?= =?us-ascii?Q?Jfdv+QRthDnmmpAGIRaiIJeR5teS3wLK5Mh+bhKhIuOQdOnRIVXQK+P5rX5f?= =?us-ascii?Q?7mbDlHg0d/US5mvwFrpAeJthTS89MNeYXPhq6UlU6alOTgO8Kp/bHYccUNj+?= =?us-ascii?Q?hDexkEFYcoRTu/W6ufKhn/VndmA7HpOjny6L50Nb1H0G4Zp/+TAK0PHjiLjY?= =?us-ascii?Q?cdm/LzmgQD0GXTADWv4+rX+xH/R/4OKZBuLqwW4KzmZ6QidBGGGvInmqRqeK?= =?us-ascii?Q?Q1JB1nlc/tDICHt5gPIDWWhWx1xdcG1gs7oLuzPRVVNN3MXOLiu5rwEfauqG?= =?us-ascii?Q?uMYyjY0g3COqJHGLAaAMYtNg3ZgpJh9ZTIHFiwUpV3i1oO10EIaV92+NrsqL?= =?us-ascii?Q?mhfE0R/M3nLXxj6SWcio7GpRnaVtJ2mwyayn03Ng3/kFkjRRo8uA4AUwH15J?= =?us-ascii?Q?Kd7LC0v59yO4CeYcfCC9UspcP21IdnrFDP0TGgRdX0NqpfgNU7O+18T5BKF7?= =?us-ascii?Q?RoNlkdGeIyAik4u3877pguD96Mtge2XcCPDCjYGNt5V3WzVo/28rrwbq9Byz?= =?us-ascii?Q?yoV5XjwwmjRh3HdTfV7mYZgM5wC79vqOLPdEN0zVPK3a89jFAbNWu31ESnLn?= =?us-ascii?Q?YM17+kqL7oMQOWEY8pP8YcQdbiHf70E49BvsdQ+iYdGBHxHYVlw1MNq4fTHD?= =?us-ascii?Q?RB8ZfYZ9kfDWmDkJAzXfvtWACLfhz0bg+9lFj/yRvVGxwWzoh/rKRDYm7x4W?= =?us-ascii?Q?l8nUP6ap2AslGZnr54CO4JGsZ5PoeUfDfISpkjaw8ibB9fFSjQXWjTY1R2Yn?= =?us-ascii?Q?E6u2kBc6gHhiKsD8qyhUkiITmfUhZk/Wl5Mw+ODQDazMDRDuzlCGoksFGVW2?= =?us-ascii?Q?3L2/npt4MQmJZJua05LcbXpi?= X-OriginatorOrg: bu.edu X-MS-Exchange-CrossTenant-Network-Message-Id: e2c41874-684b-4bb6-4af8-08d9574fae4e X-MS-Exchange-CrossTenant-AuthSource: SN6PR03MB3871.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2021 13:56:39.0643 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: d57d32cc-c121-488f-b07b-dfe705680c71 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J4wP8hybYjB4XlgBkhl9BPXDBjyP1pnf+bJER7Gi+TX4VOcCxwEf7xD0mlYyWcGm X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB3854 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.93.133; envelope-from=alxndr@bu.edu; helo=NAM10-DM6-obe.outbound.protection.outlook.com X-Spam_score_int: 1 X-Spam_score: 0.1 X-Spam_bar: / X-Spam_report: (0.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HK_RANDOM_ENVFROM=0.998, HK_RANDOM_FROM=0.998, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Darren Kenny , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alexander Bulekov , Bandan Das , stefanha@redhat.com, Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @bushare.onmicrosoft.com) X-ZM-MESSAGEID: 1628085493257100001 Content-Type: text/plain; charset="utf-8" Using ITIMER_VIRTUAL is a bad idea, if the fuzzer hits a blocking syscall - e.g. ppoll with a NULL timespec. This causes timeout issues while fuzzing some block-device code. Fix that by using wall-clock time. This might cause inputs to timeout sometimes due to scheduling effects/ambient load, but it is better than bringing the entire fuzzing process to a halt. Based-on: <20210713150037.9297-1-alxndr@bu.edu> Signed-off-by: Alexander Bulekov Reviewed-by: Darren Kenny --- tests/qtest/fuzz/generic_fuzz.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/fuzz/generic_fuzz.c b/tests/qtest/fuzz/generic_fuz= z.c index 3e8ce29227..de427a3727 100644 --- a/tests/qtest/fuzz/generic_fuzz.c +++ b/tests/qtest/fuzz/generic_fuzz.c @@ -695,7 +695,7 @@ static void generic_fuzz(QTestState *s, const unsigned = char *Data, size_t Size) while (cmd && Size) { /* Reset the timeout, each time we run a new command */ if (timeout) { - setitimer(ITIMER_VIRTUAL, &timer, NULL); + setitimer(ITIMER_REAL, &timer, NULL); } =20 /* Get the length until the next command or end of input */ --=20 2.30.2 From nobody Mon Feb 9 10:11:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=bu.edu); dmarc=fail(p=none dis=none) header.from=bu.edu ARC-Seal: i=2; a=rsa-sha256; t=1628085525; cv=pass; d=zohomail.com; s=zohoarc; b=Uoev9Ae3Sg3QkTG6uRHS0GuQjlvaxZINq0ocmGPr9GgEq4xA4drWJn7Qrp1Z9iKYYfvn89P2xZmTUidQA7gt0iVZN3LimWETGqq0dYaOcpnTtlbFPyueTxRcM5ux/9q8WHtP9b+m8fetHK4bdPVjFiiql/+7zyfG3UwC+OdZ8FI= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1628085525; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=JqZvg8+4n6fFzmLglEDEc1931ol06VbYyo0PGmfyLBQ=; b=hT1OIq2mv/HvaEPfN8wDBm0yQox6TqKxyCmXYUIzAeDdRW+oSfN8lSGoVdKUg5qvSAYYExQRoDXoibKRpBpgBoZBWX4uqinOGWU/nOXegBXP39cdBK5qI1wzZfEa82gNf+Dkw1njIpSocYVaR5V7SefZ5f27kPMpfeQtnZB3XLQ= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=bu.edu); dmarc=fail header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1628085525974812.3478752168522; Wed, 4 Aug 2021 06:58:45 -0700 (PDT) Received: from localhost ([::1]:49950 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBHPw-0003CC-Nn for importer@patchew.org; Wed, 04 Aug 2021 09:58:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54144) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBHOX-0001Qr-RP for qemu-devel@nongnu.org; Wed, 04 Aug 2021 09:57:18 -0400 Received: from mail-bn8nam08on2112.outbound.protection.outlook.com ([40.107.100.112]:9952 helo=NAM04-BN8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBHOV-0007M7-C9 for qemu-devel@nongnu.org; Wed, 04 Aug 2021 09:57:17 -0400 Received: from SN6PR03MB3871.namprd03.prod.outlook.com (2603:10b6:805:6d::32) by SN6PR03MB3422.namprd03.prod.outlook.com (2603:10b6:805:4a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.21; Wed, 4 Aug 2021 13:56:40 +0000 Received: from SN6PR03MB3871.namprd03.prod.outlook.com ([fe80::24fc:a5d:be8d:eb3f]) by SN6PR03MB3871.namprd03.prod.outlook.com ([fe80::24fc:a5d:be8d:eb3f%3]) with mapi id 15.20.4373.027; Wed, 4 Aug 2021 13:56:40 +0000 Received: from stormtrooper.vrmnet (72.74.210.193) by MN2PR22CA0027.namprd22.prod.outlook.com (2603:10b6:208:238::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.16 via Frontend Transport; Wed, 4 Aug 2021 13:56:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XfJTAEKjwl+uI5/AM0N35qsWn66SBQXPA2SJFNb2R/QXNonywFL8RbhZsGxgqpb0KhLfx5WTtkm1ye8w5j+XnjzQhQyTcE/tdTogIFyL/dTTFkBTqI/tGt4ULGIwgH7GqjubivBebUycz4MqPvqY5H1Y1rP37BxhwCZPduyaRpNZWVAgIyhDXW/9HtWuK+CzYiVvcMB+jKKqtjiu2q8sqsA+4SJgjR1jmvHqV1axvITPUFkJPOo51VGqguFuViTgVU0x4Jka1/CBwas6bdvg4Ccf6Y6ByHLXXfsnquOz+ZROg1Opw5o2TqtjGtISMWmhDVKVVzu3vebJ2mdRD6Wa9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JqZvg8+4n6fFzmLglEDEc1931ol06VbYyo0PGmfyLBQ=; b=aPpZdIi5G9RG06/hQMpI6IKAZ0deB6LN685nLycwhC9/aqNmfwm0B2RfdZpGxIieFleHSi6mFbFksnhEKo87hcKa6Vpj0z8UJkhMPLcqomHH4uZgTYMBzVC9ZjUn0KStDUte2/U2/p34i4bvefDKmvJS5LOxC3sM2C+gYCeOttump8wA4mGRIbRq8hNneO1UPne3u2gKl7lxp9q12UautHhRs6/u16n0REnmC2uGUMGJJbFExgqted6v2ULoe5xlvfMe4z7iLzUuwwybdUbAZtnu0gpB1oPwNDx3mmIbEGh41NYSfmx3ezFG5SpvU6ZDRFQi0VpQyZCmpB+fS0GbuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bu.edu; dmarc=pass action=none header.from=bu.edu; dkim=pass header.d=bu.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bushare.onmicrosoft.com; s=selector2-bushare-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JqZvg8+4n6fFzmLglEDEc1931ol06VbYyo0PGmfyLBQ=; b=svRq73CixCkFxZjrDqkHAy8j0HCKlYisVMzyHCL5XzCRLcy10pwS1IyqRJLF1wlUAz1LicVAN2ytC6jgG6NMq3QZ3VCNFyEgzETm/CSQApmH+ZFbED8j2kUWIlhXrSMZgNO80Tf01V+PQLiR34qtZYoTX5zec1VvG9Z8sdMR+DE= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=bu.edu; From: Alexander Bulekov To: qemu-devel@nongnu.org Subject: [PATCH 2/2] fuzz: unblock SIGALRM so the timeout works Date: Wed, 4 Aug 2021 09:56:21 -0400 Message-Id: <20210804135621.31455-3-alxndr@bu.edu> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210804135621.31455-1-alxndr@bu.edu> References: <20210804135621.31455-1-alxndr@bu.edu> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN2PR22CA0027.namprd22.prod.outlook.com (2603:10b6:208:238::32) To SN6PR03MB3871.namprd03.prod.outlook.com (2603:10b6:805:6d::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 070b9ecd-3901-499a-91e4-08d9574faef7 X-MS-TrafficTypeDiagnostic: SN6PR03MB3422: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1002; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EIK41fXbpnkLInc5STp455QckAwIe7km62SE1mt6HGhWnuvqSypTW87KobM+3Ef5L8FrhwzHWRfCWSVg+4bVezr+hxGtx4xNtopQwDq9y9T259FE8LSmIYl4ylZb+iTZ4UfHdxcfp54N0qDA/hSJ0mvbZ8hh/JLNUjZAQWOCH5NUFALFhkKE0iLOXoIwvEVTgXsuXTmPkVSnbiS2dXyCi+3jJ/5A0IAD4FzkPg03YnKzkPnsc92jaIQ6HVbHkc/ET0AI52QBQj6rquifd2lCFNQtVy4iHKZxpHmbZ3UZVSO2wHDgfU4bvLxrgAgreb4Y21x2jPatNqgONMSrzDpJ7Fk7v8TOLMSt3La9KaBgaMaxmmFevAttEdMGR7V5Hww4L905uhI63ahKgJamBuu1y5EK1G1RKciVN/Q9ErUFj+VUjsKk1f4I5nJ6yp7DdSTChWueHdBnKDIU8Yl60TQnd6E7OOaEuatRRbaupuqNAhBf1CaPalHGgB7B0tJxBPQnmSciGmOY2+aPd1zYYFBYC4o+pBVqnLeI1GgLeToWaMVHbmNb5r2DXO4FluOq9oAETj7KlOoSGJDrng5rWGbnxZKmnV9WeM/cAr1Xnz8Lg+eDes2xBjGpQMXVn8MBN+EaSO/JECQ7Vc2v33vUidJsQZPiNCKe52lQwfiO3ywDt3hgpTOCJ4jHiCptmaCMijDLhr36IsaeS+btuFVJJpobtw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR03MB3871.namprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(86362001)(8936002)(66946007)(66476007)(186003)(66556008)(8676002)(6666004)(1076003)(26005)(83380400001)(6512007)(6916009)(2616005)(36756003)(956004)(508600001)(38350700002)(2906002)(786003)(316002)(38100700002)(5660300002)(6486002)(54906003)(52116002)(4326008)(75432002)(6506007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ey6wFM0cpwRHOZr5objKI9hxfZ7RJmVUnzv68F47qOtLoarn2dVsU+avr6fy?= =?us-ascii?Q?eiLUan1cxLTf+ikftONK1SvqtT3Mjxc70asxOqbxcLtK2UEfSQ17zr/wAvT8?= =?us-ascii?Q?6ZIa7T498H0TQQklocPvvJmY6xs4XCQNXFe+4uv3v7tlXIGKicqpKnwlWvqO?= =?us-ascii?Q?GQ/gb8PdXQsBa+d67XEYBD+3OMTd2I2o215xT+efr7kGXWiHwS8ilpFSpey8?= =?us-ascii?Q?tL1a4s4dTG0CMMQXYfQyQF7UHPIAA0Dai3RAWGgcGxLy8nhDtwiLlGg98iOP?= =?us-ascii?Q?ZRZBFhU15Y7ia7a86U3bALoLDj4uXZOwYbm9Fp5pW92GxCVLQFYa0iJITsLb?= =?us-ascii?Q?iHFC4ienNrBxeGtju2YxbzSigjm++dLd4jgqqDYeyYvzDvlb53D/WbCSD0zA?= =?us-ascii?Q?ZXEPq7HZB7ELHHKf2hpBptTm2A/vqOBoe+y3T1LIRltIN/4f4BfzZHo5pElV?= =?us-ascii?Q?76E4XAwxgyUtWHOdj/1KeggsxsPgDLJyEJ2Z5KBKUvVHE/RIsU9n2KG7SndI?= =?us-ascii?Q?+kTYIPBq+aI32dD2xsfQMAoM2xCYA2x3cRzrOtIW3f14+GmLraIK561z2ZGz?= =?us-ascii?Q?JGvCZrfW0xWIBaqDMbrq4WbFxtZBR2OgX+qf66hsmle4+CmENXR9oJjWA7zw?= =?us-ascii?Q?/4bVLl7CAk6WLRbZzEdH/TQByOjRfjqhhsVm5Vx+K6mXL3We1TYRDopmhpxm?= =?us-ascii?Q?+BoRjWIrRbJSMBTJd6h3EEBu0zn+PUcNJm20xVj/7BGSEeZMFcR9jxTlijye?= =?us-ascii?Q?C0+2DQDP4PnP+bbBjzfcpl4q0p4Ta3CeCZjsLfzpzVYwLyOqZXVtyYkEM608?= =?us-ascii?Q?srqV4FsTGIviwotZieNJAQwajD8dBMNDNPXvS10BlQ10BMjuaXCEjOlYSdPl?= =?us-ascii?Q?KfKIQUbaCEIEtL5ZkcbFrrnriSnGpeGLoUlq1mu+dnDgSlzOQgEUijy/rWj8?= =?us-ascii?Q?5Z36RnvHhzqbcNPc+SVzDZIg3Pb79UBSdzUHWxFbbc3RC0OcyGC/fzqME8ER?= =?us-ascii?Q?DmLW5C45pJaVoi/lP04XuHAIYO9+k+qr8Rtq63zhryBMQBo9NpeUCdIPUYB4?= =?us-ascii?Q?QmCtYplb0yq2IkqT88SszIUqIzdU/DRSKpze4csvVr4SsgeBn4cWpjEtZJxm?= =?us-ascii?Q?5Ji1xmAuvQhhi/TDKTirQB67DX3y72RwgWqQ4nxz4B+R1EgLrpEd9a5cDcbj?= =?us-ascii?Q?pGIp/BsDlcxx1T437fXQR6gXGQ7m82OdkWkvfbbYfh2Jww8AHzruglsA3jAH?= =?us-ascii?Q?WiG1ZSrqPP+AByIEga7KM6DoV/0O7pUcrJ6OI33utpRLWqtEQIrikh/1D6Ew?= =?us-ascii?Q?JBAZisVaTUWHxAjl0CxFxBA/?= X-OriginatorOrg: bu.edu X-MS-Exchange-CrossTenant-Network-Message-Id: 070b9ecd-3901-499a-91e4-08d9574faef7 X-MS-Exchange-CrossTenant-AuthSource: SN6PR03MB3871.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2021 13:56:40.0508 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: d57d32cc-c121-488f-b07b-dfe705680c71 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tcQtd0ccyZxIl5tXyPEazfUn+llvpUjkJlDBV5uqdbb+de0QJlQtYGb2z5ptNvBh X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB3422 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.100.112; envelope-from=alxndr@bu.edu; helo=NAM04-BN8-obe.outbound.protection.outlook.com X-Spam_score_int: 1 X-Spam_score: 0.1 X-Spam_bar: / X-Spam_report: (0.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HK_RANDOM_ENVFROM=0.998, HK_RANDOM_FROM=0.998, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Darren Kenny , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alexander Bulekov , Bandan Das , stefanha@redhat.com, Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @bushare.onmicrosoft.com) X-ZM-MESSAGEID: 1628085526665100001 Content-Type: text/plain; charset="utf-8" The timeout mechanism wont work if SIGALRM is blocked. This changes unmasks SIGALRM when the timer is installed. This doesn't completely solve the problem, as the fuzzer could trigger some device activity that re-masks SIGALRM. However, there are currently no inputs on OSS-Fuzz that re-mask SIGALRM and timeout. If that turns out to be a real issue, we could try to hook sigmask-type calls, or use a separate timer thread. Based-on: <20210713150037.9297-1-alxndr@bu.edu> Signed-off-by: Alexander Bulekov --- tests/qtest/fuzz/generic_fuzz.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/qtest/fuzz/generic_fuzz.c b/tests/qtest/fuzz/generic_fuz= z.c index de427a3727..dd7e25851c 100644 --- a/tests/qtest/fuzz/generic_fuzz.c +++ b/tests/qtest/fuzz/generic_fuzz.c @@ -670,6 +670,7 @@ static void generic_fuzz(QTestState *s, const unsigned = char *Data, size_t Size) if (fork() =3D=3D 0) { struct sigaction sact; struct itimerval timer; + sigset_t set; /* * Sometimes the fuzzer will find inputs that take quite a long ti= me to * process. Often times, these inputs do not result in new coverag= e. @@ -684,6 +685,10 @@ static void generic_fuzz(QTestState *s, const unsigned= char *Data, size_t Size) sact.sa_handler =3D handle_timeout; sigaction(SIGALRM, &sact, NULL); =20 + sigemptyset(&set); + sigaddset(&set, SIGALRM); + pthread_sigmask(SIG_UNBLOCK, &set, NULL); + memset(&timer, 0, sizeof(timer)); timer.it_value.tv_sec =3D timeout / USEC_IN_SEC; timer.it_value.tv_usec =3D timeout % USEC_IN_SEC; --=20 2.30.2