From nobody Fri May 17 10:34:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) client-ip=209.85.221.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1627742523; cv=none; d=zohomail.com; s=zohoarc; b=GLXjBEFRiJUsjyLtbVL27ISRDaox6s+neFYBspqW8K0vu7mJEC+mBUywiy1Y4Gw2ZbzVgQO0IDjFGr9+N5kFBXpvDMzcHhPMD1WwmQZ/wfwMVISmDQeooSALNx5p82K8E7cNj4GOcoA25UjQkCw5BV0wxmxhjdBWodf6s9pT16w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1627742523; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=v4M5nPwC1MTWjOUzg3TV9gA1jM3JQZR5Hp8aA3e0qkM=; b=NoF2uFAryJiU/+D9oY60N347f5mh3ffi+jaF6dWnnkWUf9NHJWzg4Vq+NCrDIZ1Z70MJ5s9RRKvcksxk5a+azeHok534/jb88E11IsZofgsimqX3Iu/qrMHNhqVgRoFO4m7ovKshPyzOCvxrJWDao8ayb4YUzz+RDxkmUEOkKSg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by mx.zohomail.com with SMTPS id 1627742523336686.4427669147378; Sat, 31 Jul 2021 07:42:03 -0700 (PDT) Received: by mail-wr1-f52.google.com with SMTP id n12so15335938wrr.2 for ; Sat, 31 Jul 2021 07:42:02 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (122.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.122]) by smtp.gmail.com with ESMTPSA id s1sm4957066wmj.8.2021.07.31.07.41.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Jul 2021 07:42:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=v4M5nPwC1MTWjOUzg3TV9gA1jM3JQZR5Hp8aA3e0qkM=; b=MOb7D4zswzP8zwKLIX9VREgM/GWW0afVTbFNMv7P5qy3leT5sXk600B/2UyKdZlSVF PS2yEXu5QF2Q/6va/T+8Q2E1IuDFUGkjk7tlj3qQuOEAODCo9/wPae1I35V+QNDUL60Z NhN4cpuNE0u6xKDNdYKAlsyyeZ/XB0dOS9UPELrusYctvohAcNvijFJwxPakyE3GAiNw LaKy3cwnQdACuC1nLOcIysPN0YHDBdOQpYi+z36ekXsMjyRhIyOPkmaVyjbvh9gBqW5z QhPVhp9CgueW7cmNH729OD81mxOlZGHM5PC5kLTCRtrPThp9KpmqqeDkDSEOA6yUp2La naNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=v4M5nPwC1MTWjOUzg3TV9gA1jM3JQZR5Hp8aA3e0qkM=; b=dFKC4EJDR6t72T43Ke8kP84/J4kLmfZz/W/plVrW2AVbJDEPTIn1yc8p757l4sbR6j CvlCXaZllEFxRdn4iONoyaEL9w9tduybhZpNBU/Z3YJsPfwtPbwDbN6fu9djIle+kF2K kSRxPaq/Nr3QlyR0edB0sCg7QeNthsmGgm9DVnY12e0tEpquxKMUoGFoHXk7SUjhnLw+ wWtT0ir9G62CnwYi32YXmJmSy1cfaGMvqQIB8QeUEoeVN9ZULLhts2U2o1/QNArl4iuP BxAsLvSgjceWDxPIXE4Ov3BSxlf5ydigjrRLgvzERWowPBUC5dT42JFj8htviZ34BhCo NLDg== X-Gm-Message-State: AOAM5301lE1ynmnBYD48zrZ4+JpakjrBsxHOeOJzJnm/zMSHz+OCIxp9 jT5uSp7qc7mY1hKqq0MBENY= X-Google-Smtp-Source: ABdhPJxWoZB56KxN3F/YKiNWuew5Gj+IP7ofs2bWSb9hx6H3E/DQkZqurs+jKLadMH4HBALSJuzxeA== X-Received: by 2002:adf:9d88:: with SMTP id p8mr8811204wre.409.1627742521410; Sat, 31 Jul 2021 07:42:01 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aurelien Jarno , Jiaxun Yang , Aleksandar Rikalo , Huacai Chen , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH-for-6.1?] target/mips: Remove MOVZ/MOVN opcodes from Loongson 2E Date: Sat, 31 Jul 2021 16:41:55 +0200 Message-Id: <20210731144155.2738493-1-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1627742524773100001 Per the "Godson-2E User Manual v0.6", the Loongson 2E processor does not implement the MOVZ/MOVN instructions However it's enhanced version, the STLS2F01 processor, does. See STLS2F01 User Manual (rev 1), chapter 13.1 "The compliance overview": The STLS2F01 processor implements several special MIPS IV instructions as the supplement to the MIPS III instructions. These instructions include two MIPS IV instructions (i.e. MOVZ and MOVNZ) ... Fixes: aa8f40090ab ("target-mips: enable movn/movz on loongson 2E & 2F") Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/tcg/translate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index bf71724f3f0..34a96159d15 100644 --- a/target/mips/tcg/translate.c +++ b/target/mips/tcg/translate.c @@ -14156,8 +14156,7 @@ static void decode_opc_special_legacy(CPUMIPSState = *env, DisasContext *ctx) switch (op1) { case OPC_MOVN: /* Conditional move */ case OPC_MOVZ: - check_insn(ctx, ISA_MIPS4 | ISA_MIPS_R1 | - INSN_LOONGSON2E | INSN_LOONGSON2F); + check_insn(ctx, ISA_MIPS4 | ISA_MIPS_R1 | INSN_LOONGSON2F); gen_cond_move(ctx, op1, rd, rs, rt); break; case OPC_MFHI: /* Move from HI/LO */ --=20 2.31.1