From nobody Sun Feb 8 17:48:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1627635322557195.08626546037192; Fri, 30 Jul 2021 01:55:22 -0700 (PDT) Received: from localhost ([::1]:52566 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m9OIb-0000y0-Im for importer@patchew.org; Fri, 30 Jul 2021 04:55:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42206) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m9OGp-0006zn-DX for qemu-devel@nongnu.org; Fri, 30 Jul 2021 04:53:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:54717) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m9OGn-00072X-Sk for qemu-devel@nongnu.org; Fri, 30 Jul 2021 04:53:31 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-586-ote-O2TUNG24X4uEz2EbWQ-1; Fri, 30 Jul 2021 04:53:26 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0ACAC92503; Fri, 30 Jul 2021 08:53:25 +0000 (UTC) Received: from t480s.redhat.com (unknown [10.39.194.81]) by smtp.corp.redhat.com (Postfix) with ESMTP id A76A460C05; Fri, 30 Jul 2021 08:53:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627635209; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TBY+mAqGioqKKMSOPOr/xV/Fu/kzVNkYe5+whDj4jKM=; b=TKxEvJmokpfI0+f8jeSoYEDGyFAfjxBjE9tasqw9wXiDzKyaXKU+DarJLesJQYRTrUfNqq ozQtjisv1chQrI8/zpcbtWKS2gnpUMsaoRp+dHWZrHNexoeOFd8vyODAQQI9XXNQ83VToP 6ZvybMUWya8WR2vFCvRObJjtN8WIN8k= X-MC-Unique: ote-O2TUNG24X4uEz2EbWQ-1 From: David Hildenbrand To: qemu-devel@nongnu.org Subject: [PATCH v3 1/7] memory: Introduce replay_discarded callback for RamDiscardManager Date: Fri, 30 Jul 2021 10:52:43 +0200 Message-Id: <20210730085249.8246-2-david@redhat.com> In-Reply-To: <20210730085249.8246-1-david@redhat.com> References: <20210730085249.8246-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.717, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , "Michael S. Tsirkin" , Pankaj Gupta , Juan Quintela , David Hildenbrand , "Dr. David Alan Gilbert" , Peter Xu , Marek Kedzierski , Alex Williamson , teawater , Paolo Bonzini , Andrey Gruzdev , Wei Yang Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1627635324204100001 Content-Type: text/plain; charset="utf-8" Introduce replay_discarded callback similar to our existing replay_populated callback, to be used my migration code to never migrate discarded memory. Acked-by: Peter Xu Signed-off-by: David Hildenbrand --- include/exec/memory.h | 21 +++++++++++++++++++++ softmmu/memory.c | 11 +++++++++++ 2 files changed, 32 insertions(+) diff --git a/include/exec/memory.h b/include/exec/memory.h index c3d417d317..93e972b55a 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -537,6 +537,7 @@ static inline void ram_discard_listener_init(RamDiscard= Listener *rdl, } =20 typedef int (*ReplayRamPopulate)(MemoryRegionSection *section, void *opaqu= e); +typedef void (*ReplayRamDiscard)(MemoryRegionSection *section, void *opaqu= e); =20 /* * RamDiscardManagerClass: @@ -625,6 +626,21 @@ struct RamDiscardManagerClass { MemoryRegionSection *section, ReplayRamPopulate replay_fn, void *opaque); =20 + /** + * @replay_discarded: + * + * Call the #ReplayRamDiscard callback for all discarded parts within = the + * #MemoryRegionSection via the #RamDiscardManager. + * + * @rdm: the #RamDiscardManager + * @section: the #MemoryRegionSection + * @replay_fn: the #ReplayRamDiscard callback + * @opaque: pointer to forward to the callback + */ + void (*replay_discarded)(const RamDiscardManager *rdm, + MemoryRegionSection *section, + ReplayRamDiscard replay_fn, void *opaque); + /** * @register_listener: * @@ -669,6 +685,11 @@ int ram_discard_manager_replay_populated(const RamDisc= ardManager *rdm, ReplayRamPopulate replay_fn, void *opaque); =20 +void ram_discard_manager_replay_discarded(const RamDiscardManager *rdm, + MemoryRegionSection *section, + ReplayRamDiscard replay_fn, + void *opaque); + void ram_discard_manager_register_listener(RamDiscardManager *rdm, RamDiscardListener *rdl, MemoryRegionSection *section); diff --git a/softmmu/memory.c b/softmmu/memory.c index bfedaf9c4d..cd86205627 100644 --- a/softmmu/memory.c +++ b/softmmu/memory.c @@ -2076,6 +2076,17 @@ int ram_discard_manager_replay_populated(const RamDi= scardManager *rdm, return rdmc->replay_populated(rdm, section, replay_fn, opaque); } =20 +void ram_discard_manager_replay_discarded(const RamDiscardManager *rdm, + MemoryRegionSection *section, + ReplayRamDiscard replay_fn, + void *opaque) +{ + RamDiscardManagerClass *rdmc =3D RAM_DISCARD_MANAGER_GET_CLASS(rdm); + + g_assert(rdmc->replay_discarded); + rdmc->replay_discarded(rdm, section, replay_fn, opaque); +} + void ram_discard_manager_register_listener(RamDiscardManager *rdm, RamDiscardListener *rdl, MemoryRegionSection *section) --=20 2.31.1