From nobody Sat May 11 19:22:06 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1627575880764485.88774289059745; Thu, 29 Jul 2021 09:24:40 -0700 (PDT) Received: from localhost ([::1]:51366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m98pr-0002cH-LJ for importer@patchew.org; Thu, 29 Jul 2021 12:24:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33530) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m98oZ-0000Mx-2J for qemu-devel@nongnu.org; Thu, 29 Jul 2021 12:23:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:30668) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m98oX-0003yM-EH for qemu-devel@nongnu.org; Thu, 29 Jul 2021 12:23:18 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-284-1K2yLu37Ooq_4fbHz0hNNw-1; Thu, 29 Jul 2021 12:22:57 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 10577800D55; Thu, 29 Jul 2021 16:22:56 +0000 (UTC) Received: from localhost (unknown [10.39.194.40]) by smtp.corp.redhat.com (Postfix) with ESMTP id AA07760875; Thu, 29 Jul 2021 16:22:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627575796; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VDTPop5rVOr45HBczV+F+W1m8XDQUvEf/1x0A1jvx4A=; b=NcUerNLn4wbsCNrFZXvu1AwHowdVXxZ2a6KNyAK+0CU+g6apbWcAQiuoSUP0lEWCFRz+72 Rc+qRiY4v43t+DnQB/lEU3LBEXVBa0qWLYTtwG4359u+JSQXS27xm6RRDGgLGHdLQHRJDa MnxvThkh527ls+onIq17mB1zmimPgxU= X-MC-Unique: 1K2yLu37Ooq_4fbHz0hNNw-1 From: Stefan Hajnoczi To: Peter Maydell , qemu-devel@nongnu.org Subject: [PULL for-6.1 1/3] MAINTAINERS: add Stefano Garzarella as io_uring reviewer Date: Thu, 29 Jul 2021 17:22:37 +0100 Message-Id: <20210729162239.932125-2-stefanha@redhat.com> In-Reply-To: <20210729162239.932125-1-stefanha@redhat.com> References: <20210729162239.932125-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.717, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MIME_BASE64_TEXT=1.741, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, Julia Suvorova , Max Reitz , Stefan Hajnoczi , Aarushi Mehta , Stefano Garzarella Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1627575882717100001 Content-Type: text/plain; charset="utf-8" From: Stefano Garzarella I've been working with io_uring for a while so I'd like to help with reviews. Signed-off-by: Stefano Garzarella Message-Id: <20210728131515.131045-1-sgarzare@redhat.com> Signed-off-by: Stefan Hajnoczi --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 42ac45c3e5..1776d0950b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3257,6 +3257,7 @@ Linux io_uring M: Aarushi Mehta M: Julia Suvorova M: Stefan Hajnoczi +R: Stefano Garzarella L: qemu-block@nongnu.org S: Maintained F: block/io_uring.c --=20 2.31.1 From nobody Sat May 11 19:22:06 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1627575871478610.7659784150092; Thu, 29 Jul 2021 09:24:31 -0700 (PDT) Received: from localhost ([::1]:50724 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m98ph-0002Bf-HM for importer@patchew.org; Thu, 29 Jul 2021 12:24:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33488) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m98oT-000090-0d for qemu-devel@nongnu.org; Thu, 29 Jul 2021 12:23:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:40845) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m98oQ-0003rj-9a for qemu-devel@nongnu.org; Thu, 29 Jul 2021 12:23:11 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-141-CdS8qUppNuyFdQZxkglJPw-1; Thu, 29 Jul 2021 12:23:06 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 727BF1006C81; Thu, 29 Jul 2021 16:23:04 +0000 (UTC) Received: from localhost (unknown [10.39.194.40]) by smtp.corp.redhat.com (Postfix) with ESMTP id 551145D9CA; Thu, 29 Jul 2021 16:22:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627575787; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E70hcumEd06EYROSNanewRw6T+3jhjiFt0oTiqiUHvE=; b=bB9U6H7OELNL2nweWspO6XpPvENBNPwKSkb1jRPROIZOl13qo4OCusSr2lqyvMwQ/jE4eg 2IJbh8pjkY4U5mzc1CJr9n1hHP6EEvmgxh3Z50GwxLbbfYTG4gP6arRmapIQTZUlXVpvUq URBPjhMSp32wdEVtZuGbytOllEG9d/c= X-MC-Unique: CdS8qUppNuyFdQZxkglJPw-1 From: Stefan Hajnoczi To: Peter Maydell , qemu-devel@nongnu.org Subject: [PULL for-6.1 2/3] block/io_uring: resubmit when result is -EAGAIN Date: Thu, 29 Jul 2021 17:22:38 +0100 Message-Id: <20210729162239.932125-3-stefanha@redhat.com> In-Reply-To: <20210729162239.932125-1-stefanha@redhat.com> References: <20210729162239.932125-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.717, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MIME_BASE64_TEXT=1.741, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, Stefan Hajnoczi , Julia Suvorova , Max Reitz , Stefan Hajnoczi , Fabian Ebner , Aarushi Mehta , Stefano Garzarella Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1627575873503100003 Content-Type: text/plain; charset="utf-8" From: Fabian Ebner Linux SCSI can throw spurious -EAGAIN in some corner cases in its completion path, which will end up being the result in the completed io_uring request. Resubmitting such requests should allow block jobs to complete, even if such spurious errors are encountered. Co-authored-by: Stefan Hajnoczi Reviewed-by: Stefano Garzarella Signed-off-by: Fabian Ebner Message-id: 20210729091029.65369-1-f.ebner@proxmox.com Signed-off-by: Stefan Hajnoczi --- block/io_uring.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/block/io_uring.c b/block/io_uring.c index 00a3ee9fb8..dfa475cc87 100644 --- a/block/io_uring.c +++ b/block/io_uring.c @@ -165,7 +165,21 @@ static void luring_process_completions(LuringState *s) total_bytes =3D ret + luringcb->total_read; =20 if (ret < 0) { - if (ret =3D=3D -EINTR) { + /* + * Only writev/readv/fsync requests on regular files or host b= lock + * devices are submitted. Therefore -EAGAIN is not expected bu= t it's + * known to happen sometimes with Linux SCSI. Submit again and= hope + * the request completes successfully. + * + * For more information, see: + * https://lore.kernel.org/io-uring/20210727165811.284510-3-ax= boe@kernel.dk/T/#u + * + * If the code is changed to submit other types of requests in= the + * future, then this workaround may need to be extended to dea= l with + * genuine -EAGAIN results that should not be resubmitted + * immediately. + */ + if (ret =3D=3D -EINTR || ret =3D=3D -EAGAIN) { luring_resubmit(s, luringcb); continue; } --=20 2.31.1 From nobody Sat May 11 19:22:06 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 162757590112178.84505626921816; Thu, 29 Jul 2021 09:25:01 -0700 (PDT) Received: from localhost ([::1]:51848 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m98qC-0002yU-0e for importer@patchew.org; Thu, 29 Jul 2021 12:25:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33558) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m98oa-0000RF-EF for qemu-devel@nongnu.org; Thu, 29 Jul 2021 12:23:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:25866) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m98oY-0003z6-Tt for qemu-devel@nongnu.org; Thu, 29 Jul 2021 12:23:20 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-477-5ep2fEkZMh2DNL7K4_vEnA-1; Thu, 29 Jul 2021 12:23:14 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 85766107465F; Thu, 29 Jul 2021 16:23:13 +0000 (UTC) Received: from localhost (unknown [10.39.194.40]) by smtp.corp.redhat.com (Postfix) with ESMTP id C19955C1D1; Thu, 29 Jul 2021 16:23:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627575798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/g5mE1fbl+WItQyu0tttQvJ+CC+q2rU8VYryBJkZ2uY=; b=aLjHt6K1PC2NsDlPXxDr2zr2TTdVa8AQNMVsV6/cWQEau0dzjEp0FUGbQF3dVgDC3I83as uzU4ohJtcfoZMHyNUfzirlxhyrDaCy5xFEeKAXhfMwUkFYR9aIer/Kjlq17GLTteTII60z nPj2fcx2pamj/CixKqSx/prHGBDAIu8= X-MC-Unique: 5ep2fEkZMh2DNL7K4_vEnA-1 From: Stefan Hajnoczi To: Peter Maydell , qemu-devel@nongnu.org Subject: [PULL for-6.1 3/3] MAINTAINERS: Added myself as a reviewer for the NVMe Block Driver Date: Thu, 29 Jul 2021 17:22:39 +0100 Message-Id: <20210729162239.932125-4-stefanha@redhat.com> In-Reply-To: <20210729162239.932125-1-stefanha@redhat.com> References: <20210729162239.932125-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.717, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, Julia Suvorova , Max Reitz , Stefan Hajnoczi , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aarushi Mehta , Stefano Garzarella Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1627575902925100001 Content-Type: text/plain; charset="utf-8" From: Philippe Mathieu-Daud=C3=A9 I'm interested in following the activity around the NVMe bdrv. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-id: 20210728183340.2018313-1-philmd@redhat.com Signed-off-by: Stefan Hajnoczi --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1776d0950b..a3d598459a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3178,6 +3178,7 @@ F: block/null.c NVMe Block Driver M: Stefan Hajnoczi R: Fam Zheng +R: Philippe Mathieu-Daud=C3=A9 L: qemu-block@nongnu.org S: Supported F: block/nvme* --=20 2.31.1