From nobody Tue Feb 10 01:35:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1627542276196307.46599026958506; Thu, 29 Jul 2021 00:04:36 -0700 (PDT) Received: from localhost ([::1]:45610 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m905q-0006qv-Aa for importer@patchew.org; Thu, 29 Jul 2021 03:04:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41246) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m903A-00044C-TP; Thu, 29 Jul 2021 03:01:49 -0400 Received: from bilbo.ozlabs.org ([203.11.71.1]:46887 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m9037-0002iJ-Lx; Thu, 29 Jul 2021 03:01:48 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 4Gb1fX5Lgnz9sX5; Thu, 29 Jul 2021 17:01:40 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1627542100; bh=qe6Vd5howK2H7l3/sMihCzBl+/mB0ivjbnIClOLBUiY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MoLHa2kUcIWSrlsV7kyICZJ3KO/9Ye4PKP/rs5cNrUWHq06LE+x9CjLfMiKjBGkCK 6ubphEhT74lbNrgiKwmZhAj6mGxBjr/FLRdWZKiLAEVcB8tR+bnCB6rBxhRYoUkXeR +6JFyI2pdZ7AbY9zv6ac5inx1bq2HAC+otbvEAPM= From: David Gibson To: peter.maydell@linaro.org Subject: [PULL 2/5] i2c/smbus_eeprom: Add feature bit to SPD data Date: Thu, 29 Jul 2021 17:01:32 +1000 Message-Id: <20210729070135.422262-3-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210729070135.422262-1-david@gibson.dropbear.id.au> References: <20210729070135.422262-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=203.11.71.1; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard , qemu-devel@nongnu.org, groug@kaod.org, qemu-ppc@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1627542279023100001 Content-Type: text/plain; charset="utf-8" From: BALATON Zoltan Add the differential clock input feature bit to the generated SPD data. Most guests don't seem to care but pegasos2 firmware version 1.2 checks for this bit and stops with unsupported module type error if it's not present. Since this feature is likely present on real memory modules add it in the general code rather than patching the generated SPD data in pegasos2 board only. Signed-off-by: BALATON Zoltan Message-Id: <19d42ade295d5297aa624a9eb757b8df18cf64d6.1626367844.git.balato= n@eik.bme.hu> Acked-by: Corey Minyard Signed-off-by: David Gibson --- hw/i2c/smbus_eeprom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c index 4d2bf99207..12c5741f38 100644 --- a/hw/i2c/smbus_eeprom.c +++ b/hw/i2c/smbus_eeprom.c @@ -276,7 +276,7 @@ uint8_t *spd_data_generate(enum sdram_type type, ram_ad= dr_t ram_size) spd[18] =3D 12; /* ~CAS latencies supported */ spd[19] =3D (type =3D=3D DDR2 ? 0 : 1); /* reserved / ~CS latencies su= pported */ spd[20] =3D 2; /* DIMM type / ~WE latencies */ - /* module features */ + spd[21] =3D (type < DDR2 ? 0x20 : 0); /* module features */ /* memory chip features */ spd[23] =3D 0x12; /* clock cycle time @ medium CAS latency */ /* data access time */ --=20 2.31.1