From nobody Tue Feb 10 11:23:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1627395895; cv=none; d=zohomail.com; s=zohoarc; b=hYVvbfc3n5THt+DY+ZQr1nI04d48HHbn99CUkDa2hUW0diXd393qTKf8hLX6r2LcrnPsDjJIlaGBRfCFoP9xnfLS5LCTvI2gnoIzEoWw9nNOT0FMluh6UkuhpDGUCfgee2poS/cXl8ffAYxcM5YbCnrgqBtNQ3m7iumDNaKRRYg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1627395895; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=5skV1VcH8VE4F7YVyHyIQxPMq2PPLQR3Z673qUopZ2M=; b=iYwmZasHx3iIO+8qq1jsCPtLZM0s7xei74zz/PiILO+MlA06+kNBt0kGgvJLttGKmBZFZXgoCrleoy/9eLFG5BgP5icmKXr5xI5YhmCwDqBCYVUbV1rcZKsWje1NCdHU5M+1IKsX5KGg5e6ZMaKE1nJv4g91qqhSzPL6/3rv+jc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1627395895116466.6013374619074; Tue, 27 Jul 2021 07:24:55 -0700 (PDT) Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-191-x6HiB65xPfG3c6TZ51kDtw-1; Tue, 27 Jul 2021 10:24:52 -0400 Received: by mail-wr1-f72.google.com with SMTP id o8-20020a5d4a880000b029013a10564614so6071635wrq.15 for ; Tue, 27 Jul 2021 07:24:52 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (122.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.122]) by smtp.gmail.com with ESMTPSA id f26sm3570962wrd.41.2021.07.27.07.24.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jul 2021 07:24:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627395894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5skV1VcH8VE4F7YVyHyIQxPMq2PPLQR3Z673qUopZ2M=; b=PUMHguDD5oYYFjknj1KXms06VU61Qxd9+kczJg1z+reeCz82I4xKMbnMda3620M2/muM2v o+3ltlW9fySUesVjaHfM3DxKGYlELorJ10zGp+x6zrUhK4oLgCpWtLV/hDeQwip3ymQ+x/ U9MWsqXczx1rOHeFHqMlOqVv7BoL3pc= X-MC-Unique: x6HiB65xPfG3c6TZ51kDtw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5skV1VcH8VE4F7YVyHyIQxPMq2PPLQR3Z673qUopZ2M=; b=O5oSFWVje7IgrArSJueVDQWC/3a4LjTPG5o0oUp63PP42aS/KhMMmgMBIg4CfudUUd w98pYnUx/41n7AOIH4aaoq7bVkFJUvyNSMsT9JpRsv1TXhxRTCeroxiqgDRH/W/uiK4n ks12RIYvYkfbeQZJW43Sdw9QrweF2C/odEHkTNIsCYu277jMYvKDRLniKJxEyPBNfrl/ sjbEBGz7jtLGDVmYFHgelu6hbE42f5CUUu6EYB89YaQLjPPsmMg+db39RAqQet+ICR9A YhylQ91fzdlVwKOS9VwtbELqyiHPmGjX7sVsBdHbnmly5YrcR3jvroJNXdH4hDYiX3PN COPw== X-Gm-Message-State: AOAM533O5wof1TOiuwq+IxJjsyQDJ5ddXCfAEvC60/qXjMEG9MASBO2W 6JjcCUeq/tv0Sl01vzWpVWoajf0r8q4fejVbBDHcFhn+7PL1ryZ3YzQg+vBaL33pixp4Nkjo1l0 ol0P5J9lhy+th6w== X-Received: by 2002:a5d:4251:: with SMTP id s17mr9858702wrr.154.1627395891803; Tue, 27 Jul 2021 07:24:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy58mqYnHRsuUNSk2O9DTDkT0ZtECoN18xtbcvhs3sMaVtjuZpC14erUuTv8PgRS3g9/MDewQ== X-Received: by 2002:a5d:4251:: with SMTP id s17mr9858691wrr.154.1627395891675; Tue, 27 Jul 2021 07:24:51 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Thomas Huth , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= Subject: [PATCH-for-6.1 v5 4/4] gitlab-ci: Fix 'when:' condition in OpenSBI jobs Date: Tue, 27 Jul 2021 16:24:31 +0200 Message-Id: <20210727142431.1672530-5-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210727142431.1672530-1-philmd@redhat.com> References: <20210727142431.1672530-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1627395895781100001 Jobs depending on another should not use the 'when: always' condition, because if a dependency failed we should not keep running jobs depending on it. The correct condition is 'when: on_success'. Fixes: c6fc0fc1a71 ("gitlab-ci.yml: Add jobs to build OpenSBI firmware bina= ries") Reported-by: Daniel P. Berrang=C3=A9 Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Willian Rampazzo --- .gitlab-ci.d/opensbi.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.gitlab-ci.d/opensbi.yml b/.gitlab-ci.d/opensbi.yml index d8a0456679e..5e0a2477c5d 100644 --- a/.gitlab-ci.d/opensbi.yml +++ b/.gitlab-ci.d/opensbi.yml @@ -6,14 +6,14 @@ - .gitlab-ci.d/opensbi.yml # or the Dockerfile is modified - .gitlab-ci.d/opensbi/Dockerfile - when: always + when: on_success - changes: # or roms/opensbi/ is modified (submodule updated) - roms/opensbi/* - when: always + when: on_success - if: '$CI_COMMIT_REF_NAME =3D~ /^opensbi/' # or the branch/tag starts wi= th 'opensbi' - when: always + when: on_success - if: '$CI_COMMIT_MESSAGE =3D~ /opensbi/i' # or last commit description c= ontains 'OpenSBI' - when: always + when: on_success =20 docker-opensbi: extends: .opensbi_job_rules --=20 2.31.1