From nobody Tue Feb 10 01:31:55 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1627395895; cv=none; d=zohomail.com; s=zohoarc; b=Lgy0wBjxWUehgOEmCml13FdEDwwwSqQUGQ80vWeIArmrjvk9qhxaTj81AZ4siZ2eu6wBJ5pbu36Mg7/p0F7BdU+LCPDzsrqYSKggrCvW9I7z21GPJ6Swt2UWh6zUAB8phDEiOTtQJh/5OF/ZoGMLL11pmUtTWoCvGALhBLbKn8A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1627395895; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=MMJrXb+PFcst+HWZFJy2pURo7XBZnh85p1BTZSd8Zaw=; b=VEvIh919In0D6x/Yx4XeKI6NiZwBjzvoKdhinPQ/EySsUyA8SbARgRHGb0Dydgan07UHGFdFbkO1QnwwosJXkLo9UIAgm912KnmJgLc1+YvCpYypZztXQ5E9yaGd2OU0y8F0zHFRrSxymS+K3o5PZ+87i2bDB+kSRydCYrg62HU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 162739589509454.855182097013085; Tue, 27 Jul 2021 07:24:55 -0700 (PDT) Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-183-mXq7wXwtMZ-rKnc8ZpmOsg-1; Tue, 27 Jul 2021 10:24:48 -0400 Received: by mail-wm1-f69.google.com with SMTP id n7-20020a05600c3b87b029024e59a633baso1438207wms.5 for ; Tue, 27 Jul 2021 07:24:48 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (122.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.122]) by smtp.gmail.com with ESMTPSA id a8sm3273803wmj.8.2021.07.27.07.24.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jul 2021 07:24:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627395894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MMJrXb+PFcst+HWZFJy2pURo7XBZnh85p1BTZSd8Zaw=; b=QO+aFXZGa+bYSIf1tf5l7Ag9xawz7rC+km/yuFF2MSjQttrOwgzUUF8jdop/SbEeJq63/W PlpwFasVijcWSVNztIWIB2G5EMEZexS+RjEmWmw244ugrl7uadVT1+OSPZagmUn+Nws11V FxG6GMJabEuOxoGKDqY9nFqrtYKtsio= X-MC-Unique: mXq7wXwtMZ-rKnc8ZpmOsg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MMJrXb+PFcst+HWZFJy2pURo7XBZnh85p1BTZSd8Zaw=; b=KtBlPZxtJm0ykkJzJM2638924xL865GI6pUjQokxhazuQ0JshQG6/w0+che4OZ7+VE s2fWP72olwJT4jo8BBc80UIzvEpGWGGrlQWVyMg7S+5dY/dSTFr84kNeRmmQM7vjWcz8 dQzRSLCu/P18mTgU3zHHRVMZaQNK3S9+pqujDDCQ10z9aqETCswLp4tH8YdVTxrZKPaZ WD2wM6zMj0BDMePE4vepn4MPzb4A0W9Abr0r6an7ijPZSuiSPCzeaLlLDld7EJB2QZhT 57zAgIY9VSfFlSHAKddC7bSr5egYl2urj6JougYGp9q5o4MsBaYsnZqhmQG6lnGT86Rj RAKw== X-Gm-Message-State: AOAM532J12HZkee0ua0fVHGkphrzsc17j2UZx0PL0nzSBsHm/D+yEFNg vJGdJQEWGFsG05r330JGGw3G7Rg3LzdjCTfEAjVJWiQGsFkZZOMQoYTqYOomQ2qY4G+zg3hJBcR /RCgeZOtk/QZfPA== X-Received: by 2002:a05:600c:4f4d:: with SMTP id m13mr4522406wmq.31.1627395887441; Tue, 27 Jul 2021 07:24:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzuE4bSib957DNFW9/g8fLZdVoDUnKyzOOKvoqS1O7Li7n97dr2AZ/o0zPFOTAVx4J5xyk+eQ== X-Received: by 2002:a05:600c:4f4d:: with SMTP id m13mr4522391wmq.31.1627395887334; Tue, 27 Jul 2021 07:24:47 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Thomas Huth , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Willian Rampazzo Subject: [PATCH-for-6.1 v5 3/4] gitlab-ci: Fix 'when:' condition in EDK2 jobs Date: Tue, 27 Jul 2021 16:24:30 +0200 Message-Id: <20210727142431.1672530-4-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210727142431.1672530-1-philmd@redhat.com> References: <20210727142431.1672530-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1627395895782100002 Jobs depending on another should not use the 'when: always' condition, because if a dependency failed we should not keep running jobs depending on it. The correct condition is 'when: on_success'. Fixes: 71920809cea ("gitlab-ci.yml: Add jobs to build EDK2 firmware binarie= s") Reported-by: Daniel P. Berrang=C3=A9 Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Willian Rampazzo Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- .gitlab-ci.d/edk2.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.gitlab-ci.d/edk2.yml b/.gitlab-ci.d/edk2.yml index aae2f7ad880..62497ba47fb 100644 --- a/.gitlab-ci.d/edk2.yml +++ b/.gitlab-ci.d/edk2.yml @@ -8,11 +8,11 @@ - .gitlab-ci.d/edk2/Dockerfile # or roms/edk2/ is modified (submodule updated) - roms/edk2/* - when: always + when: on_success - if: '$CI_COMMIT_REF_NAME =3D~ /^edk2/' # or the branch/tag starts with = 'edk2' - when: always + when: on_success - if: '$CI_COMMIT_MESSAGE =3D~ /edk2/i' # or last commit description cont= ains 'EDK2' - when: always + when: on_success =20 docker-edk2: extends: .edk2_job_rules --=20 2.31.1