From nobody Mon Feb 9 17:36:07 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1627395886; cv=none; d=zohomail.com; s=zohoarc; b=ZsbaQ7GdX6oFUVGMGcHmLrmHep5bhaAHcS290ferFr7iNJF6AtbkbvAQSScg3D/zRR4NJr0DMpkVu9zTodEblyy9CVfgrZ+GKm+TvQIVErxZCgJNLiv5aJzLMoWerbdnn6FzjvjKT30oAwXxAj6kbFO/nmR7N+kMtS5WGvaM6sw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1627395886; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=I3f5VWr0dv08m9hk8YYT+1REocG8ozdjKKxl8Jc6Yx0=; b=CR5Uljn/197R0YHwkVI1OXHhaiweCMw4YTV8JXE8kdQb/vlgUdzqr457bgu99WRgVLBtoDzBopwJFLmxQ6beRHY8FR9cn2a6X31pNJ/979jEKYTZBywLXTWgWUR4sI1Meyhnwt1oEd3aaaUO8a9VCLdRKDmA0ROD/n+pNSEBNno= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1627395886356280.5903405721783; Tue, 27 Jul 2021 07:24:46 -0700 (PDT) Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-515-iHtoTCM2MPuYEgmA-ALlfQ-1; Tue, 27 Jul 2021 10:24:44 -0400 Received: by mail-wm1-f69.google.com with SMTP id n17-20020a7bc5d10000b0290228d7e174f1so1046146wmk.0 for ; Tue, 27 Jul 2021 07:24:44 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (122.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.122]) by smtp.gmail.com with ESMTPSA id i5sm3406249wrw.13.2021.07.27.07.24.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jul 2021 07:24:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627395885; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I3f5VWr0dv08m9hk8YYT+1REocG8ozdjKKxl8Jc6Yx0=; b=Psu5dcBTfo3GWX4blw4X6sU4xrrWLWmvYcAK7WnP36NRFxyhj6bmlS1FpL6KxlpUKtW73v maVq332uJA0udGPqw/OGrGD53WnLHAY8gke0HvuvS77dyGXoGyhYVPkYFkOdKAXRS1Mrrv 0j8orD0ihQNLINQB3XZr8My+TzH8tMg= X-MC-Unique: iHtoTCM2MPuYEgmA-ALlfQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=I3f5VWr0dv08m9hk8YYT+1REocG8ozdjKKxl8Jc6Yx0=; b=sgZMZ5287KI0dljC4cdAFn8INy+KIK4WtmXc5c0Wl5KJmYU63cVHpSXMQOvns5oUW1 XfjheL9wOiyNoxI1IN3+fUt79Yhgz/9Y3rhXGuDjAT5chhy8rYrXlImrxz/iIohr9p8W ZwiWI7GpU5bRR5E9o8prBC5QgBUcyY6F+0M/2BKnFWdtYEFxyUir+S8AaUr4AKJgGLrp HucgBtVWK+PYCspN3LT5KCwxXoGaA4LET4FB30CbwEubUzJgODQ+f88Ub9B9+fNIr1Td nuQzaQbqpAiho5SfVCoK9c10oCj1U2b3z213icyTp+iS61Ce0IxS0UHxN9GlXHyzC3iW JDkw== X-Gm-Message-State: AOAM5320+cwQze+LZgfTHz7az23BDFoJUcw5kiRkil1UNBKuIR1a6Ey/ zd6i0sCuSp9ORU3zmITrEjGsMJZRSbOplJoie9kULyMzeO+P5cEnzIaZYnb4VnqWDfMshjGDlaN mD2FL30Ng3SSChg== X-Received: by 2002:a1c:a510:: with SMTP id o16mr19672127wme.176.1627395883023; Tue, 27 Jul 2021 07:24:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyu6NTNnFCWbA6QW9ELUDqbopzmm80tdaGb0t9D1WlxPogIsAlZCRC+eyYCWwiNnimURM4rpQ== X-Received: by 2002:a1c:a510:: with SMTP id o16mr19672111wme.176.1627395882898; Tue, 27 Jul 2021 07:24:42 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Thomas Huth , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Willian Rampazzo Subject: [PATCH-for-6.1 v5 2/4] gitlab-ci: Fix 'when:' condition in acceptance_test_job_template Date: Tue, 27 Jul 2021 16:24:29 +0200 Message-Id: <20210727142431.1672530-3-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210727142431.1672530-1-philmd@redhat.com> References: <20210727142431.1672530-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1627395888308100001 Jobs depending on another should not use the 'when: always' condition, because if a dependency failed we should not keep running jobs depending on it. The correct condition is 'when: on_success'. Fixes: f56bf4caf71 ("gitlab: Run Avocado tests manually (except mainstream = CI)") Reported-by: Daniel P. Berrang=C3=A9 Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Willian Rampazzo Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- .gitlab-ci.d/buildtest-template.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.d/buildtest-template.yml b/.gitlab-ci.d/buildtest-t= emplate.yml index 3e3e19d96bd..fcbcc4e627a 100644 --- a/.gitlab-ci.d/buildtest-template.yml +++ b/.gitlab-ci.d/buildtest-template.yml @@ -73,9 +73,9 @@ # in its namespace setting or via git-push option, see documentation # in /.gitlab-ci.yml of this repository). - if: '$CI_PROJECT_NAMESPACE =3D=3D "qemu-project"' - when: always + when: on_success - if: '$QEMU_CI_AVOCADO_TESTING' - when: always + when: on_success # Otherwise, set to manual (the jobs are created but not run). - when: manual allow_failure: true --=20 2.31.1