From nobody Mon Feb 9 12:43:11 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1627327832316671.8715345505908; Mon, 26 Jul 2021 12:30:32 -0700 (PDT) Received: from localhost ([::1]:57278 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m86J4-0005N4-V5 for importer@patchew.org; Mon, 26 Jul 2021 15:30:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43338) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m868Q-0004fK-90; Mon, 26 Jul 2021 15:19:30 -0400 Received: from new1-smtp.messagingengine.com ([66.111.4.221]:41785) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m868N-0007n0-OJ; Mon, 26 Jul 2021 15:19:30 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 0045A580411; Mon, 26 Jul 2021 15:19:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 26 Jul 2021 15:19:27 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 26 Jul 2021 15:19:24 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm3; bh=Zu/rZACoGrJMQ vsq5CXXPNYtt/8U/uQ6Gucb6dmydZA=; b=XuzEI/+wLfztVg5p/EC2y5SPB/Tf+ EbMMSEDrc6lQYZOMu1yQuQYjV0jlXzuig/xTkIhA5bYRc0EMiHrZ/+0AVFsfCAtJ KjuJnYif502smO0pTaYu+Ca1DAOJDZQ1/laqS2xKU1U5xM4FoPnpBC01BWGcIIq8 DRS74FTA67lguayZB6T1p77tVXP8GkPaJA/Mxaw9IJeL5fBuFPSXUTX+9wC7vD9L Gb4mV1QvsP4LNhAlAoSjGo5NRXI/xiVysYJVqQDd3lZJTXN6p1TAXqmUG6O2TzAa otHm6FVOLOhQR+LM7TCBH/smYHzCJ+2fp9Xl3flOdSD2ErD0zlAzmzWCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=Zu/rZACoGrJMQvsq5CXXPNYtt/8U/uQ6Gucb6dmydZA=; b=CM1KVaLS c9BWPMBY3lAJDQ9qOQV0xkPe+TCJuf5qIp2vGk6HsCf3CS7v2EN+VyJz+smxfRvf XNiHQXhZNjf4pjBPZfdPqvkN55a2iOn/kw24QSsbo1JxrEB4z2AG/CNvC1e+t9ML OprBbWw1j1wC/HS67bfiXaSmoqPr5c26RHbiIjVXwz5i7mb0qhl6I49KHWNiqJTt +M7HP4zSlovYpV3iZeXafzORGPeV9IiTL4pRy+CtE3+hUIAqk2Zmm81Gzshlqnbq ieN0JIGff0b33ui0L/2lffVQZRjcZLfcawu21HXCVmPN5Zg15SMXmyvCvo4z3+0b Jb/R8kbmwD9uvg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrgeehgddufedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefmlhgruhhs ucflvghnshgvnhcuoehithhssehirhhrvghlvghvrghnthdrughkqeenucggtffrrghtth gvrhhnpeeuleetgeeiuefhgfekfefgveejiefgteekiedtgfdtieefhfdthfefueffvefg keenucevlhhushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehith hssehirhhrvghlvghvrghnthdrughk X-ME-Proxy: From: Klaus Jensen To: Peter Maydell , qemu-devel@nongnu.org Subject: [PULL for-6.1 05/11] tests/qtest/nvme-test: add persistent memory region test Date: Mon, 26 Jul 2021 21:18:55 +0200 Message-Id: <20210726191901.4680-6-its@irrelevant.dk> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210726191901.4680-1-its@irrelevant.dk> References: <20210726191901.4680-1-its@irrelevant.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=66.111.4.221; envelope-from=its@irrelevant.dk; helo=new1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Laurent Vivier , Thomas Huth , qemu-block@nongnu.org, Klaus Jensen , Gollu Appalanaidu , Max Reitz , Keith Busch , Stefan Hajnoczi , Klaus Jensen , Paolo Bonzini , Fam Zheng Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZM-MESSAGEID: 1627327833312100001 Content-Type: text/plain; charset="utf-8" From: Gollu Appalanaidu This will test the PMR functionality. Signed-off-by: Gollu Appalanaidu Reviewed-by: Klaus Jensen [k.jensen: replaced memory-backend-file with memory-backend-ram] Signed-off-by: Klaus Jensen --- tests/qtest/nvme-test.c | 61 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 60 insertions(+), 1 deletion(-) diff --git a/tests/qtest/nvme-test.c b/tests/qtest/nvme-test.c index d32c953a3824..47e757d7e2af 100644 --- a/tests/qtest/nvme-test.c +++ b/tests/qtest/nvme-test.c @@ -13,6 +13,7 @@ #include "libqos/libqtest.h" #include "libqos/qgraph.h" #include "libqos/pci.h" +#include "include/block/nvme.h" =20 typedef struct QNvme QNvme; =20 @@ -66,12 +67,65 @@ static void nvmetest_oob_cmb_test(void *obj, void *data= , QGuestAllocator *alloc) g_assert_cmpint(qpci_io_readl(pdev, bar, cmb_bar_size - 1), !=3D, 0x44= 332211); } =20 +static void nvmetest_pmr_reg_test(void *obj, void *data, QGuestAllocator *= alloc) +{ + QNvme *nvme =3D obj; + QPCIDevice *pdev =3D &nvme->dev; + QPCIBar pmr_bar, nvme_bar; + uint32_t pmrcap, pmrsts; + + qpci_device_enable(pdev); + pmr_bar =3D qpci_iomap(pdev, 4, NULL); + + /* Without Enabling PMRCTL check bar enablemet */ + qpci_io_writel(pdev, pmr_bar, 0, 0xccbbaa99); + g_assert_cmpint(qpci_io_readb(pdev, pmr_bar, 0), !=3D, 0x99); + g_assert_cmpint(qpci_io_readw(pdev, pmr_bar, 0), !=3D, 0xaa99); + + /* Map NVMe Bar Register to Enable the Mem Region */ + nvme_bar =3D qpci_iomap(pdev, 0, NULL); + + pmrcap =3D qpci_io_readl(pdev, nvme_bar, 0xe00); + g_assert_cmpint(NVME_PMRCAP_RDS(pmrcap), =3D=3D, 0x1); + g_assert_cmpint(NVME_PMRCAP_WDS(pmrcap), =3D=3D, 0x1); + g_assert_cmpint(NVME_PMRCAP_BIR(pmrcap), =3D=3D, 0x4); + g_assert_cmpint(NVME_PMRCAP_PMRWBM(pmrcap), =3D=3D, 0x2); + g_assert_cmpint(NVME_PMRCAP_CMSS(pmrcap), =3D=3D, 0x1); + + /* Enable PMRCTRL */ + qpci_io_writel(pdev, nvme_bar, 0xe04, 0x1); + + qpci_io_writel(pdev, pmr_bar, 0, 0x44332211); + g_assert_cmpint(qpci_io_readb(pdev, pmr_bar, 0), =3D=3D, 0x11); + g_assert_cmpint(qpci_io_readw(pdev, pmr_bar, 0), =3D=3D, 0x2211); + g_assert_cmpint(qpci_io_readl(pdev, pmr_bar, 0), =3D=3D, 0x44332211); + + pmrsts =3D qpci_io_readl(pdev, nvme_bar, 0xe08); + g_assert_cmpint(NVME_PMRSTS_NRDY(pmrsts), =3D=3D, 0x0); + + /* Disable PMRCTRL */ + qpci_io_writel(pdev, nvme_bar, 0xe04, 0x0); + + qpci_io_writel(pdev, pmr_bar, 0, 0x88776655); + g_assert_cmpint(qpci_io_readb(pdev, pmr_bar, 0), !=3D, 0x55); + g_assert_cmpint(qpci_io_readw(pdev, pmr_bar, 0), !=3D, 0x6655); + g_assert_cmpint(qpci_io_readl(pdev, pmr_bar, 0), !=3D, 0x88776655); + + pmrsts =3D qpci_io_readl(pdev, nvme_bar, 0xe08); + g_assert_cmpint(NVME_PMRSTS_NRDY(pmrsts), =3D=3D, 0x1); + + qpci_iounmap(pdev, nvme_bar); + qpci_iounmap(pdev, pmr_bar); +} + static void nvme_register_nodes(void) { QOSGraphEdgeOptions opts =3D { .extra_device_opts =3D "addr=3D04.0,drive=3Ddrv0,serial=3Dfoo", .before_cmd_line =3D "-drive id=3Ddrv0,if=3Dnone,file=3Dnull-co://= ," - "file.read-zeroes=3Don,format=3Draw", + "file.read-zeroes=3Don,format=3Draw " + "-object memory-backend-ram,id=3Dpmr0," + "share=3Don,size=3D8", }; =20 add_qpci_address(&opts, &(QPCIAddress) { .devfn =3D QPCI_DEVFN(4, 0) }= ); @@ -83,6 +137,11 @@ static void nvme_register_nodes(void) qos_add_test("oob-cmb-access", "nvme", nvmetest_oob_cmb_test, &(QOSGra= phTestOptions) { .edge.extra_device_opts =3D "cmb_size_mb=3D2" }); + + qos_add_test("pmr-test-access", "nvme", nvmetest_pmr_reg_test, + &(QOSGraphTestOptions) { + .edge.extra_device_opts =3D "pmrdev=3Dpmr0" + }); } =20 libqos_init(nvme_register_nodes); --=20 2.32.0