From nobody Mon Feb 9 15:10:25 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1627311896; cv=none; d=zohomail.com; s=zohoarc; b=K+Lq/3h8qO/zoKvA7lHXInRx7N7wJR+LNZMBoS3dJy2lTid0LRT7BX8O5hvto6LNbEFgmsyyoxoLysg+JRd0hwyZxCisVvUYMeuDSDuLnUKCf3QJfRLTq+J6YNRi1E5BZC6DD3PCmB/rr86KoGmr6LphxHd/fEfZSon7ITwqPpQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1627311896; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=5skV1VcH8VE4F7YVyHyIQxPMq2PPLQR3Z673qUopZ2M=; b=V83jDemH2WbpbiaGEjXJQNOp4yWeeDaLErSD8MWmzHtajtjY3NbDx4SQq5KmNBnvTcM4+nRj8MExcwlXta61MRG0hKmRWGnQToOkuPx20GYSyvmigIbgJ65gsAwiwueiZW5hZmoCmRtuFm8zmLYRY+e08p8PD9mLBoZfBQxvNbY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1627311896457866.5324172057109; Mon, 26 Jul 2021 08:04:56 -0700 (PDT) Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-583-af-pEqepPYqff_AW70O8rQ-1; Mon, 26 Jul 2021 11:04:50 -0400 Received: by mail-wm1-f71.google.com with SMTP id o32-20020a05600c5120b0290225ef65c35dso2781448wms.2 for ; Mon, 26 Jul 2021 08:04:49 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (122.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.122]) by smtp.gmail.com with ESMTPSA id n8sm60671wrx.46.2021.07.26.08.04.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jul 2021 08:04:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627311895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5skV1VcH8VE4F7YVyHyIQxPMq2PPLQR3Z673qUopZ2M=; b=QrU1/duwR6XZrogM+5a+rZb8+34IxZpnaAKiY9DSp9UtyjBkEIEQuhnh6SOJIGNMdsJb7r emh/EP+wAkZtxnO9vxRgCLErLDImV1wDZ22VpzfuR61iBx7I9EZvNJrj5hwUZ/rTkwUK4+ iQX8WEWPJtCAYV6AGemaiaeXyFIV6b4= X-MC-Unique: af-pEqepPYqff_AW70O8rQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5skV1VcH8VE4F7YVyHyIQxPMq2PPLQR3Z673qUopZ2M=; b=Q0yDE5X+TO17i2mPaiYijyO9r4ucMp9wyw/Ck5shHSKMJEAfWVDVnorsQTHtcFoxK1 wcMJlEPk8+aEHUd/PXCffpzxLClVNLhgYsnNHc8N+s04cFuoiFJ0MbwrItuCqkuC1Nm7 ZM/XjVMWKbowKDK/RTnUcTEbUcJfHQQeOvwPaAa+aCElOyTVnD8ciCNbUPfJI7SzIbeu HrD8HOCefBUy/MeJbLrXVp9paJ9rghReVEOqhC+WNkUpi3IWuGoZydr/pSsMV3FSZncN kwncYNm2a2oaxRpBPYunC1u6HFfeQ4hFH/amNi/ttOH/p2TKFAuLdwpzmguUC5pZ1gjJ RO4g== X-Gm-Message-State: AOAM5307cnqfIF8wCPqK9Eq8c9zklTEJ6nRxVtN/3mcwBj0ZIJwvLoMJ PGE0I+fdHbSJ1ODxkch+0/5cKvq4MtynJgOmW6CbkYrjKODy4cNiRkc48a967ecxLajNtvyVvQV bT1hbSDZ3nVlskw== X-Received: by 2002:adf:b30a:: with SMTP id j10mr2474472wrd.43.1627311888846; Mon, 26 Jul 2021 08:04:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxCyVd4Xu3V4StsmyhTHLNVh4wmghvK1JPqN34fMgmMCmKPt1MwkX0m+9F4LcR0rXCn8wa1Ug== X-Received: by 2002:adf:b30a:: with SMTP id j10mr2474449wrd.43.1627311888713; Mon, 26 Jul 2021 08:04:48 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Thomas Huth , Bin Meng , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= Subject: [PATCH-for-6.1 v4 4/4] gitlab-ci: Fix 'when:' condition in OpenSBI jobs Date: Mon, 26 Jul 2021 17:04:29 +0200 Message-Id: <20210726150429.1216251-5-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210726150429.1216251-1-philmd@redhat.com> References: <20210726150429.1216251-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1627311898584100001 Jobs depending on another should not use the 'when: always' condition, because if a dependency failed we should not keep running jobs depending on it. The correct condition is 'when: on_success'. Fixes: c6fc0fc1a71 ("gitlab-ci.yml: Add jobs to build OpenSBI firmware bina= ries") Reported-by: Daniel P. Berrang=C3=A9 Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- .gitlab-ci.d/opensbi.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.gitlab-ci.d/opensbi.yml b/.gitlab-ci.d/opensbi.yml index d8a0456679e..5e0a2477c5d 100644 --- a/.gitlab-ci.d/opensbi.yml +++ b/.gitlab-ci.d/opensbi.yml @@ -6,14 +6,14 @@ - .gitlab-ci.d/opensbi.yml # or the Dockerfile is modified - .gitlab-ci.d/opensbi/Dockerfile - when: always + when: on_success - changes: # or roms/opensbi/ is modified (submodule updated) - roms/opensbi/* - when: always + when: on_success - if: '$CI_COMMIT_REF_NAME =3D~ /^opensbi/' # or the branch/tag starts wi= th 'opensbi' - when: always + when: on_success - if: '$CI_COMMIT_MESSAGE =3D~ /opensbi/i' # or last commit description c= ontains 'OpenSBI' - when: always + when: on_success =20 docker-opensbi: extends: .opensbi_job_rules --=20 2.31.1