From nobody Mon Feb 9 16:18:37 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1627311888; cv=none; d=zohomail.com; s=zohoarc; b=efAwqtDTjNIpw5wRMNCYF5dNOk/KG37SkQn9Glh6G07RnS+6H+zf5I120wfscas86Ph8q9RdLqfzGjMPT16Tj9EjsqWNL4z89+a5HwkPRGTKi7Z2wE4q2l8gHlX+KFH4qpDoYHqMM3zWkizE+MTQrep4DbZJekQ/yJFCcFcq6sw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1627311888; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=A7WQ+gfdcuOck7JznttPPPqym0HvZVkv947pTW1KIp4=; b=eLroFRzMy68oEBl5snoFzK7JjNdKjIPizw/qLDa5JHFtUA9HoM3XNHNEUXv9uzcWIGXj9LogSShrxy1wUcm2Xbslb8zmSWdOROnRkHqPXU2iN9pbLOIGu3asXmi9ILzrTonnZ0OmShaIkEA6TsiMlpAE4AxsCVp7eHBDdvQV3V0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1627311888045717.7455066240749; Mon, 26 Jul 2021 08:04:48 -0700 (PDT) Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-237-NSUgXR25OPSzX0WXGKZWEg-1; Mon, 26 Jul 2021 11:04:45 -0400 Received: by mail-wm1-f71.google.com with SMTP id j11-20020a05600c190bb02902190142995dso2781549wmq.4 for ; Mon, 26 Jul 2021 08:04:45 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (122.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.122]) by smtp.gmail.com with ESMTPSA id v2sm59634wro.48.2021.07.26.08.04.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jul 2021 08:04:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627311887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A7WQ+gfdcuOck7JznttPPPqym0HvZVkv947pTW1KIp4=; b=O0y0z7obbrB66WlJ+PEks0vIOkge+Us/yqCp7HLsLn8Wt2THWMoFE/5q9Zk5EXGtMoE78E f25qcR1v6kQzH8vQb6wuU5kKDx0k1yuEMqXfxVgVfjshl/nHfj3XDZS72Da4YDMUA/32D3 OeZ6I2zLc1ur8vacRMPfxKeSCkRrtfI= X-MC-Unique: NSUgXR25OPSzX0WXGKZWEg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=A7WQ+gfdcuOck7JznttPPPqym0HvZVkv947pTW1KIp4=; b=YDcb9t56uGpKfM3BydQdGRGxljHXLdkd5Mjr6bGmW5cZkmNFPOU6UdFzwmsQA04C7V UJGTtdum0xyRvS2SJLL3BPlIY/ijmRZ3gnGPEuuscsD4NA2eq0upIfNBLikvRzLMougc Wivppp965mejjYcS8rebdiWbdmMPUhnIa1Di0MicXsv4cH4LHqICNWidXo6zmp6FIx9n 7xhl8Ht7UO+pLyfBB0xUYP4Ng420hn8U3mxLBRbeSJL9VIGHY/QNSO5//tnYf0/WUt6e Kq2bSMAKB7c/J6U5q4+udidQpOyKRyEZIyiAH8yDJPUwG14GoP1OXUwv/otO7v+BKdQm NKpg== X-Gm-Message-State: AOAM530iKHPHoq4xpoQgqxK+WFArXLDGoxvvxPIbAPyHRFG8yAen7f8I kDuqyUZwJtQAokeMZqeFYqXH2vKMmzvBNoWGz9ZUAj7VK6D8cHNI0zJRRybJqPJqcTMWwQe6xqG Xvr9PqRS2G+429g== X-Received: by 2002:a7b:c3c5:: with SMTP id t5mr14424971wmj.28.1627311884642; Mon, 26 Jul 2021 08:04:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzXjXb+R7tEwfKRUpeZm9BCLsfS5rQb1GV8yggX8D1Y4JUTy4fa8mEhCINtKXteMug3qt2f/A== X-Received: by 2002:a7b:c3c5:: with SMTP id t5mr14424963wmj.28.1627311884512; Mon, 26 Jul 2021 08:04:44 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Thomas Huth , Bin Meng , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= Subject: [PATCH-for-6.1 v4 3/4] gitlab-ci: Fix 'when:' condition in EDK2 jobs Date: Mon, 26 Jul 2021 17:04:28 +0200 Message-Id: <20210726150429.1216251-4-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210726150429.1216251-1-philmd@redhat.com> References: <20210726150429.1216251-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1627311888836100001 Jobs depending on another should not use the 'when: always' condition, because if a dependency failed we should not keep running jobs depending on it. The correct condition is 'when: on_success'. Fixes: 71920809cea ("gitlab-ci.yml: Add jobs to build EDK2 firmware binarie= s") Reported-by: Daniel P. Berrang=C3=A9 Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth Reviewed-by: Willian Rampazzo --- .gitlab-ci.d/edk2.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.gitlab-ci.d/edk2.yml b/.gitlab-ci.d/edk2.yml index aae2f7ad880..62497ba47fb 100644 --- a/.gitlab-ci.d/edk2.yml +++ b/.gitlab-ci.d/edk2.yml @@ -8,11 +8,11 @@ - .gitlab-ci.d/edk2/Dockerfile # or roms/edk2/ is modified (submodule updated) - roms/edk2/* - when: always + when: on_success - if: '$CI_COMMIT_REF_NAME =3D~ /^edk2/' # or the branch/tag starts with = 'edk2' - when: always + when: on_success - if: '$CI_COMMIT_MESSAGE =3D~ /edk2/i' # or last commit description cont= ains 'EDK2' - when: always + when: on_success =20 docker-edk2: extends: .edk2_job_rules --=20 2.31.1