From nobody Tue Feb 10 11:17:09 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1627216148; cv=none; d=zohomail.com; s=zohoarc; b=FSiom2bc9T/wipZcfaznLmaNpyqnE+svgWQ6YuEu0GYTJ9R+6YNwIix5ZL8snJ50oTWk+mLgzBNv+ygyCr6QpHuCtna9wr5xd8/VnXB65kAng8V6sejd55xmIS+lFGuP0u/mlk8+Ij4Afija9JB+5X55y8HQ6HPEDUzhG0+5s0o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1627216148; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=jfHnxKO+h/7J4Tm9ly0oXqhrTY2aGD6lpNPS47bAq0Y=; b=B1yfFiEh7FHMFIPYuT7hAr9Kihd9/GlDlcsB5jgLB/EQu6i93xcbsVMQeWy/NjWhQlIgrJtzJVE70EEhiloqEpoqZ3BJlGvzt+zf4msC6RiEGFj+gt160kLJNRWk2Wu+girZwJZfIUdnUtBNITWEt9njzRL9YZH7E8YOrVAPUYQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1627216148109753.9607398654585; Sun, 25 Jul 2021 05:29:08 -0700 (PDT) Received: from localhost ([::1]:53510 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7dFj-0004H0-2d for importer@patchew.org; Sun, 25 Jul 2021 08:29:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51580) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7dBF-0000ae-99 for qemu-devel@nongnu.org; Sun, 25 Jul 2021 08:24:29 -0400 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]:42768) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m7dBD-0003oG-RV for qemu-devel@nongnu.org; Sun, 25 Jul 2021 08:24:29 -0400 Received: by mail-pl1-x634.google.com with SMTP id i1so8387950plr.9 for ; Sun, 25 Jul 2021 05:24:27 -0700 (PDT) Received: from cloudburst.home (2603-800c-3202-ffa7-497b-6ae4-953c-7ad1.res6.spectrum.com. [2603:800c:3202:ffa7:497b:6ae4:953c:7ad1]) by smtp.gmail.com with ESMTPSA id k37sm15005093pgm.84.2021.07.25.05.24.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Jul 2021 05:24:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jfHnxKO+h/7J4Tm9ly0oXqhrTY2aGD6lpNPS47bAq0Y=; b=xDfJQsnk/1lpEGEfiYyzLvkPOqNVm2cDua1hLaMF9cPdQRfDfMrIGp57UYz896VVYe jZf2bGz1IkQXwohHs3y76NJsa9/QY3NOYL1Juu9uaSmBF/WRJSZYyQpG4q5K7Spkm2t9 95DxTmbf7gYDza/zw5VkVQAbQ3gseJOXrFSP5rQK9Y/wj3a1ZvklHEQgotNgSWah59I3 wpyIXeAJBvZQ4iHeWr/+3HOg3IlLNq12hOkro/ExIV+00joBCs2coR8hhJSiTDsyjCOR nA+1eOe7xre2eS0DPXfLPGD5ezdkq3mlqIovVS1Fe0IjnuD1eoZzQv0wLrSQlhAg7ppH 1uhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jfHnxKO+h/7J4Tm9ly0oXqhrTY2aGD6lpNPS47bAq0Y=; b=lzGVpiSZHs8yO6KkgTP0nPJ4a2P8U6p2ISEMXNhhRk93N01zTIfQl/ekB54dee7AYd +VI23ZgpVNKp/owEICPpvYY4AvbuT68tAZPRQFo5xUSF0H9Law4cDH2hf2j2YySOYVGg LiyVXlwNSTnLvQB8M+uppr3tPYPkDEbASatvIHkeNTAdUN92wnHrCjJdKhJ6VqW3Egi9 u/KLIRCW48FfoAcKMoB/+ADbN5uM5bJP1t97/O5on4eQn+D96GFkARN5l073SXA+gi77 eQ5634bt+UIKjbEfy7HcpA1Au/g4eBsyYSHz0BmKrylZNHW/2KnDGk4Emfh3DI+GS5kn /ZDQ== X-Gm-Message-State: AOAM5302mafx5FowcKLS13vOqA6hdaJdNokpTVE/zHR+pv8PggudxUsM lVTBPPnSG/xfPg7zW7MIZ5HU7zV3o1HNLg== X-Google-Smtp-Source: ABdhPJxVw0hUlsgO/9kcl4KntMNMdZkciqqCT2oSVKy4c0l9cbFE/fbdV+EzCzZymc8C3OwfcIOuyg== X-Received: by 2002:a63:ef4c:: with SMTP id c12mr13544003pgk.441.1627215866662; Sun, 25 Jul 2021 05:24:26 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH for-6.1? v2 7/9] hw/pci-hist/pnv_phb4: Fix typo in pnv_phb4_ioda_write Date: Sun, 25 Jul 2021 02:24:14 -1000 Message-Id: <20210725122416.1391332-8-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210725122416.1391332-1-richard.henderson@linaro.org> References: <20210725122416.1391332-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::634; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1627216148553100001 Content-Type: text/plain; charset="utf-8" From clang-13: hw/pci-host/pnv_phb4.c:375:18: error: variable 'v' set but not used \ [-Werror,-Wunused-but-set-variable] It's pretty clear that we meant to write back 'v' after all that computation and not 'val'. Acked-by: David Gibson Signed-off-by: Richard Henderson Acked-by: Benjamin Herrenschmidt Reviewed-by: C=C3=A9dric Le Goater --- hw/pci-host/pnv_phb4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c index 54f57c660a..5c375a9f28 100644 --- a/hw/pci-host/pnv_phb4.c +++ b/hw/pci-host/pnv_phb4.c @@ -392,7 +392,7 @@ static void pnv_phb4_ioda_write(PnvPHB4 *phb, uint64_t = val) v &=3D 0xffffffffffff0000ull; v |=3D 0x000000000000cfffull & val; } - *tptr =3D val; + *tptr =3D v; break; } case IODA3_TBL_MBT: --=20 2.25.1