From nobody Fri May 10 00:56:10 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1626991874618121.39256215145178; Thu, 22 Jul 2021 15:11:14 -0700 (PDT) Received: from localhost ([::1]:45182 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6guP-00007W-Li for importer@patchew.org; Thu, 22 Jul 2021 18:11:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42748) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6gtX-0007Bb-7v for qemu-devel@nongnu.org; Thu, 22 Jul 2021 18:10:19 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:39338) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m6gtU-00064E-Gp for qemu-devel@nongnu.org; Thu, 22 Jul 2021 18:10:18 -0400 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 155611FF3B; Thu, 22 Jul 2021 22:10:15 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 1D10F139A1; Thu, 22 Jul 2021 22:10:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id mBxENMTs+WCsZgAAGKfGzw (envelope-from ); Thu, 22 Jul 2021 22:10:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1626991815; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oDoF/q8MYGcAqL+kAmI3q0NXY6ygaIbRg8VgZ0aYJdA=; b=KZ6B8ACmJOSOiurmSGU7OCwCXJqHTxAGBGBXW7LbnTGrfLi8Ep3OTex7KDNHSzsLX4JkHV Niqqt9sRK74Scp2XnSYPEi7kc+AE942LBH0qyVu82/rYg41C1UJrHpVwbaI5htAkKyyuGl gf83taYffp5dBSa9egxU0KFD4lM5qJk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1626991815; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oDoF/q8MYGcAqL+kAmI3q0NXY6ygaIbRg8VgZ0aYJdA=; b=pIDDjM7rb7GjTvxWisVlKGxkO/F3qflEMMRg7lGGS5P2zv7/nTb18KdaPTUNfAddNGNMx7 bVef9CXxf3reBsCQ== From: "Jose R. Ziviani" To: qemu-devel@nongnu.org Subject: [PATCH v2 1/1] modules: Improve error message when module is not found Date: Thu, 22 Jul 2021 19:09:52 -0300 Message-Id: <20210722220952.17444-2-jziviani@suse.de> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210722220952.17444-1-jziviani@suse.de> References: <20210722220952.17444-1-jziviani@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=195.135.220.29; envelope-from=jziviani@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, "Jose R. Ziviani" , richard.henderson@linaro.org, kraxel@redhat.com, cfontana@suse.de Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZM-MESSAGEID: 1626991875708100001 Content-Type: text/plain; charset="utf-8" When a module is not found, specially accelerators, QEMU displays a error message that not easy to understand[1]. This patch improves the readability by offering a user-friendly message[2]. This patch also moves the accelerator ops check to runtine (instead of the original g_assert) because it works better with dynamic modules. [1] qemu-system-x86_64 -accel tcg ERROR:../accel/accel-softmmu.c:82:accel_init_ops_interfaces: assertion fail= ed: (ops !=3D NULL) Bail out! ERROR:../accel/accel-softmmu.c:82:accel_init_ops_interfaces: assertion failed: (ops !=3D NULL) 31964 IOT instruction (core dumped) ./qemu-system-x86_64 ... [2] qemu-system-x86_64 -accel tcg accel-tcg-x86_64 module is missing, install the package or config the libra= ry path correctly. Signed-off-by: Jose R. Ziviani --- accel/accel-softmmu.c | 5 ++++- util/module.c | 14 ++++++++------ 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/accel/accel-softmmu.c b/accel/accel-softmmu.c index 67276e4f52..52449ac2d0 100644 --- a/accel/accel-softmmu.c +++ b/accel/accel-softmmu.c @@ -79,7 +79,10 @@ void accel_init_ops_interfaces(AccelClass *ac) * all accelerators need to define ops, providing at least a mandatory * non-NULL create_vcpu_thread operation. */ - g_assert(ops !=3D NULL); + if (ops =3D=3D NULL) { + exit(1); + } + if (ops->ops_init) { ops->ops_init(ops); } diff --git a/util/module.c b/util/module.c index 6bb4ad915a..268a8563fd 100644 --- a/util/module.c +++ b/util/module.c @@ -206,13 +206,10 @@ static int module_load_file(const char *fname, bool m= ayfail, bool export_symbols out: return ret; } -#endif =20 bool module_load_one(const char *prefix, const char *lib_name, bool mayfai= l) { bool success =3D false; - -#ifdef CONFIG_MODULES char *fname =3D NULL; #ifdef CONFIG_MODULE_UPGRADES char *version_dir; @@ -300,6 +297,9 @@ bool module_load_one(const char *prefix, const char *li= b_name, bool mayfail) =20 if (!success) { g_hash_table_remove(loaded_modules, module_name); + fprintf(stderr, "%s module is missing, install the " + "package or config the library path " + "correctly.\n", module_name); g_free(module_name); } =20 @@ -307,12 +307,9 @@ bool module_load_one(const char *prefix, const char *l= ib_name, bool mayfail) g_free(dirs[i]); } =20 -#endif return success; } =20 -#ifdef CONFIG_MODULES - static bool module_loaded_qom_all; =20 void module_load_qom_one(const char *type) @@ -384,4 +381,9 @@ void qemu_load_module_for_opts(const char *group) {} void module_load_qom_one(const char *type) {} void module_load_qom_all(void) {} =20 +bool module_load_one(const char *prefix, const char *lib_name, bool mayfai= l) +{ + return false; +} + #endif --=20 2.32.0