From nobody Sat May 18 21:16:06 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626938965; cv=none; d=zohomail.com; s=zohoarc; b=gUPlS4YzJoWrWGNZzlghu3PP6RUU7PJ6Cgg7yVVMS6wBnXbZmX0jknjGWkEVA8OlUFocs+94Tbaph1lYh/OvqbwGcxn/UqpwwjlPPRfi3mWBxG4PILVIDLrbPZW7wGOrEcGGIAqgH4MBvuAQ+tzaFs+32p1ZLzuOUDQq0J9AMDI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626938965; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=O2hQ93LY7EH2va1oPR66FR5O25vZGvwoFpk+WC+x/jE=; b=hlATfEkgI/A/eAscY1uPUD8HC0T7oadPOk62YpXTCdnPaMpBtjZY+GXYye6QrqBANZ3WnzxDdnEL2CQV3v78XacFmsiV8RSTxiJrEPtWd+yNtaJrj5wzeioqsazrpMJXK52aEk3Y8AbMyqOHJw0fA/le2OyVot96EAcAG6B4a5E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1626938965049646.5923365052658; Thu, 22 Jul 2021 00:29:25 -0700 (PDT) Received: from localhost ([::1]:51966 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6T92-0006n3-3G for importer@patchew.org; Thu, 22 Jul 2021 03:29:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49520) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6T7s-00065F-FW for qemu-devel@nongnu.org; Thu, 22 Jul 2021 03:28:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:54279) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6T7m-0000dn-46 for qemu-devel@nongnu.org; Thu, 22 Jul 2021 03:28:10 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-196-CuKlWSiuPxegbq1mJRarvw-1; Thu, 22 Jul 2021 03:28:02 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 108ED100E421 for ; Thu, 22 Jul 2021 07:28:02 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-114-106.ams2.redhat.com [10.36.114.106]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4CF3817C5F; Thu, 22 Jul 2021 07:27:58 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id B636A18000B2; Thu, 22 Jul 2021 09:27:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626938884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=O2hQ93LY7EH2va1oPR66FR5O25vZGvwoFpk+WC+x/jE=; b=hISW2RL4LvFEGKx996krC2Kne+fgjED1Wvyel1vqCbnkqDCKdLiXtIJpt0+56SmmBxL0aP btTYoiqtxYNYLQmIzZSvLeZ0ibhP2uCfuJgfAMPdglxhTST1ywjHjM3pOMlKwzzPWlTbNP DDEUM8DpwfHqat3Q99JDTv6FgkRv7dU= X-MC-Unique: CuKlWSiuPxegbq1mJRarvw-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PATCH] usbredir: fix free call Date: Thu, 22 Jul 2021 09:27:56 +0200 Message-Id: <20210722072756.647673-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.459, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626938966682100001 Content-Type: text/plain; charset="utf-8" data might point into the middle of a larger buffer, there is a separate free_on_destroy pointer passed into bufp_alloc() to handle that. It is only used in the normal workflow though, not when dropping packets due to the queue being full. Fix that. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/491 Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-Andr=C3=A9 Lureau --- hw/usb/redirect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index 4ec9326e0582..1ec909a63a80 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/redirect.c @@ -476,7 +476,7 @@ static int bufp_alloc(USBRedirDevice *dev, uint8_t *dat= a, uint16_t len, if (dev->endpoint[EP2I(ep)].bufpq_dropping_packets) { if (dev->endpoint[EP2I(ep)].bufpq_size > dev->endpoint[EP2I(ep)].bufpq_target_size) { - free(data); + free(free_on_destroy); return -1; } dev->endpoint[EP2I(ep)].bufpq_dropping_packets =3D 0; --=20 2.31.1