From nobody Mon Feb 9 18:19:51 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626795734; cv=none; d=zohomail.com; s=zohoarc; b=lDCdXtgQpWFWrIbOW2dguEsKiCKqT88CS9YN1wynXy4cxF2knHkMDcPHOkmZzEkw9a4i91sHszIhOUrd16Rk86APmrvBLZ+3z7MAym+khejSVy0vmf/UxDunFDeJDNIdu+9+F6+sOvR8+p1A4F631N+A6wmXn1JjMMstff9LtZY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626795734; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=gVsmVb/ANphJ5S6TeR3I6otvtOxp3iNritQAJ9GWeeA=; b=DK+D2V1utK067B8xv/SeosjGE5S9O5uC0XScqIOWZHvSop58xDAqKU4TZR0pxrWKoheTC4haqGeDwa00/QH/8QCaXAhnP4htvlSSTCtSYmhSQSkMSUQKeKTzoxVmoAM+5lx8xQKlrSFXUzjv60lkdco30+JT4+2y6NTrWEEgr38= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1626795734773142.8478582695791; Tue, 20 Jul 2021 08:42:14 -0700 (PDT) Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-442-0-y-JCOeOGuK-blFENI1qQ-1; Tue, 20 Jul 2021 11:42:10 -0400 Received: by mail-wr1-f69.google.com with SMTP id z6-20020a5d4c860000b029013a10564614so10495057wrs.15 for ; Tue, 20 Jul 2021 08:42:09 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (122.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.122]) by smtp.gmail.com with ESMTPSA id u2sm2883016wmm.37.2021.07.20.08.42.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 08:42:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626795733; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gVsmVb/ANphJ5S6TeR3I6otvtOxp3iNritQAJ9GWeeA=; b=Kr85Z/Yix59hG0MGlM3KIdAJwvtmUO+AaEKTHv0O4NtR6MaJR6yFPqv0h5GSD4hGGvzhgQ AvOJHXiIiDA6UZDK7Rgt+vRXVXgGoF8XHgqnqeHiEpTsj/IkuBzk5APxYSP85mIjbiMMcO 0qgU3/EfFEG7m/s7RF2ROtwsdQKHhyw= X-MC-Unique: 0-y-JCOeOGuK-blFENI1qQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gVsmVb/ANphJ5S6TeR3I6otvtOxp3iNritQAJ9GWeeA=; b=B2V03+CSJY2ufQ60YjIuGMwDZnmL3WCsnOz1yvKbxt1mR3yHU/Dl5qTD09QAVihbjZ lGo2AUvfukD6ySFI3YUzFjptAKLZAxYpXJW+p7d8GdkH0oVXL9EZWCL8uUm6aOmn5L9v AvE9RUUOfKX/6MnmCZGgrFjs+Oe9VepK5dXKTUqmmBn02SYtY+R46P9fynZnZBPI+2hO ff72NBEp5SSOE0qKBMDHlfbYL+GfaprQo8ok+hEaj8b7H9JtfKFY7LUXBP6v5Hpbd1Lq /RKDLrFZ/yThnUmynnjhf0z9tdylaQPg/Ij0haiAhGPjXnAupzPGq1rP37CsJ7jSRqtJ 6Ytw== X-Gm-Message-State: AOAM531qvq3deEm8Ad9MmBD/Fgek9Oo/X9nuJJ2bhu8x5LHPkuXDLQww ZdNG4O/EIOE/5sHDz1OYV/q68OcUe7/QuwlwmzE4nKgwUl+B8+/+Or1ZswvIt7gm1FmE4/jpKYl O7e+wROAOHqpUEw== X-Received: by 2002:a05:600c:22d8:: with SMTP id 24mr31861283wmg.157.1626795729062; Tue, 20 Jul 2021 08:42:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzlYzqcxpa7L8cQPJUqD0oXsOL6CLPFZmqvGCI59zo3XJr8ThRCFW9dscya4hK4HM3mq2OnUw== X-Received: by 2002:a05:600c:22d8:: with SMTP id 24mr31861272wmg.157.1626795728838; Tue, 20 Jul 2021 08:42:08 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , Bin Meng , John Snow Subject: [PULL 06/17] hw/ide/Kconfig: Add missing dependency PCI -> IDE_QDEV Date: Tue, 20 Jul 2021 17:41:30 +0200 Message-Id: <20210720154141.3919817-7-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210720154141.3919817-1-philmd@redhat.com> References: <20210720154141.3919817-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626795735736100001 The pci_ide_create_devs() function is declared i hw/ide/qdev.c: $ git grep ide_create_drive hw/ide/pci.c:491: ide_create_drive(d->bus + bus[i], unit[i], hd= _table[i]); hw/ide/qdev.c:127:IDEDevice *ide_create_drive(IDEBus *bus, int unit, Drive= Info *drive) include/hw/ide/internal.h:653:IDEDevice *ide_create_drive(IDEBus *bus, int= unit, DriveInfo *drive); Fix the correct symbol dependency to avoid build failure when deselecting some machines: /usr/bin/ld: libcommon.fa.p/hw_ide_pci.c.o: in function `pci_ide_create_d= evs': hw/ide/pci.c:491: undefined reference to `ide_create_drive' Fixes: 8f01b41e109 ("ide: express dependencies with Kconfig") Acked-by: Paolo Bonzini Reviewed-by: Bin Meng Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20210515173716.358295-3-philmd@redhat.com> Acked-by: John Snow --- hw/ide/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ide/Kconfig b/hw/ide/Kconfig index 8e2c8934549..dd85fa3619f 100644 --- a/hw/ide/Kconfig +++ b/hw/ide/Kconfig @@ -8,7 +8,7 @@ config IDE_QDEV config IDE_PCI bool depends on PCI - select IDE_CORE + select IDE_QDEV =20 config IDE_ISA bool --=20 2.31.1