From nobody Tue Feb 10 04:14:24 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626795771; cv=none; d=zohomail.com; s=zohoarc; b=BIzAfK/tiGF0C7gbyj8cKbZKeuKNk+ps/Ns3Dwe5dE7wzo7lIjlNFUGwA/UT1KgcB12trq4El/CbGqueydlIFcxt7hFGoUTF3g1NSBpyMoh3D4xg1svEC//4wOup4YloZde62C5uaIGh75hex2rSSUy8IKU0Z+qUVobCx6nWMes= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626795771; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=ke+K8CUdvIjT9wDwvnpP72CHpJjDbX0XKOULAYpAuTc=; b=ju2SQTC3M3VOkec1J4rxnJNYbrZya6bYe58KhWOzSKQMhIQ4FMobFGwlZkBWOeoLCxxar8It0oGrrhLuFEP/6V+46Obq2h6TGM7NWyo7HgfzglmS7t2/+B0HgHd4ydJcASl7u7P2IHiQ8jRqe/B8xp6rCht8GYvhojptGwk/2HM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1626795771695456.4853656774128; Tue, 20 Jul 2021 08:42:51 -0700 (PDT) Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-540-cX-6Uq8dM7WEyQ_6BgwlJQ-1; Tue, 20 Jul 2021 11:42:49 -0400 Received: by mail-wm1-f70.google.com with SMTP id l17-20020a05600c4f11b0290225ef65c35dso597691wmq.2 for ; Tue, 20 Jul 2021 08:42:49 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (122.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.122]) by smtp.gmail.com with ESMTPSA id o3sm24165228wrm.5.2021.07.20.08.42.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 08:42:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626795770; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ke+K8CUdvIjT9wDwvnpP72CHpJjDbX0XKOULAYpAuTc=; b=L4li5YXWRkSNHfTwSP//FAiElMq9pLK2aGYBJ5c1T4TuX7+I/QzPzpEXTqpxEddldLVJvY iHsY2mjT9Ere/UTZSHf3uzGQwVEO5VaeBcCG3YswO1dBniS1lKl7WL6gtJb1HnZq/G2aSa GIJEqLf1Cf7yQHNJ7tp2W2d0xNQ8FeU= X-MC-Unique: cX-6Uq8dM7WEyQ_6BgwlJQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ke+K8CUdvIjT9wDwvnpP72CHpJjDbX0XKOULAYpAuTc=; b=GJd5ggX7Xra67Qv9gU8RRSLSA0L8/AOAbTwbp/WsFXRTYamdt7HlfxjPhPneRKiazw CT4uyU6Of+q4TM6s/jQEGFEOw4QmVYV8GSG55oYdgHTYj6wmAJAWK4MAM8JmYhkHVf+h Xna/LZZwvLzYwgVbZvrCjxVgUeWf3ugNVWtYyHmowRmChH7T62LAweMXAa7O3B5vJVrw i7HI9CUqpWNCzCH0Wmg/nJ9ty+X/DtBuY8WrKKaPznGBsGlwkvU0REYTYg4ysvDWqEEM f2HcZ6M2ITAE8diFdiJQlbD/HKgyIL7WuN3vCTmDSYX5uimGrNHjYHxHFytmFFkyNXaq 994A== X-Gm-Message-State: AOAM531X1REUSjrayDzIrkCZLQSRQUv03HExrX6hsltfS3cIX19lVR4R uH4TqYYTSGMXfSSjx8UAwqPQo2AzhKpkdTqKBRVJIAmRcYVthW+Olg5X13MdIP4VvJd3rlPsTTS WZ1uNGheMPTHq9A== X-Received: by 2002:adf:e5ce:: with SMTP id a14mr35740314wrn.226.1626795768094; Tue, 20 Jul 2021 08:42:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzFjbDELn9PlVoMETbMcfKgU2MpoocKRAUMvu9ehxkvDcZjGQAk7yjfnceBxktfN5Y4tvyqXg== X-Received: by 2002:adf:e5ce:: with SMTP id a14mr35740295wrn.226.1626795767907; Tue, 20 Jul 2021 08:42:47 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , BALATON Zoltan , Bin Meng Subject: [PULL 15/17] hw/isa/vt82c686: Add missing Kconfig dependency (runtime error) Date: Tue, 20 Jul 2021 17:41:39 +0200 Message-Id: <20210720154141.3919817-16-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210720154141.3919817-1-philmd@redhat.com> References: <20210720154141.3919817-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626795773209100001 From: Philippe Mathieu-Daud=C3=A9 When building the Pegasos2 machine stand-alone we get: $ qemu-system-ppc -M pegasos2 -bios pegasos2.rom ERROR:qom/object.c:714:object_new_with_type: assertion failed: (type !=3D= NULL) Bail out! ERROR:qom/object.c:714:object_new_with_type: assertion failed: = (type !=3D NULL) Looking at the backtrace: Thread 1 "qemu-system-ppc" received signal SIGABRT, Aborted. (gdb) bt #0 0x00007ffff53877d5 in raise () at /lib64/libc.so.6 #1 0x00007ffff5370895 in abort () at /lib64/libc.so.6 #2 0x00007ffff6dc4b6c in g_assertion_message_expr.cold () at /lib64/libg= lib-2.0.so.0 #3 0x00007ffff6e229ff in g_assertion_message_expr () at /lib64/libglib-2= .0.so.0 #4 0x0000555555a0c8f4 in object_new_with_type (type=3D0x0) at qom/object= .c:714 #5 0x0000555555a0c9d5 in object_new (typename=3D0x555555c7afe4 "isa-pit"= ) at qom/object.c:747 #6 0x0000555555a053b8 in qdev_new (name=3D0x555555c7afe4 "isa-pit") at h= w/core/qdev.c:153 #7 0x00005555557cdd05 in isa_new (name=3D0x555555c7afe4 "isa-pit") at hw= /isa/isa-bus.c:160 #8 0x00005555557cf518 in i8254_pit_init (bus=3D0x55555603d140, base=3D64= , isa_irq=3D0, alt_irq=3D0x0) at include/hw/timer/i8254.h:54 #9 0x00005555557d12f9 in vt8231_realize (d=3D0x5555563d9770, errp=3D0x7f= ffffffcc28) at hw/isa/vt82c686.c:704 #10 0x00005555557e1340 in pci_qdev_realize (qdev=3D0x5555563d9770, errp= =3D0x7fffffffcca0) at hw/pci/pci.c:2116 #11 0x0000555555a06a84 in device_set_realized (obj=3D0x5555563d9770, valu= e=3Dtrue, errp=3D0x7fffffffcda8) at hw/core/qdev.c:761 #12 0x0000555555a0ff9e in property_set_bool (obj=3D0x5555563d9770, v=3D0x= 5555563da090, name=3D0x555555cd7881 "realized", opaque=3D0x5555560acf80, er= rp=3D0x7fffffffcda8) at qom/object.c:2257 #13 0x0000555555a0e098 in object_property_set (obj=3D0x5555563d9770, name= =3D0x555555cd7881 "realized", v=3D0x5555563da090, errp=3D0x555555fc3fa0 ) at qom/object.c:1402 #14 0x0000555555a12271 in object_property_set_qobject (obj=3D0x5555563d97= 70, name=3D0x555555cd7881 "realized", value=3D0x5555563cf0a0, errp=3D0x5555= 55fc3fa0 ) at qom/qom-qobject.c:28 #15 0x0000555555a0e3fb in object_property_set_bool (obj=3D0x5555563d9770,= name=3D0x555555cd7881 "realized", value=3Dtrue, errp=3D0x555555fc3fa0 ) at qom/object.c:1472 #16 0x0000555555a05b15 in qdev_realize (dev=3D0x5555563d9770, bus=3D0x555= 5563d32b0, errp=3D0x555555fc3fa0 ) at hw/core/qdev.c:389 #17 0x0000555555a05b42 in qdev_realize_and_unref (dev=3D0x5555563d9770, b= us=3D0x5555563d32b0, errp=3D0x555555fc3fa0 ) at hw/core/qdev.c= :396 #18 0x00005555557e160f in pci_realize_and_unref (dev=3D0x5555563d9770, bu= s=3D0x5555563d32b0, errp=3D0x555555fc3fa0 ) at hw/pci/pci.c:21= 81 #19 0x00005555557e165b in pci_create_simple_multifunction (bus=3D0x555556= 3d32b0, devfn=3D96, multifunction=3Dtrue, name=3D0x555555c9b63b "vt8231-isa= ") at hw/pci/pci.c:2189 #20 0x0000555555867730 in pegasos2_init (machine=3D0x5555560427a0) at hw/= ppc/pegasos2.c:105 The "isa-pit" type (TYPE_I8254) is missing. Add it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20210515173716.358295-12-philmd@redhat.com> Reviewed-by: BALATON Zoltan Reviewed-by: Bin Meng --- hw/isa/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig index f99df0e20b1..e4db60ed580 100644 --- a/hw/isa/Kconfig +++ b/hw/isa/Kconfig @@ -50,6 +50,7 @@ config VT82C686 select FDC_ISA select USB_UHCI select APM + select I8254 select I8257 select I8259 select MC146818RTC --=20 2.31.1